* [PATCH] xfs/010,030: filter AG header CRC error warnings
@ 2020-07-13 18:49 Darrick J. Wong
2020-07-14 7:13 ` Zorro Lang
0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2020-07-13 18:49 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests, xfs
From: Darrick J. Wong <darrick.wong@oracle.com>
Filter out the new AG header CRC verification warnings in xfs_repair
since these tests were built before that existed.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
tests/xfs/010 | 6 +++++-
tests/xfs/030 | 2 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/xfs/010 b/tests/xfs/010
index c341795d..ec23507a 100755
--- a/tests/xfs/010
+++ b/tests/xfs/010
@@ -113,7 +113,11 @@ _check_scratch_fs
# nuke the finobt root, repair will have to regenerate from the inobt
_corrupt_finobt_root $SCRATCH_DEV
-_scratch_xfs_repair 2>&1 | sed -e '/^bad finobt block/d' | _filter_repair_lostblocks
+filter_finobt_repair() {
+ sed -e '/^agi has bad CRC/d' -e '/^bad finobt block/d' | _filter_repair_lostblocks
+}
+
+_scratch_xfs_repair 2>&1 | filter_finobt_repair
status=0
exit
diff --git a/tests/xfs/030 b/tests/xfs/030
index 8f95331a..a270e36c 100755
--- a/tests/xfs/030
+++ b/tests/xfs/030
@@ -43,6 +43,8 @@ _check_ag()
-e '/^bad agbno AGBNO for rmapbt/d' \
-e '/^bad agbno AGBNO for refcntbt/d' \
-e '/^bad inobt block count/d' \
+ -e '/^agf has bad CRC/d' \
+ -e '/^agi has bad CRC/d' \
-e '/^bad finobt block count/d' \
-e '/^Missing reverse-mapping record.*/d' \
-e '/^unknown block state, ag AGNO, block.*/d'
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs/010,030: filter AG header CRC error warnings
2020-07-13 18:49 [PATCH] xfs/010,030: filter AG header CRC error warnings Darrick J. Wong
@ 2020-07-14 7:13 ` Zorro Lang
2020-07-15 16:57 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Zorro Lang @ 2020-07-14 7:13 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Eryu Guan, fstests, xfs
On Mon, Jul 13, 2020 at 11:49:30AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Filter out the new AG header CRC verification warnings in xfs_repair
> since these tests were built before that existed.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tests/xfs/010 | 6 +++++-
> tests/xfs/030 | 2 ++
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/tests/xfs/010 b/tests/xfs/010
> index c341795d..ec23507a 100755
> --- a/tests/xfs/010
> +++ b/tests/xfs/010
> @@ -113,7 +113,11 @@ _check_scratch_fs
> # nuke the finobt root, repair will have to regenerate from the inobt
> _corrupt_finobt_root $SCRATCH_DEV
>
> -_scratch_xfs_repair 2>&1 | sed -e '/^bad finobt block/d' | _filter_repair_lostblocks
I think this patch is based on another patch which hasn't been merged, right?
Due to I can't find the *sed -e '/^bad finobt block/d'* on current xfstests-dev
master branch, which HEAD is:
aae8fbec generic/270: wait for fsstress processes to be killed
Thanks,
Zorro
> +filter_finobt_repair() {
> + sed -e '/^agi has bad CRC/d' -e '/^bad finobt block/d' | _filter_repair_lostblocks
> +}
> +
> +_scratch_xfs_repair 2>&1 | filter_finobt_repair
>
> status=0
> exit
> diff --git a/tests/xfs/030 b/tests/xfs/030
> index 8f95331a..a270e36c 100755
> --- a/tests/xfs/030
> +++ b/tests/xfs/030
> @@ -43,6 +43,8 @@ _check_ag()
> -e '/^bad agbno AGBNO for rmapbt/d' \
> -e '/^bad agbno AGBNO for refcntbt/d' \
> -e '/^bad inobt block count/d' \
> + -e '/^agf has bad CRC/d' \
> + -e '/^agi has bad CRC/d' \
> -e '/^bad finobt block count/d' \
> -e '/^Missing reverse-mapping record.*/d' \
> -e '/^unknown block state, ag AGNO, block.*/d'
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs/010,030: filter AG header CRC error warnings
2020-07-14 7:13 ` Zorro Lang
@ 2020-07-15 16:57 ` Darrick J. Wong
0 siblings, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2020-07-15 16:57 UTC (permalink / raw)
To: Eryu Guan, fstests, xfs
On Tue, Jul 14, 2020 at 03:13:46PM +0800, Zorro Lang wrote:
> On Mon, Jul 13, 2020 at 11:49:30AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Filter out the new AG header CRC verification warnings in xfs_repair
> > since these tests were built before that existed.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > tests/xfs/010 | 6 +++++-
> > tests/xfs/030 | 2 ++
> > 2 files changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/xfs/010 b/tests/xfs/010
> > index c341795d..ec23507a 100755
> > --- a/tests/xfs/010
> > +++ b/tests/xfs/010
> > @@ -113,7 +113,11 @@ _check_scratch_fs
> > # nuke the finobt root, repair will have to regenerate from the inobt
> > _corrupt_finobt_root $SCRATCH_DEV
> >
> > -_scratch_xfs_repair 2>&1 | sed -e '/^bad finobt block/d' | _filter_repair_lostblocks
>
> I think this patch is based on another patch which hasn't been merged, right?
> Due to I can't find the *sed -e '/^bad finobt block/d'* on current xfstests-dev
> master branch, which HEAD is:
> aae8fbec generic/270: wait for fsstress processes to be killed
Oops, yeah, I forgot that my development branch has multiple patches to
those tests. Now that xfsprogs for-next has updated I guess I should
clean all those up and send them for real.
--D
> Thanks,
> Zorro
>
> > +filter_finobt_repair() {
> > + sed -e '/^agi has bad CRC/d' -e '/^bad finobt block/d' | _filter_repair_lostblocks
> > +}
> > +
> > +_scratch_xfs_repair 2>&1 | filter_finobt_repair
> >
> > status=0
> > exit
> > diff --git a/tests/xfs/030 b/tests/xfs/030
> > index 8f95331a..a270e36c 100755
> > --- a/tests/xfs/030
> > +++ b/tests/xfs/030
> > @@ -43,6 +43,8 @@ _check_ag()
> > -e '/^bad agbno AGBNO for rmapbt/d' \
> > -e '/^bad agbno AGBNO for refcntbt/d' \
> > -e '/^bad inobt block count/d' \
> > + -e '/^agf has bad CRC/d' \
> > + -e '/^agi has bad CRC/d' \
> > -e '/^bad finobt block count/d' \
> > -e '/^Missing reverse-mapping record.*/d' \
> > -e '/^unknown block state, ag AGNO, block.*/d'
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-15 16:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-13 18:49 [PATCH] xfs/010,030: filter AG header CRC error warnings Darrick J. Wong
2020-07-14 7:13 ` Zorro Lang
2020-07-15 16:57 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).