From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/5] xfs: fix ordering violation between cache flushes and tail updates
Date: Thu, 22 Jul 2021 17:28:27 +1000 [thread overview]
Message-ID: <20210722072827.GM664593@dread.disaster.area> (raw)
In-Reply-To: <YPkZB7aY3foxa594@infradead.org>
On Thu, Jul 22, 2021 at 08:06:47AM +0100, Christoph Hellwig wrote:
> Due the combination of the code move and the actual change I had
> a really hard time reviewing this.
>
> > - trace_xlog_iclog_syncing(iclog, _RET_IP_);
>
> This tracepoint got lost.
Ah, will fix that.
> Otherwise this looks good.
>
> As I had to split the move from the technical changes to follow
> the change I might as well share my split, attached below as two
> patches:
Yeah, I haven't got to that point yet - I'm still chasing a wild
goose that is now only showing up once every 3 or 4 hours of
cyclic testing, so I've been trying to capture that in sufficient
detail to be able to diagnose the failure. I wanted to get these out
there so new eyes might see what I'm missing or suggest a better
approach...
I'll add this split into my patchset tomorrow when I go looking at
the corpses overnight testing created...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2021-07-22 7:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 1:53 [PATCH 0/5] xfs: fix log cache flush regressions Dave Chinner
2021-07-22 1:53 ` [PATCH 1/5] xfs: flush data dev on external log write Dave Chinner
2021-07-22 6:41 ` Christoph Hellwig
2021-07-22 15:52 ` Darrick J. Wong
2021-07-22 1:53 ` [PATCH 2/5] xfs: external logs need to flush data device Dave Chinner
2021-07-22 6:48 ` Christoph Hellwig
2021-07-22 18:14 ` Darrick J. Wong
2021-07-22 21:45 ` Dave Chinner
2021-07-22 23:10 ` Darrick J. Wong
2021-07-22 1:53 ` [PATCH 3/5] xfs: fix ordering violation between cache flushes and tail updates Dave Chinner
2021-07-22 7:06 ` Christoph Hellwig
2021-07-22 7:28 ` Dave Chinner [this message]
2021-07-22 19:12 ` Darrick J. Wong
2021-07-22 1:53 ` [PATCH 4/5] xfs: log forces imply data device cache flushes Dave Chinner
2021-07-22 7:14 ` Christoph Hellwig
2021-07-22 7:32 ` Dave Chinner
2021-07-22 19:30 ` Darrick J. Wong
2021-07-22 22:12 ` Dave Chinner
2021-07-22 23:13 ` Darrick J. Wong
2021-07-22 1:53 ` [PATCH 5/5] xfs: avoid unnecessary waits in xfs_log_force_lsn() Dave Chinner
2021-07-22 7:15 ` Christoph Hellwig
2021-07-22 19:13 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210722072827.GM664593@dread.disaster.area \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).