From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/5] xfs: external logs need to flush data device
Date: Thu, 22 Jul 2021 07:48:33 +0100 [thread overview]
Message-ID: <YPkUwd/IridkTHAQ@infradead.org> (raw)
In-Reply-To: <20210722015335.3063274-3-david@fromorbit.com>
On Thu, Jul 22, 2021 at 11:53:32AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The recent journal flush/FUA changes replaced the flushing of the
> data device on every iclog write with an up-front async data device
> cache flush. Unfortunately, the assumption of which this was based
> on has been proven incorrect by the flush vs log tail update
> ordering issue. As the fix for that issue uses the
> XLOG_ICL_NEED_FLUSH flag to indicate that data device needs a cache
> flush, we now need to (once again) ensure that an iclog write to
> external logs that need a cache flush to be issued actually issue a
> cache flush to the data device as well as the log device.
>
> Fixes: eef983ffeae7 ("xfs: journal IO cache flush reductions")
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-07-22 6:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 1:53 [PATCH 0/5] xfs: fix log cache flush regressions Dave Chinner
2021-07-22 1:53 ` [PATCH 1/5] xfs: flush data dev on external log write Dave Chinner
2021-07-22 6:41 ` Christoph Hellwig
2021-07-22 15:52 ` Darrick J. Wong
2021-07-22 1:53 ` [PATCH 2/5] xfs: external logs need to flush data device Dave Chinner
2021-07-22 6:48 ` Christoph Hellwig [this message]
2021-07-22 18:14 ` Darrick J. Wong
2021-07-22 21:45 ` Dave Chinner
2021-07-22 23:10 ` Darrick J. Wong
2021-07-22 1:53 ` [PATCH 3/5] xfs: fix ordering violation between cache flushes and tail updates Dave Chinner
2021-07-22 7:06 ` Christoph Hellwig
2021-07-22 7:28 ` Dave Chinner
2021-07-22 19:12 ` Darrick J. Wong
2021-07-22 1:53 ` [PATCH 4/5] xfs: log forces imply data device cache flushes Dave Chinner
2021-07-22 7:14 ` Christoph Hellwig
2021-07-22 7:32 ` Dave Chinner
2021-07-22 19:30 ` Darrick J. Wong
2021-07-22 22:12 ` Dave Chinner
2021-07-22 23:13 ` Darrick J. Wong
2021-07-22 1:53 ` [PATCH 5/5] xfs: avoid unnecessary waits in xfs_log_force_lsn() Dave Chinner
2021-07-22 7:15 ` Christoph Hellwig
2021-07-22 19:13 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPkUwd/IridkTHAQ@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).