From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, alex@zadara.com
Subject: Re: [PATCH 3/7] xfs_repair: enforce that inode btree chunks can't point to AG headers
Date: Wed, 26 Feb 2020 09:09:42 -0800 [thread overview]
Message-ID: <dd15d451-c745-0318-91b0-36864c0052f7@sandeen.net> (raw)
In-Reply-To: <158086361666.2079685.8451949513769071894.stgit@magnolia>
On 2/4/20 4:46 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> xfs_repair has a very old check that evidently excuses the AG 0 inode
> btrees pointing to blocks that are already marked XR_E_INUSE_FS* (e.g.
> AG headers). mkfs never formats filesystems that way and it looks like
> an error, so purge the check. After this, we always complain if inodes
> overlap with AG headers because that should never happen.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
I know it's hard to keep track, but it'd be nice if
> - ASSERT(M_IGEO(mp)->ialloc_blks > 0);
this line had been kept per the feedback on the last patchset...
This also lost my feedback the first time, re:
@@ -1782,18 +1775,6 @@ _("inode chunk claims untracked block, finobt block - agno %d, bno %d, inopb %d\
break;
case XR_E_INUSE_FS:
case XR_E_INUSE_FS1:
"I guess there's no real reason to list a couple cases that all fall through
to default:, I'd just remove them as well since they aren't any more special
than the other unmentioned cases."
- if (agno == 0 &&
- ino + j >= first_prealloc_ino &&
- ino + j < last_prealloc_ino) {
- do_warn(
-_("inode chunk claims untracked block, finobt block - agno %d, bno %d, inopb %d\n"),
- agno, agbno, mp->m_sb.sb_inopblock);
-
- set_bmap(agno, agbno, XR_E_INO);
- suspect++;
- break;
- }
- /* fall through */
default:
I guess I should stop saying "I'll do that on the way in" if 2 more versions are going
to hit the list, maybe it takes the feedback off your radar.
-Eric
next prev parent reply other threads:[~2020-02-26 17:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 0:46 [PATCH v4 0/7] xfs_repair: do not trash valid root dirs Darrick J. Wong
2020-02-05 0:46 ` [PATCH 1/7] xfs_repair: replace verify_inum with libxfs inode validators Darrick J. Wong
2020-02-05 0:50 ` Darrick J. Wong
2020-02-17 13:50 ` Christoph Hellwig
2020-02-19 4:32 ` Darrick J. Wong
2020-02-26 16:55 ` Eric Sandeen
2020-02-05 0:46 ` [PATCH 2/7] mkfs: check root inode location Darrick J. Wong
2020-02-17 13:50 ` Christoph Hellwig
2020-02-05 0:46 ` [PATCH 3/7] xfs_repair: enforce that inode btree chunks can't point to AG headers Darrick J. Wong
2020-02-17 13:51 ` Christoph Hellwig
2020-02-26 17:09 ` Eric Sandeen [this message]
2020-02-26 17:24 ` Darrick J. Wong
2020-02-26 17:34 ` Eric Sandeen
2020-02-26 17:19 ` Eric Sandeen
2020-02-26 17:32 ` Darrick J. Wong
2020-02-26 17:40 ` Eric Sandeen
2020-02-05 0:47 ` [PATCH 4/7] xfs_repair: refactor fixed inode location checks Darrick J. Wong
2020-02-17 13:51 ` Christoph Hellwig
2020-02-05 0:47 ` [PATCH 5/7] xfs_repair: use libxfs function to calculate root inode location Darrick J. Wong
2020-02-17 13:53 ` Christoph Hellwig
2020-02-05 0:47 ` [PATCH 6/7] xfs_repair: check plausibility of root dir pointer before trashing it Darrick J. Wong
2020-02-17 13:53 ` Christoph Hellwig
2020-02-05 0:47 ` [PATCH 7/7] xfs_repair: try to correct sb_unit value from secondaries Darrick J. Wong
2020-02-17 13:55 ` Christoph Hellwig
2020-02-26 17:42 ` Eric Sandeen
2020-02-26 17:55 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd15d451-c745-0318-91b0-36864c0052f7@sandeen.net \
--to=sandeen@sandeen.net \
--cc=alex@zadara.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).