From: David Laight <David.Laight@ACULAB.COM>
To: 'Viresh Kumar' <viresh.kumar@linaro.org>
Cc: "ego@linux.vnet.ibm.com" <ego@linux.vnet.ibm.com>,
Linux PM list <linux-pm@vger.kernel.org>,
"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: RE: [PATCH v3 5/5] powernv:cpufreq: Implement the driver->get() method
Date: Fri, 21 Mar 2014 15:01:09 +0000 [thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D0F6E5677@AcuExch.aculab.com> (raw)
In-Reply-To: <CAKohpo=E1UEcLhbZHtmBJcD3S3trm8ypT7++quF_t6XHDXAvHA@mail.gmail.com>
From: Viresh Kumar [mailto:viresh.kumar@linaro.org]
> On 21 March 2014 17:31, David Laight <David.Laight@aculab.com> wrote:
> >> *(int *)ret_freq =3D freq;
> >
> > Because it is very likely to be wrong.
> > In general casts of pointers to integer types are dangerous.
>=20
> Where are we converting pointers to integers? We are doing a
> cast from 'void * ' to 'int *' and then using indirection operator
> to set its value.
You mis-parsed what I wrote, try:
In general casts of 'pointer to integer' types are dangerous.
Somewhere, much higher up the call stack, the address of an integer
variable is being taken and then passed as the 'void *' parameter.
The 'problem' is that it is quite easily to pass the address of
a 'long' instead. On 32bit and LE systems this won't always
be a problem. On 64bit BE it all goes wrong.
David
next prev parent reply other threads:[~2014-03-21 15:02 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 12:10 [PATCH v3 0/5] powernv: Enable Dynamic Frequency Gautham R. Shenoy
2014-03-20 12:10 ` [PATCH v3 1/5] powernv: cpufreq driver for powernv platform Gautham R. Shenoy
2014-03-21 8:41 ` Viresh Kumar
2014-03-21 10:43 ` Gautham R Shenoy
2014-03-21 10:54 ` Viresh Kumar
2014-03-21 11:40 ` Srivatsa S. Bhat
2014-03-21 13:23 ` Gautham R Shenoy
2014-03-21 13:34 ` Viresh Kumar
2014-03-21 14:54 ` Gautham R Shenoy
2014-03-22 3:43 ` Viresh Kumar
2014-03-21 14:48 ` Vaidyanathan Srinivasan
2014-03-22 3:43 ` Viresh Kumar
2014-03-21 11:45 ` Srivatsa S. Bhat
2014-03-21 11:47 ` Viresh Kumar
2014-03-20 12:10 ` [PATCH v3 2/5] powernv, cpufreq:Add per-core locking to serialize frequency transitions Gautham R. Shenoy
2014-03-21 6:24 ` Gautham R Shenoy
2014-03-21 8:42 ` Viresh Kumar
2014-03-21 9:56 ` Srivatsa S. Bhat
2014-03-20 12:10 ` [PATCH v3 3/5] powernv:cpufreq: Create pstate_id_to_freq() helper Gautham R. Shenoy
2014-03-21 6:24 ` Gautham R Shenoy
2014-03-20 12:10 ` [PATCH v3 4/5] powernv:cpufreq: Export nominal frequency via sysfs Gautham R. Shenoy
2014-03-21 8:47 ` Viresh Kumar
2014-03-21 9:55 ` Gautham R Shenoy
2014-03-21 9:57 ` Viresh Kumar
2014-03-20 12:11 ` [PATCH v3 5/5] powernv:cpufreq: Implement the driver->get() method Gautham R. Shenoy
2014-03-21 6:25 ` Gautham R Shenoy
2014-03-21 9:31 ` Viresh Kumar
2014-03-21 11:04 ` Gautham R Shenoy
2014-03-21 11:45 ` Viresh Kumar
2014-03-21 12:01 ` David Laight
2014-03-21 12:31 ` Gautham R Shenoy
2014-03-21 12:34 ` Viresh Kumar
2014-03-21 15:01 ` David Laight [this message]
2014-03-21 13:04 ` Gautham R Shenoy
2014-03-21 13:12 ` Viresh Kumar
2014-03-21 14:25 ` Gautham R Shenoy
2014-03-21 22:56 ` Benjamin Herrenschmidt
2014-03-22 7:53 ` Gautham R Shenoy
2014-03-21 7:46 ` [PATCH v3 0/5] powernv: Enable Dynamic Frequency Viresh Kumar
2014-03-21 8:19 ` Gautham R Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063D6719AE5E284EB5DD2968C1650D6D0F6E5677@AcuExch.aculab.com \
--to=david.laight@aculab.com \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).