From: Gautham R Shenoy <ego@linux.vnet.ibm.com>
To: David Laight <David.Laight@aculab.com>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
'Viresh Kumar' <viresh.kumar@linaro.org>,
Linux PM list <linux-pm@vger.kernel.org>,
"ego@linux.vnet.ibm.com" <ego@linux.vnet.ibm.com>
Subject: Re: [PATCH v3 5/5] powernv:cpufreq: Implement the driver->get() method
Date: Fri, 21 Mar 2014 18:01:06 +0530 [thread overview]
Message-ID: <20140321123106.GC2493@in.ibm.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D0F6E5386@AcuExch.aculab.com>
On Fri, Mar 21, 2014 at 12:01:07PM +0000, David Laight wrote:
> From: Viresh Kumar
>
> > On 21 March 2014 16:34, Gautham R Shenoy <ego@linux.vnet.ibm.com> wrote:
> > > Heh! Well, that wasn't the reason why this was sent out as a separate
> > > patch, but never mind. Though I don't understand why it would be
> > > difficult to review the patch though.
> >
> > Because the initial driver wasn't complete earlier. There were 2-3 patches
> > after the first one which are changing what the first patch has added.
> > Nothing else :)
> >
> > >> > +static void powernv_read_cpu_freq(void *ret_freq)
> > >> > +{
> > >> > + unsigned long pmspr_val;
> > >> > + s8 local_pstate_id;
> > >> > + int *cur_freq, freq, pstate_id;
> > >> > +
> > >> > + cur_freq = (int *)ret_freq;
> > >>
> > >> You don't need cur_freq variable at all..
> > >
> > > I don't like it either. But the compiler complains without this hack
> > > :-(
> >
> > Why would the compiler warn for doing this?:
> >
> > *(int *)ret_freq = freq;
>
> Because it is very likely to be wrong.
> In general casts of pointers to integer types are dangerous.
> In this case why not make the function return the value?
Because this function is called via an smp_call_function(). And we
need a way of returning the value to the caller.
>
> David
>
>
next prev parent reply other threads:[~2014-03-21 12:31 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 12:10 [PATCH v3 0/5] powernv: Enable Dynamic Frequency Gautham R. Shenoy
2014-03-20 12:10 ` [PATCH v3 1/5] powernv: cpufreq driver for powernv platform Gautham R. Shenoy
2014-03-21 8:41 ` Viresh Kumar
2014-03-21 10:43 ` Gautham R Shenoy
2014-03-21 10:54 ` Viresh Kumar
2014-03-21 11:40 ` Srivatsa S. Bhat
2014-03-21 13:23 ` Gautham R Shenoy
2014-03-21 13:34 ` Viresh Kumar
2014-03-21 14:54 ` Gautham R Shenoy
2014-03-22 3:43 ` Viresh Kumar
2014-03-21 14:48 ` Vaidyanathan Srinivasan
2014-03-22 3:43 ` Viresh Kumar
2014-03-21 11:45 ` Srivatsa S. Bhat
2014-03-21 11:47 ` Viresh Kumar
2014-03-20 12:10 ` [PATCH v3 2/5] powernv, cpufreq:Add per-core locking to serialize frequency transitions Gautham R. Shenoy
2014-03-21 6:24 ` Gautham R Shenoy
2014-03-21 8:42 ` Viresh Kumar
2014-03-21 9:56 ` Srivatsa S. Bhat
2014-03-20 12:10 ` [PATCH v3 3/5] powernv:cpufreq: Create pstate_id_to_freq() helper Gautham R. Shenoy
2014-03-21 6:24 ` Gautham R Shenoy
2014-03-20 12:10 ` [PATCH v3 4/5] powernv:cpufreq: Export nominal frequency via sysfs Gautham R. Shenoy
2014-03-21 8:47 ` Viresh Kumar
2014-03-21 9:55 ` Gautham R Shenoy
2014-03-21 9:57 ` Viresh Kumar
2014-03-20 12:11 ` [PATCH v3 5/5] powernv:cpufreq: Implement the driver->get() method Gautham R. Shenoy
2014-03-21 6:25 ` Gautham R Shenoy
2014-03-21 9:31 ` Viresh Kumar
2014-03-21 11:04 ` Gautham R Shenoy
2014-03-21 11:45 ` Viresh Kumar
2014-03-21 12:01 ` David Laight
2014-03-21 12:31 ` Gautham R Shenoy [this message]
2014-03-21 12:34 ` Viresh Kumar
2014-03-21 15:01 ` David Laight
2014-03-21 13:04 ` Gautham R Shenoy
2014-03-21 13:12 ` Viresh Kumar
2014-03-21 14:25 ` Gautham R Shenoy
2014-03-21 22:56 ` Benjamin Herrenschmidt
2014-03-22 7:53 ` Gautham R Shenoy
2014-03-21 7:46 ` [PATCH v3 0/5] powernv: Enable Dynamic Frequency Viresh Kumar
2014-03-21 8:19 ` Gautham R Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321123106.GC2493@in.ibm.com \
--to=ego@linux.vnet.ibm.com \
--cc=David.Laight@aculab.com \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).