* [PATCH] i2c: remove casting dma_alloc
@ 2019-06-23 21:13 Vasyl Gomonovych
2019-06-29 11:34 ` Wolfram Sang
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Vasyl Gomonovych @ 2019-06-23 21:13 UTC (permalink / raw)
To: jochen, linuxppc-dev, linux-i2c, linux-kernel; +Cc: Vasyl
From: Vasyl <gomonovych@gmail.com>
Generated by: alloc_cast.cocci
Signed-off-by: Vasyl <gomonovych@gmail.com>
---
drivers/i2c/busses/i2c-cpm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c
index 187900594e3d..1213e1932ccb 100644
--- a/drivers/i2c/busses/i2c-cpm.c
+++ b/drivers/i2c/busses/i2c-cpm.c
@@ -531,7 +531,9 @@ static int cpm_i2c_setup(struct cpm_i2c *cpm)
}
out_be32(&rbdf[i].cbd_bufaddr, ((cpm->rxdma[i] + 1) & ~1));
- cpm->txbuf[i] = (unsigned char *)dma_alloc_coherent(&cpm->ofdev->dev, CPM_MAX_READ + 1, &cpm->txdma[i], GFP_KERNEL);
+ cpm->txbuf[i] = dma_alloc_coherent(&cpm->ofdev->dev,
+ CPM_MAX_READ + 1,
+ &cpm->txdma[i], GFP_KERNEL);
if (!cpm->txbuf[i]) {
ret = -ENOMEM;
goto out_muram;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] i2c: remove casting dma_alloc
2019-06-23 21:13 [PATCH] i2c: remove casting dma_alloc Vasyl Gomonovych
@ 2019-06-29 11:34 ` Wolfram Sang
2019-06-29 11:41 ` Jochen Friedrich
2019-07-03 6:24 ` Jochen Friedrich
2019-07-05 18:44 ` Wolfram Sang
2 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2019-06-29 11:34 UTC (permalink / raw)
To: Vasyl Gomonovych, jochen; +Cc: linuxppc-dev, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]
On Sun, Jun 23, 2019 at 11:13:53PM +0200, Vasyl Gomonovych wrote:
> From: Vasyl <gomonovych@gmail.com>
>
> Generated by: alloc_cast.cocci
>
> Signed-off-by: Vasyl <gomonovych@gmail.com>
Your other patches in git history have your full name. Why not this one?
@Jochen: are you still there, your ack would be very welcome.
> ---
> drivers/i2c/busses/i2c-cpm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c
> index 187900594e3d..1213e1932ccb 100644
> --- a/drivers/i2c/busses/i2c-cpm.c
> +++ b/drivers/i2c/busses/i2c-cpm.c
> @@ -531,7 +531,9 @@ static int cpm_i2c_setup(struct cpm_i2c *cpm)
> }
> out_be32(&rbdf[i].cbd_bufaddr, ((cpm->rxdma[i] + 1) & ~1));
>
> - cpm->txbuf[i] = (unsigned char *)dma_alloc_coherent(&cpm->ofdev->dev, CPM_MAX_READ + 1, &cpm->txdma[i], GFP_KERNEL);
> + cpm->txbuf[i] = dma_alloc_coherent(&cpm->ofdev->dev,
> + CPM_MAX_READ + 1,
> + &cpm->txdma[i], GFP_KERNEL);
> if (!cpm->txbuf[i]) {
> ret = -ENOMEM;
> goto out_muram;
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] i2c: remove casting dma_alloc
2019-06-29 11:34 ` Wolfram Sang
@ 2019-06-29 11:41 ` Jochen Friedrich
2019-06-29 14:50 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Jochen Friedrich @ 2019-06-29 11:41 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Vasyl Gomonovych, linuxppc-dev, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/html, Size: 2214 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: remove casting dma_alloc
2019-06-29 11:41 ` Jochen Friedrich
@ 2019-06-29 14:50 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2019-06-29 14:50 UTC (permalink / raw)
To: Jochen Friedrich; +Cc: Vasyl Gomonovych, linuxppc-dev, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 354 bytes --]
Hi Jochen,
(could you send text emails, please?)
> yes, I'm still here. However, I don't have the hardware anymore to test the patch.
Thanks for answering!
And besides (not) testing, are you still open to review patches to the
best of your knowledge (I neither have most of the HW). Or do you prefer
to orphan the driver?
Kind regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: remove casting dma_alloc
2019-06-23 21:13 [PATCH] i2c: remove casting dma_alloc Vasyl Gomonovych
2019-06-29 11:34 ` Wolfram Sang
@ 2019-07-03 6:24 ` Jochen Friedrich
2019-07-05 18:44 ` Wolfram Sang
2 siblings, 0 replies; 6+ messages in thread
From: Jochen Friedrich @ 2019-07-03 6:24 UTC (permalink / raw)
To: Vasyl Gomonovych, linuxppc-dev, linux-i2c, linux-kernel
> From: Vasyl <gomonovych@gmail.com>
>
> Generated by: alloc_cast.cocci
>
> Signed-off-by: Vasyl <gomonovych@gmail.com>
Acked-by: Jochen Friedrich <jochen@scram.de>
> ---
> drivers/i2c/busses/i2c-cpm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c
> index 187900594e3d..1213e1932ccb 100644
> --- a/drivers/i2c/busses/i2c-cpm.c
> +++ b/drivers/i2c/busses/i2c-cpm.c
> @@ -531,7 +531,9 @@ static int cpm_i2c_setup(struct cpm_i2c *cpm)
> }
> out_be32(&rbdf[i].cbd_bufaddr, ((cpm->rxdma[i] + 1) & ~1));
>
> - cpm->txbuf[i] = (unsigned char *)dma_alloc_coherent(&cpm->ofdev->dev, CPM_MAX_READ + 1, &cpm->txdma[i], GFP_KERNEL);
> + cpm->txbuf[i] = dma_alloc_coherent(&cpm->ofdev->dev,
> + CPM_MAX_READ + 1,
> + &cpm->txdma[i], GFP_KERNEL);
> if (!cpm->txbuf[i]) {
> ret = -ENOMEM;
> goto out_muram;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] i2c: remove casting dma_alloc
2019-06-23 21:13 [PATCH] i2c: remove casting dma_alloc Vasyl Gomonovych
2019-06-29 11:34 ` Wolfram Sang
2019-07-03 6:24 ` Jochen Friedrich
@ 2019-07-05 18:44 ` Wolfram Sang
2 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2019-07-05 18:44 UTC (permalink / raw)
To: Vasyl Gomonovych; +Cc: linux-kernel, linuxppc-dev, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
On Sun, Jun 23, 2019 at 11:13:53PM +0200, Vasyl Gomonovych wrote:
> From: Vasyl <gomonovych@gmail.com>
>
> Generated by: alloc_cast.cocci
>
> Signed-off-by: Vasyl <gomonovych@gmail.com>
Applied to for-next, thanks! I fixed the missing full name for you, but
please fix your setup.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-05 18:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-23 21:13 [PATCH] i2c: remove casting dma_alloc Vasyl Gomonovych
2019-06-29 11:34 ` Wolfram Sang
2019-06-29 11:41 ` Jochen Friedrich
2019-06-29 14:50 ` Wolfram Sang
2019-07-03 6:24 ` Jochen Friedrich
2019-07-05 18:44 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).