From: Dave Hansen <dave.hansen@intel.com>
To: Michal Hocko <mhocko@kernel.org>, linux-mm@kvack.org
Cc: Tony Luck <tony.luck@intel.com>,
linux-ia64@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Pingfan Liu <kernelfans@gmail.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH] x86, numa: always initialize all possible nodes
Date: Thu, 24 Jan 2019 11:10:50 -0800 [thread overview]
Message-ID: <3a7a3cf2-b7d9-719e-85b0-352be49a6d0f@intel.com> (raw)
In-Reply-To: <20190124141727.GN4087@dhcp22.suse.cz>
On 1/24/19 6:17 AM, Michal Hocko wrote:
> and nr_cpus set to 4. The underlying reason is tha the device is bound
> to node 2 which doesn't have any memory and init_cpu_to_node only
> initializes memory-less nodes for possible cpus which nr_cpus restrics.
> This in turn means that proper zonelists are not allocated and the page
> allocator blows up.
This looks OK to me.
Could we add a few DEBUG_VM checks that *look* for these invalid
zonelists? Or, would our existing list debugging have caught this?
Basically, is this bug also a sign that we need better debugging around
this?
next prev parent reply other threads:[~2019-01-24 19:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 8:24 [RFC PATCH] x86, numa: always initialize all possible nodes Michal Hocko
2019-01-14 10:26 ` Michael Ellerman
2019-01-14 11:48 ` Michal Hocko
2019-01-15 5:32 ` Pingfan Liu
2019-01-24 14:17 ` Michal Hocko
2019-01-24 17:51 ` Mike Rapoport
2019-01-25 10:40 ` Michal Hocko
2019-01-25 19:25 ` Mike Rapoport
2019-01-24 19:10 ` Dave Hansen [this message]
2019-01-25 10:50 ` Michal Hocko
2019-02-11 13:49 ` Ingo Molnar
2019-02-11 14:52 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a7a3cf2-b7d9-719e-85b0-352be49a6d0f@intel.com \
--to=dave.hansen@intel.com \
--cc=kernelfans@gmail.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@kernel.org \
--cc=peterz@infradead.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).