* [PATCH v2] cpufreq: powernv: add of_node_put()
@ 2018-11-20 16:05 Yangtao Li
2018-11-21 4:02 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Yangtao Li @ 2018-11-20 16:05 UTC (permalink / raw)
To: rjw, viresh.kumar, benh, paulus, mpe
Cc: Yangtao Li, linuxppc-dev, linux-kernel, linux-pm
The of_find_node_by_path() returns a node pointer with refcount
incremented,but there is the lack of use of the of_node_put() when
done.Add the missing of_node_put() to release the refcount.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
Changes in v2
-update changelog
---
drivers/cpufreq/powernv-cpufreq.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
index bf6519cf64bc..7e7ad3879c4e 100644
--- a/drivers/cpufreq/powernv-cpufreq.c
+++ b/drivers/cpufreq/powernv-cpufreq.c
@@ -253,18 +253,18 @@ static int init_powernv_pstates(void)
if (of_property_read_u32(power_mgt, "ibm,pstate-min", &pstate_min)) {
pr_warn("ibm,pstate-min node not found\n");
- return -ENODEV;
+ goto out;
}
if (of_property_read_u32(power_mgt, "ibm,pstate-max", &pstate_max)) {
pr_warn("ibm,pstate-max node not found\n");
- return -ENODEV;
+ goto out;
}
if (of_property_read_u32(power_mgt, "ibm,pstate-nominal",
&pstate_nominal)) {
pr_warn("ibm,pstate-nominal not found\n");
- return -ENODEV;
+ goto out;
}
if (of_property_read_u32(power_mgt, "ibm,pstate-ultra-turbo",
@@ -293,14 +293,14 @@ static int init_powernv_pstates(void)
pstate_ids = of_get_property(power_mgt, "ibm,pstate-ids", &len_ids);
if (!pstate_ids) {
pr_warn("ibm,pstate-ids not found\n");
- return -ENODEV;
+ goto out;
}
pstate_freqs = of_get_property(power_mgt, "ibm,pstate-frequencies-mhz",
&len_freqs);
if (!pstate_freqs) {
pr_warn("ibm,pstate-frequencies-mhz not found\n");
- return -ENODEV;
+ goto out;
}
if (len_ids != len_freqs) {
@@ -311,7 +311,7 @@ static int init_powernv_pstates(void)
nr_pstates = min(len_ids, len_freqs) / sizeof(u32);
if (!nr_pstates) {
pr_warn("No PStates found\n");
- return -ENODEV;
+ goto out;
}
powernv_pstate_info.nr_pstates = nr_pstates;
@@ -352,7 +352,12 @@ static int init_powernv_pstates(void)
/* End of list marker entry */
powernv_freqs[i].frequency = CPUFREQ_TABLE_END;
+
+ of_node_put(power_mgt);
return 0;
+out:
+ of_node_put(power_mgt);
+ return -ENODEV;
}
/* Returns the CPU frequency corresponding to the pstate_id. */
--
2.17.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] cpufreq: powernv: add of_node_put()
2018-11-20 16:05 [PATCH v2] cpufreq: powernv: add of_node_put() Yangtao Li
@ 2018-11-21 4:02 ` Viresh Kumar
2018-11-26 13:00 ` Frank Lee
2018-12-11 10:42 ` Rafael J. Wysocki
0 siblings, 2 replies; 4+ messages in thread
From: Viresh Kumar @ 2018-11-21 4:02 UTC (permalink / raw)
To: Yangtao Li; +Cc: linux-pm, rjw, linux-kernel, paulus, linuxppc-dev
On 20-11-18, 11:05, Yangtao Li wrote:
> The of_find_node_by_path() returns a node pointer with refcount
> incremented,but there is the lack of use of the of_node_put() when
> done.Add the missing of_node_put() to release the refcount.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> Changes in v2
> -update changelog
> ---
> drivers/cpufreq/powernv-cpufreq.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] cpufreq: powernv: add of_node_put()
2018-11-21 4:02 ` Viresh Kumar
@ 2018-11-26 13:00 ` Frank Lee
2018-12-11 10:42 ` Rafael J. Wysocki
1 sibling, 0 replies; 4+ messages in thread
From: Frank Lee @ 2018-11-26 13:00 UTC (permalink / raw)
To: ego; +Cc: linux-pm, rjw, linux-kernel, Viresh Kumar, paulus, linuxppc-dev
On Wed, Nov 21, 2018 at 12:02 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 20-11-18, 11:05, Yangtao Li wrote:
> > The of_find_node_by_path() returns a node pointer with refcount
> > incremented,but there is the lack of use of the of_node_put() when
> > done.Add the missing of_node_put() to release the refcount.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > ---
> > Changes in v2
> > -update changelog
> > ---
> > drivers/cpufreq/powernv-cpufreq.c | 17 +++++++++++------
> > 1 file changed, 11 insertions(+), 6 deletions(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> --
> viresh
Hi Gautham:
Can you add your Reviewed-by here?
Thanks,
Yangtao
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] cpufreq: powernv: add of_node_put()
2018-11-21 4:02 ` Viresh Kumar
2018-11-26 13:00 ` Frank Lee
@ 2018-12-11 10:42 ` Rafael J. Wysocki
1 sibling, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2018-12-11 10:42 UTC (permalink / raw)
To: Viresh Kumar, Yangtao Li; +Cc: linux-pm, linux-kernel, paulus, linuxppc-dev
On Wednesday, November 21, 2018 5:02:04 AM CET Viresh Kumar wrote:
> On 20-11-18, 11:05, Yangtao Li wrote:
> > The of_find_node_by_path() returns a node pointer with refcount
> > incremented,but there is the lack of use of the of_node_put() when
> > done.Add the missing of_node_put() to release the refcount.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > ---
> > Changes in v2
> > -update changelog
> > ---
> > drivers/cpufreq/powernv-cpufreq.c | 17 +++++++++++------
> > 1 file changed, 11 insertions(+), 6 deletions(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Patch applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-11 10:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-20 16:05 [PATCH v2] cpufreq: powernv: add of_node_put() Yangtao Li
2018-11-21 4:02 ` Viresh Kumar
2018-11-26 13:00 ` Frank Lee
2018-12-11 10:42 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).