linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* WARNING in iguanair_probe/usb_submit_urb
@ 2019-07-26 12:28 syzbot
  2019-07-29 11:25 ` Oliver Neukum
  0 siblings, 1 reply; 3+ messages in thread
From: syzbot @ 2019-07-26 12:28 UTC (permalink / raw)
  To: andreyknvl, gregkh, gustavo, linux-kernel, linux-usb, syzkaller-bugs

Hello,

syzbot found the following crash on:

HEAD commit:    6a3599ce usb-fuzzer: main usb gadget fuzzer driver
git tree:       https://github.com/google/kasan.git usb-fuzzer
console output: https://syzkaller.appspot.com/x/log.txt?x=164ab1f0600000
kernel config:  https://syzkaller.appspot.com/x/.config?x=700ca426ab83faae
dashboard link: https://syzkaller.appspot.com/bug?extid=01a77b82edaa374068e1
compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=143d7978600000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=134623f4600000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+01a77b82edaa374068e1@syzkaller.appspotmail.com

usb 1-1: config 0 interface 153 altsetting 0 bulk endpoint 0xA has invalid  
maxpacket 0
usb 1-1: New USB device found, idVendor=1781, idProduct=0938,  
bcdDevice=13.1e
usb 1-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0
usb 1-1: config 0 descriptor??
------------[ cut here ]------------
usb 1-1: BOGUS urb xfer, pipe 1 != type 3
WARNING: CPU: 1 PID: 21 at drivers/usb/core/urb.c:477  
usb_submit_urb+0x1188/0x13b0 drivers/usb/core/urb.c:477
Kernel panic - not syncing: panic_on_warn set ...
CPU: 1 PID: 21 Comm: kworker/1:1 Not tainted 5.2.0-rc6+ #15
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS  
Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
  __dump_stack lib/dump_stack.c:77 [inline]
  dump_stack+0xca/0x13e lib/dump_stack.c:113
  panic+0x292/0x6c9 kernel/panic.c:219
  __warn.cold+0x20/0x4b kernel/panic.c:576
  report_bug+0x262/0x2a0 lib/bug.c:186
  fixup_bug arch/x86/kernel/traps.c:179 [inline]
  fixup_bug arch/x86/kernel/traps.c:174 [inline]
  do_error_trap+0x12b/0x1e0 arch/x86/kernel/traps.c:272
  do_invalid_op+0x32/0x40 arch/x86/kernel/traps.c:291
  invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:986
RIP: 0010:usb_submit_urb+0x1188/0x13b0 drivers/usb/core/urb.c:477
Code: 4d 85 ed 74 2c e8 f8 d3 f4 fd 4c 89 f7 e8 a0 51 1c ff 41 89 d8 44 89  
e1 4c 89 ea 48 89 c6 48 c7 c7 00 0e f7 85 e8 83 98 ca fd <0f> 0b e9 20 f4  
ff ff e8 cc d3 f4 fd 4c 89 f2 48 b8 00 00 00 00 00
RSP: 0018:ffff8881d9eff258 EFLAGS: 00010282
RAX: 0000000000000000 RBX: 0000000000000003 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff8127ef3d RDI: ffffed103b3dfe3d
RBP: ffff8881d3c9cf00 R08: ffff8881d9e36000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000001
R13: ffff8881d3e52510 R14: ffff8881d08066a0 R15: ffff8881d41fba00
  iguanair_probe+0x8fe/0x18d0 drivers/media/rc/iguanair.c:461
  usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361
  really_probe+0x281/0x660 drivers/base/dd.c:509
  driver_probe_device+0x104/0x210 drivers/base/dd.c:670
  __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:777
  bus_for_each_drv+0x15c/0x1e0 drivers/base/bus.c:454
  __device_attach+0x217/0x360 drivers/base/dd.c:843
  bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
  device_add+0xae6/0x16f0 drivers/base/core.c:2111
  usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023
  generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210
  usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266
  really_probe+0x281/0x660 drivers/base/dd.c:509
  driver_probe_device+0x104/0x210 drivers/base/dd.c:670
  __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:777
  bus_for_each_drv+0x15c/0x1e0 drivers/base/bus.c:454
  __device_attach+0x217/0x360 drivers/base/dd.c:843
  bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514
  device_add+0xae6/0x16f0 drivers/base/core.c:2111
  usb_new_device.cold+0x6a4/0xe61 drivers/usb/core/hub.c:2536
  hub_port_connect drivers/usb/core/hub.c:5098 [inline]
  hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
  port_event drivers/usb/core/hub.c:5359 [inline]
  hub_event+0x1abd/0x3550 drivers/usb/core/hub.c:5441
  process_one_work+0x905/0x1570 kernel/workqueue.c:2269
  worker_thread+0x96/0xe20 kernel/workqueue.c:2415
  kthread+0x30b/0x410 kernel/kthread.c:255
  ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352
Kernel Offset: disabled
Rebooting in 86400 seconds..


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: WARNING in iguanair_probe/usb_submit_urb
  2019-07-26 12:28 WARNING in iguanair_probe/usb_submit_urb syzbot
@ 2019-07-29 11:25 ` Oliver Neukum
  2019-07-29 11:26   ` syzbot
  0 siblings, 1 reply; 3+ messages in thread
From: Oliver Neukum @ 2019-07-29 11:25 UTC (permalink / raw)
  To: syzbot, gustavo, andreyknvl, syzkaller-bugs, gregkh,
	linux-kernel, linux-usb

Am Freitag, den 26.07.2019, 05:28 -0700 schrieb syzbot:
> Hello,
> 
> syzbot found the following crash on:
> 
> HEAD commit:    6a3599ce usb-fuzzer: main usb gadget fuzzer driver
> git tree:       https://github.com/google/kasan.git usb-fuzzer
> console output: https://syzkaller.appspot.com/x/log.txt?x=164ab1f0600000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=700ca426ab83faae
> dashboard link: https://syzkaller.appspot.com/bug?extid=01a77b82edaa374068e1
> compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=143d7978600000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=134623f4600000
> 
> IMPORTANT: if you fix the bug, please add the following tag to the commit:
> Reported-by: syzbot+01a77b82edaa374068e1@syzkaller.appspotmail.com

#syz test: https://github.com/google/kasan.git usb-fuzzer-usb-testing-2019.07.11]

From 0b0a7f7e980973e0c0d17f1dfe2bd7742492bfcc Mon Sep 17 00:00:00 2001
From: Oliver Neukum <oneukum@suse.com>
Date: Mon, 29 Jul 2019 11:49:00 +0200
Subject: [PATCH] iguanair: add sanity checks

The driver needs to check the endpoint types, too, as opposed
to the number of endpoints. This also requires moving the check earlier.

Reported-by: syzbot+01a77b82edaa374068e1@syzkaller.appspotmail.com
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
 drivers/media/rc/iguanair.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c
index ea05e125016a..663083a6b399 100644
--- a/drivers/media/rc/iguanair.c
+++ b/drivers/media/rc/iguanair.c
@@ -413,6 +413,10 @@ static int iguanair_probe(struct usb_interface *intf,
 	int ret, pipein, pipeout;
 	struct usb_host_interface *idesc;
 
+	idesc = intf->altsetting;
+	if (idesc->desc.bNumEndpoints < 2)
+		return -ENODEV;
+
 	ir = kzalloc(sizeof(*ir), GFP_KERNEL);
 	rc = rc_allocate_device(RC_DRIVER_IR_RAW);
 	if (!ir || !rc) {
@@ -427,18 +431,13 @@ static int iguanair_probe(struct usb_interface *intf,
 	ir->urb_in = usb_alloc_urb(0, GFP_KERNEL);
 	ir->urb_out = usb_alloc_urb(0, GFP_KERNEL);
 
-	if (!ir->buf_in || !ir->packet || !ir->urb_in || !ir->urb_out) {
+	if (!ir->buf_in || !ir->packet || !ir->urb_in || !ir->urb_out ||
+			!usb_endpoint_is_int_in(&idesc->endpoint[0].desc) ||
+			!usb_endpoint_is_int_out(&idesc->endpoint[1].desc)) {
 		ret = -ENOMEM;
 		goto out;
 	}
 
-	idesc = intf->altsetting;
-
-	if (idesc->desc.bNumEndpoints < 2) {
-		ret = -ENODEV;
-		goto out;
-	}
-
 	ir->rc = rc;
 	ir->dev = &intf->dev;
 	ir->udev = udev;
-- 
2.16.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: Re: WARNING in iguanair_probe/usb_submit_urb
  2019-07-29 11:25 ` Oliver Neukum
@ 2019-07-29 11:26   ` syzbot
  0 siblings, 0 replies; 3+ messages in thread
From: syzbot @ 2019-07-29 11:26 UTC (permalink / raw)
  To: Oliver Neukum
  Cc: andreyknvl, gregkh, gustavo, linux-kernel, linux-usb, oneukum,
	syzkaller-bugs

> Am Freitag, den 26.07.2019, 05:28 -0700 schrieb syzbot:
>> Hello,

>> syzbot found the following crash on:

>> HEAD commit:    6a3599ce usb-fuzzer: main usb gadget fuzzer driver
>> git tree:       https://github.com/google/kasan.git usb-fuzzer
>> console output: https://syzkaller.appspot.com/x/log.txt?x=164ab1f0600000
>> kernel config:   
>> https://syzkaller.appspot.com/x/.config?x=700ca426ab83faae
>> dashboard link:  
>> https://syzkaller.appspot.com/bug?extid=01a77b82edaa374068e1
>> compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
>> syz repro:       
>> https://syzkaller.appspot.com/x/repro.syz?x=143d7978600000
>> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=134623f4600000

>> IMPORTANT: if you fix the bug, please add the following tag to the  
>> commit:
>> Reported-by: syzbot+01a77b82edaa374068e1@syzkaller.appspotmail.com

> #syz test: https://github.com/google/kasan.git  
> usb-fuzzer-usb-testing-2019.07.11]

"usb-fuzzer-usb-testing-2019.07.11]" does not look like a valid git branch  
or commit.


>  From 0b0a7f7e980973e0c0d17f1dfe2bd7742492bfcc Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oneukum@suse.com>
> Date: Mon, 29 Jul 2019 11:49:00 +0200
> Subject: [PATCH] iguanair: add sanity checks

> The driver needs to check the endpoint types, too, as opposed
> to the number of endpoints. This also requires moving the check earlier.

> Reported-by: syzbot+01a77b82edaa374068e1@syzkaller.appspotmail.com
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
>   drivers/media/rc/iguanair.c | 15 +++++++--------
>   1 file changed, 7 insertions(+), 8 deletions(-)

> diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c
> index ea05e125016a..663083a6b399 100644
> --- a/drivers/media/rc/iguanair.c
> +++ b/drivers/media/rc/iguanair.c
> @@ -413,6 +413,10 @@ static int iguanair_probe(struct usb_interface *intf,
>   	int ret, pipein, pipeout;
>   	struct usb_host_interface *idesc;

> +	idesc = intf->altsetting;
> +	if (idesc->desc.bNumEndpoints < 2)
> +		return -ENODEV;
> +
>   	ir = kzalloc(sizeof(*ir), GFP_KERNEL);
>   	rc = rc_allocate_device(RC_DRIVER_IR_RAW);
>   	if (!ir || !rc) {
> @@ -427,18 +431,13 @@ static int iguanair_probe(struct usb_interface  
> *intf,
>   	ir->urb_in = usb_alloc_urb(0, GFP_KERNEL);
>   	ir->urb_out = usb_alloc_urb(0, GFP_KERNEL);

> -	if (!ir->buf_in || !ir->packet || !ir->urb_in || !ir->urb_out) {
> +	if (!ir->buf_in || !ir->packet || !ir->urb_in || !ir->urb_out ||
> +			!usb_endpoint_is_int_in(&idesc->endpoint[0].desc) ||
> +			!usb_endpoint_is_int_out(&idesc->endpoint[1].desc)) {
>   		ret = -ENOMEM;
>   		goto out;
>   	}

> -	idesc = intf->altsetting;
> -
> -	if (idesc->desc.bNumEndpoints < 2) {
> -		ret = -ENODEV;
> -		goto out;
> -	}
> -
>   	ir->rc = rc;
>   	ir->dev = &intf->dev;
>   	ir->udev = udev;
> --
> 2.16.4


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-29 11:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-26 12:28 WARNING in iguanair_probe/usb_submit_urb syzbot
2019-07-29 11:25 ` Oliver Neukum
2019-07-29 11:26   ` syzbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).