From: Randy Dunlap <rdunlap@infradead.org>
To: "Wells Lu 呂芳騰" <wells.lu@sunplus.com>,
"Wells Lu" <wellslutw@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>
Subject: Re: [PATCH 2/2] net: ethernet: Add driver for Sunplus SP7021
Date: Wed, 3 Nov 2021 13:26:12 -0700 [thread overview]
Message-ID: <07456b90-a83c-b1b9-20d4-b70a746148a5@infradead.org> (raw)
In-Reply-To: <159ab76ac7114da983332aadc6056c08@sphcmbx02.sunplus.com.tw>
On 11/3/21 11:08 AM, Wells Lu 呂芳騰 wrote:
>>
>> Hi--
>>
>> On 11/3/21 4:02 AM, Wells Lu wrote:
>>> diff --git a/drivers/net/ethernet/sunplus/Kconfig
>>> b/drivers/net/ethernet/sunplus/Kconfig
>>> new file mode 100644
>>> index 0000000..a9e3a4c
>>> --- /dev/null
>>> +++ b/drivers/net/ethernet/sunplus/Kconfig
>>> @@ -0,0 +1,20 @@
>>> +# SPDX-License-Identifier: GPL-2.0
>>> +#
>>> +# Sunplus Ethernet device configuration #
>>> +
>>> +config NET_VENDOR_SUNPLUS
>>> + tristate "Sunplus Dual 10M/100M Ethernet (with L2 switch) devices"
>>> + depends on ETHERNET && SOC_SP7021
>>> + select PHYLIB
>>> + select PINCTRL_SPPCTL
>>> + select COMMON_CLK_SP7021
>>> + select RESET_SUNPLUS
>>> + select NVMEM_SUNPLUS_OCOTP
>>> + help
>>> + If you have Sunplus dual 10M/100M Ethernet (with L2 switch)
>>> + devices, say Y.
>>> + The network device supports dual 10M/100M Ethernet interfaces,
>>> + or one 10/100M Ethernet interface with two LAN ports.
>>> + To compile this driver as a module, choose M here. The module
>>> + will be called sp_l2sw.
>>
>> Please use NET_VENDOR_SUNPLUS in the same way that other
>> NET_VENDOR_wyxz kconfig symbols are used. It should just enable or
>> disable any specific device drivers under it.
>>
>>
>> --
>> ~Randy
>
> I looked up Kconfig file of other vendors, but not sure what I should do.
> Do I need to modify Kconfig file in the form as shown below?
Hi,
Yes, this is the correct general idea, but also consider
Andrew's comments.
Thanks.
> # SPDX-License-Identifier: GPL-2.0
> #
> # Sunplus device configuration
> #
>
> config NET_VENDOR_SUNPLUS
> bool "Sunplus devices"
> default y
> depends on ARCH_SUNPLUS
> ---help---
> If you have a network (Ethernet) card belonging to this
> class, say Y here.
>
> Note that the answer to this question doesn't directly
> affect the kernel: saying N will just cause the configurator
> to skip all the questions about Sunplus cards. If you say Y,
> you will be asked for your specific card in the following
> questions.
>
> if NET_VENDOR_SUNPLUS
>
> config SP7021_EMAC
> tristate "Sunplus Dual 10M/100M Ethernet (with L2 switch) devices"
> depends on ETHERNET && SOC_SP7021
> select PHYLIB
> select PINCTRL_SPPCTL
> select COMMON_CLK_SP7021
> select RESET_SUNPLUS
> select NVMEM_SUNPLUS_OCOTP
> help
> If you have Sunplus dual 10M/100M Ethernet (with L2 switch)
> devices, say Y.
> The network device supports dual 10M/100M Ethernet interfaces,
> or one 10/100M Ethernet interface with two LAN ports.
> To compile this driver as a module, choose M here. The module
> will be called sp_l2sw.
>
> endif # NET_VENDOR_SUNPLUS
>
> Best regards,
> Wells
>
--
~Randy
next prev parent reply other threads:[~2021-11-03 20:26 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 11:02 [PATCH 0/2] This is a patch series of ethernet driver for Sunplus SP7021 SoC Wells Lu
2021-11-03 11:02 ` [PATCH 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021 Wells Lu
2021-11-03 11:02 ` [PATCH 2/2] net: ethernet: Add driver " Wells Lu
2021-11-03 12:05 ` Denis Kirjanov
2021-11-03 14:08 ` Wells Lu 呂芳騰
2021-11-03 12:10 ` Philipp Zabel
2021-11-03 15:11 ` Wells Lu 呂芳騰
2021-11-03 15:52 ` Randy Dunlap
2021-11-03 18:08 ` Wells Lu 呂芳騰
2021-11-03 19:30 ` Andrew Lunn
2021-11-04 5:31 ` Wells Lu 呂芳騰
2021-11-04 12:59 ` Andrew Lunn
2021-11-04 14:55 ` Randy Dunlap
2021-11-04 17:51 ` Wells Lu 呂芳騰
2021-11-04 17:46 ` Wells Lu 呂芳騰
2021-11-04 18:21 ` Andrew Lunn
2021-11-04 19:03 ` Wells Lu 呂芳騰
2021-11-03 20:26 ` Randy Dunlap [this message]
2021-11-03 16:51 ` Andrew Lunn
2021-11-05 11:25 ` Wells Lu 呂芳騰
2021-11-05 13:37 ` Andrew Lunn
2021-11-08 9:37 ` Wells Lu 呂芳騰
2021-11-08 13:15 ` Andrew Lunn
2021-11-08 14:26 ` Wells Lu 呂芳騰
2021-11-08 14:52 ` Andrew Lunn
2021-11-08 16:47 ` Wells Lu 呂芳騰
2021-11-08 17:32 ` Andrew Lunn
2021-11-09 14:39 ` Wells Lu 呂芳騰
2021-11-09 15:32 ` Andrew Lunn
2021-11-09 17:05 ` Wells Lu 呂芳騰
2021-11-14 19:19 ` Pavel Skripkin
2021-11-17 9:28 ` Wells Lu 呂芳騰
2021-11-03 11:27 ` [PATCH 0/2] This is a patch series of ethernet driver for Sunplus SP7021 SoC Denis Kirjanov
2021-11-11 9:04 ` [PATCH v2 0/2] This is a patch series for pinctrl " Wells Lu
2021-11-11 9:04 ` [PATCH v2 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021 Wells Lu
2021-11-11 14:57 ` Rob Herring
2021-11-12 2:57 ` Wells Lu 呂芳騰
2021-11-11 18:23 ` Andrew Lunn
2021-11-12 2:50 ` Wells Lu 呂芳騰
2021-11-11 9:04 ` [PATCH v2 2/2] net: ethernet: Add driver " Wells Lu
2021-11-11 11:31 ` Denis Kirjanov
2021-11-13 14:22 ` Wells Lu 呂芳騰
2021-11-13 15:34 ` Andrew Lunn
2021-11-18 8:15 ` Wells Lu 呂芳騰
2021-11-12 17:42 ` kernel test robot
2021-11-12 23:16 ` Florian Fainelli
2021-11-12 23:24 ` Andrew Lunn
2021-11-15 14:38 ` Wells Lu 呂芳騰
2021-11-14 18:59 ` Wells Lu 呂芳騰
2021-11-12 23:58 ` Andrew Lunn
2021-11-16 17:09 ` Wells Lu 呂芳騰
2021-11-16 22:15 ` Andrew Lunn
2021-11-18 8:22 ` Wells Lu 呂芳騰
2021-11-25 11:28 ` Wells Lu 呂芳騰
2021-11-25 15:20 ` Andrew Lunn
2021-11-26 3:56 ` Wells Lu 呂芳騰
2021-11-26 14:38 ` Andrew Lunn
2021-11-26 16:12 ` Wells Lu 呂芳騰
2021-11-26 18:07 ` Andrew Lunn
2021-11-26 19:13 ` Wells Lu 呂芳騰
2021-11-26 19:32 ` Andrew Lunn
2021-11-29 11:16 ` Wells Lu 呂芳騰
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07456b90-a83c-b1b9-20d4-b70a746148a5@infradead.org \
--to=rdunlap@infradead.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=wells.lu@sunplus.com \
--cc=wellslutw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).