From: Philipp Zabel <p.zabel@pengutronix.de>
To: Wells Lu <wellslutw@gmail.com>,
davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Wells Lu <wells.lu@sunplus.com>
Subject: Re: [PATCH 2/2] net: ethernet: Add driver for Sunplus SP7021
Date: Wed, 03 Nov 2021 13:10:06 +0100 [thread overview]
Message-ID: <430b152167a1fdfb5ca66f1db702759f36d0ed56.camel@pengutronix.de> (raw)
In-Reply-To: <650ec751dd782071dd56af5e36c0d509b0c66d7f.1635936610.git.wells.lu@sunplus.com>
On Wed, 2021-11-03 at 19:02 +0800, Wells Lu wrote:
[...]
> diff --git a/drivers/net/ethernet/sunplus/l2sw_driver.c b/drivers/net/ethernet/sunplus/l2sw_driver.c
> new file mode 100644
> index 0000000..3dfd0dd
> --- /dev/null
> +++ b/drivers/net/ethernet/sunplus/l2sw_driver.c
> @@ -0,0 +1,779 @@
[...]
> +static int l2sw_probe(struct platform_device *pdev)
> +{
> + struct l2sw_common *comm;
> + struct resource *r_mem;
> + struct net_device *net_dev, *net_dev2;
> + struct l2sw_mac *mac, *mac2;
> + u32 mode;
> + int ret = 0;
> + int rc;
> +
> + if (platform_get_drvdata(pdev))
> + return -ENODEV;
> +
> + // Allocate memory for l2sw 'common' area.
> + comm = kmalloc(sizeof(*comm), GFP_KERNEL);
I'd use devm_kzalloc() here for initialization and to simplify the
cleanup path.
> + if (!comm)
> + return -ENOMEM;
> + pr_debug(" comm = %p\n", comm);
What is this useful for?
> + memset(comm, '\0', sizeof(struct l2sw_common));
Not needed with kzalloc, See above.
[...]
> + // Get memory resoruce 0 from dts.
> + r_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (r_mem) {
> + pr_debug(" res->name = \"%s\", r_mem->start = %pa\n", r_mem->name, &r_mem->start);
> + if (l2sw_reg_base_set(devm_ioremap(&pdev->dev, r_mem->start,
> + (r_mem->end - r_mem->start + 1))) != 0) {
> + pr_err(" ioremap failed!\n");
> + ret = -ENOMEM;
> + goto out_free_comm;
> + }
> + } else {
> + pr_err(" No MEM resource 0 found!\n");
> + ret = -ENXIO;
> + goto out_free_comm;
> + }
> +
> + // Get memory resoruce 1 from dts.
> + r_mem = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> + if (r_mem) {
> + pr_debug(" res->name = \"%s\", r_mem->start = %pa\n", r_mem->name, &r_mem->start);
> + if (moon5_reg_base_set(devm_ioremap(&pdev->dev, r_mem->start,
> + (r_mem->end - r_mem->start + 1))) != 0) {
> + pr_err(" ioremap failed!\n");
> + ret = -ENOMEM;
> + goto out_free_comm;
> + }
> + } else {
> + pr_err(" No MEM resource 1 found!\n");
> + ret = -ENXIO;
> + goto out_free_comm;
> + }
Using devm_ioremap_resource() would simplify both a lot.
[...]
> + comm->rstc = devm_reset_control_get(&pdev->dev, NULL);
Please use devm_reset_control_get_exclusive().
> + if (IS_ERR(comm->rstc)) {
> + dev_err(&pdev->dev, "Failed to retrieve reset controller!\n");
> + ret = PTR_ERR(comm->rstc);
> + goto out_free_comm;
> + }
> +
> + // Enable clock.
> + clk_prepare_enable(comm->clk);
> + udelay(1);
> +
> + ret = reset_control_assert(comm->rstc);
No need to assign to ret if you ignore it anyway.
> + udelay(1);
> + ret = reset_control_deassert(comm->rstc);
> + if (ret) {
> + dev_err(&pdev->dev, "Failed to deassert reset line (err = %d)!\n", ret);
> + ret = -ENODEV;
> + goto out_free_comm;
> + }
> + udelay(1);
regards
Philipp
next prev parent reply other threads:[~2021-11-03 12:10 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 11:02 [PATCH 0/2] This is a patch series of ethernet driver for Sunplus SP7021 SoC Wells Lu
2021-11-03 11:02 ` [PATCH 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021 Wells Lu
2021-11-03 11:02 ` [PATCH 2/2] net: ethernet: Add driver " Wells Lu
2021-11-03 12:05 ` Denis Kirjanov
2021-11-03 14:08 ` Wells Lu 呂芳騰
2021-11-03 12:10 ` Philipp Zabel [this message]
2021-11-03 15:11 ` Wells Lu 呂芳騰
2021-11-03 15:52 ` Randy Dunlap
2021-11-03 18:08 ` Wells Lu 呂芳騰
2021-11-03 19:30 ` Andrew Lunn
2021-11-04 5:31 ` Wells Lu 呂芳騰
2021-11-04 12:59 ` Andrew Lunn
2021-11-04 14:55 ` Randy Dunlap
2021-11-04 17:51 ` Wells Lu 呂芳騰
2021-11-04 17:46 ` Wells Lu 呂芳騰
2021-11-04 18:21 ` Andrew Lunn
2021-11-04 19:03 ` Wells Lu 呂芳騰
2021-11-03 20:26 ` Randy Dunlap
2021-11-03 16:51 ` Andrew Lunn
2021-11-05 11:25 ` Wells Lu 呂芳騰
2021-11-05 13:37 ` Andrew Lunn
2021-11-08 9:37 ` Wells Lu 呂芳騰
2021-11-08 13:15 ` Andrew Lunn
2021-11-08 14:26 ` Wells Lu 呂芳騰
2021-11-08 14:52 ` Andrew Lunn
2021-11-08 16:47 ` Wells Lu 呂芳騰
2021-11-08 17:32 ` Andrew Lunn
2021-11-09 14:39 ` Wells Lu 呂芳騰
2021-11-09 15:32 ` Andrew Lunn
2021-11-09 17:05 ` Wells Lu 呂芳騰
2021-11-14 19:19 ` Pavel Skripkin
2021-11-17 9:28 ` Wells Lu 呂芳騰
2021-11-03 11:27 ` [PATCH 0/2] This is a patch series of ethernet driver for Sunplus SP7021 SoC Denis Kirjanov
2021-11-11 9:04 ` [PATCH v2 0/2] This is a patch series for pinctrl " Wells Lu
2021-11-11 9:04 ` [PATCH v2 1/2] devicetree: bindings: net: Add bindings doc for Sunplus SP7021 Wells Lu
2021-11-11 14:57 ` Rob Herring
2021-11-12 2:57 ` Wells Lu 呂芳騰
2021-11-11 18:23 ` Andrew Lunn
2021-11-12 2:50 ` Wells Lu 呂芳騰
2021-11-11 9:04 ` [PATCH v2 2/2] net: ethernet: Add driver " Wells Lu
2021-11-11 11:31 ` Denis Kirjanov
2021-11-13 14:22 ` Wells Lu 呂芳騰
2021-11-13 15:34 ` Andrew Lunn
2021-11-18 8:15 ` Wells Lu 呂芳騰
2021-11-12 17:42 ` kernel test robot
2021-11-12 23:16 ` Florian Fainelli
2021-11-12 23:24 ` Andrew Lunn
2021-11-15 14:38 ` Wells Lu 呂芳騰
2021-11-14 18:59 ` Wells Lu 呂芳騰
2021-11-12 23:58 ` Andrew Lunn
2021-11-16 17:09 ` Wells Lu 呂芳騰
2021-11-16 22:15 ` Andrew Lunn
2021-11-18 8:22 ` Wells Lu 呂芳騰
2021-11-25 11:28 ` Wells Lu 呂芳騰
2021-11-25 15:20 ` Andrew Lunn
2021-11-26 3:56 ` Wells Lu 呂芳騰
2021-11-26 14:38 ` Andrew Lunn
2021-11-26 16:12 ` Wells Lu 呂芳騰
2021-11-26 18:07 ` Andrew Lunn
2021-11-26 19:13 ` Wells Lu 呂芳騰
2021-11-26 19:32 ` Andrew Lunn
2021-11-29 11:16 ` Wells Lu 呂芳騰
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=430b152167a1fdfb5ca66f1db702759f36d0ed56.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wells.lu@sunplus.com \
--cc=wellslutw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).