From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Faiz Abbas <faiz_abbas@ti.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-can@vger.kernel.org
Cc: wg@grandegger.com, robh+dt@kernel.org, mark.rutland@arm.com,
kishon@ti.com
Subject: Re: [PATCH 1/6] phy: Add max_bitrate attribute & phy_get_max_bitrate()
Date: Mon, 5 Nov 2018 10:37:56 +0100 [thread overview]
Message-ID: <0c0885c4-f5ae-a29c-7176-f67fe546cfd8@pengutronix.de> (raw)
In-Reply-To: <d75c9e3c-e12b-e0b8-832c-ad117dcbe990@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 1259 bytes --]
On 11/05/2018 07:27 AM, Faiz Abbas wrote:
> I remove the transceiver child node binding documentation in patch 5/6.
>
> The existing implementation is pretty limiting as it just has a child
> node with no associated device. What if a transceiver requires its own
> configurations before it can start sending/receiving messages (for
> example, my usecase requires it to pull the standby line low)?
>
> I think that can be solved by implementing the transceiver as a phy and
> exposing a generic get_max_bitrate API. That way, the transceiver device
> can do all its startup configuration in the phy probe function.
>
> In any case, do suggest if you have a better idea on how to implement
> pull gpio low requirement.
As long as we don't have any proper transceiver/phy driver, that does
more than swtich on/off a GPIO, please add a "xceiver" regulator to your
driver. Look for:
> devm_regulator_get(&pdev->dev, "xceiver");
in the flexcan driver.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-11-05 9:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 19:26 [PATCH 0/6] Add Support for MCAN transceivers in AM65x-evm Faiz Abbas
2018-11-02 19:26 ` [PATCH 1/6] phy: Add max_bitrate attribute & phy_get_max_bitrate() Faiz Abbas
2018-11-03 9:36 ` Marc Kleine-Budde
2018-11-05 6:27 ` Faiz Abbas
2018-11-05 9:37 ` Marc Kleine-Budde [this message]
2018-11-05 11:14 ` Faiz Abbas
2018-11-05 11:47 ` Marc Kleine-Budde
2018-11-05 13:22 ` Faiz Abbas
2018-11-02 19:26 ` [PATCH 2/6] dt-bindings: phy: phy-of-simple: Document new binding Faiz Abbas
2018-11-06 20:55 ` Rob Herring
2018-11-02 19:26 ` [PATCH 3/6] phy: phy-of-simple: Add support for simple generic phy driver Faiz Abbas
2018-11-03 5:04 ` kbuild test robot
2018-11-02 19:26 ` [PATCH 4/6] dt-bindings: can: m_can: Document transceiver implementation as a phy Faiz Abbas
2018-11-02 19:26 ` [PATCH 5/6] dt-bindings: can: can-transceiver: Remove legacy binding documentation Faiz Abbas
2018-11-03 20:12 ` Sergei Shtylyov
2018-11-02 19:26 ` [PATCH 6/6] can: m_can: Add support for transceiver as phy Faiz Abbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c0885c4-f5ae-a29c-7176-f67fe546cfd8@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=faiz_abbas@ti.com \
--cc=kishon@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).