From: kbuild test robot <lkp@intel.com>
To: Faiz Abbas <faiz_abbas@ti.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-can@vger.kernel.org, wg@grandegger.com, mkl@pengutronix.de,
robh+dt@kernel.org, mark.rutland@arm.com, kishon@ti.com,
faiz_abbas@ti.com
Subject: Re: [PATCH 3/6] phy: phy-of-simple: Add support for simple generic phy driver
Date: Sat, 3 Nov 2018 13:04:29 +0800 [thread overview]
Message-ID: <201811031325.svZPVFjc%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181102192616.28291-4-faiz_abbas@ti.com>
[-- Attachment #1: Type: text/plain, Size: 4620 bytes --]
Hi Faiz,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on v4.19 next-20181102]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Faiz-Abbas/Add-Support-for-MCAN-transceivers-in-AM65x-evm/20181103-103548
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=sh
All error/warnings (new ones prefixed by >>):
In file included from drivers//phy/phy-of-simple.c:10:0:
>> drivers//phy/phy-of-simple.c:76:25: error: 'phy_simple_phy_dt_ids' undeclared here (not in a function); did you mean 'phy_simple_dt_ids'?
MODULE_DEVICE_TABLE(of, phy_simple_phy_dt_ids);
^
include/linux/module.h:213:15: note: in definition of macro 'MODULE_DEVICE_TABLE'
extern typeof(name) __mod_##type##__##name##_device_table \
^~~~
>> include/linux/module.h:213:21: error: '__mod_of__phy_simple_phy_dt_ids_device_table' aliased to undefined symbol 'phy_simple_phy_dt_ids'
extern typeof(name) __mod_##type##__##name##_device_table \
^
>> drivers//phy/phy-of-simple.c:76:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
MODULE_DEVICE_TABLE(of, phy_simple_phy_dt_ids);
^~~~~~~~~~~~~~~~~~~
--
In file included from drivers/phy/phy-of-simple.c:10:0:
drivers/phy/phy-of-simple.c:76:25: error: 'phy_simple_phy_dt_ids' undeclared here (not in a function); did you mean 'phy_simple_dt_ids'?
MODULE_DEVICE_TABLE(of, phy_simple_phy_dt_ids);
^
include/linux/module.h:213:15: note: in definition of macro 'MODULE_DEVICE_TABLE'
extern typeof(name) __mod_##type##__##name##_device_table \
^~~~
>> include/linux/module.h:213:21: error: '__mod_of__phy_simple_phy_dt_ids_device_table' aliased to undefined symbol 'phy_simple_phy_dt_ids'
extern typeof(name) __mod_##type##__##name##_device_table \
^
drivers/phy/phy-of-simple.c:76:1: note: in expansion of macro 'MODULE_DEVICE_TABLE'
MODULE_DEVICE_TABLE(of, phy_simple_phy_dt_ids);
^~~~~~~~~~~~~~~~~~~
vim +76 drivers//phy/phy-of-simple.c
> 10 #include <linux/module.h>
11 #include <linux/regulator/consumer.h>
12
13 static int phy_simple_power_on(struct phy *phy)
14 {
15 if (phy->pwr)
16 return regulator_enable(phy->pwr);
17
18 return 0;
19 }
20
21 static int phy_simple_power_off(struct phy *phy)
22 {
23 if (phy->pwr)
24 return regulator_disable(phy->pwr);
25
26 return 0;
27 }
28
29 static const struct phy_ops phy_simple_ops = {
30 .power_on = phy_simple_power_on,
31 .power_off = phy_simple_power_off,
32 .owner = THIS_MODULE,
33 };
34
35 int phy_simple_probe(struct platform_device *pdev)
36 {
37 struct phy_provider *phy_provider;
38 struct device *dev = &pdev->dev;
39 struct regulator *pwr = NULL;
40 struct phy *phy;
41 u32 bus_width = 0;
42 u32 max_bitrate = 0;
43 int ret;
44
45 phy = devm_phy_create(dev, dev->of_node,
46 &phy_simple_ops);
47
48 if (IS_ERR(phy)) {
49 dev_err(dev, "Failed to create phy\n");
50 return PTR_ERR(phy);
51 }
52
53 device_property_read_u32(dev, "bus-width", &bus_width);
54 phy->attrs.bus_width = bus_width;
55 device_property_read_u32(dev, "max-bitrate", &max_bitrate);
56 phy->attrs.max_bitrate = max_bitrate;
57
58 pwr = devm_regulator_get_optional(dev, "pwr");
59 if (IS_ERR(pwr)) {
60 ret = PTR_ERR(pwr);
61 dev_err(dev, "Couldn't get regulator. ret=%d\n", ret);
62 return ret;
63 }
64 phy->pwr = pwr;
65
66 phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
67
68 return PTR_ERR_OR_ZERO(phy_provider);
69 }
70
71 static const struct of_device_id phy_simple_dt_ids[] = {
72 { .compatible = "simple-phy"},
73 {}
74 };
75
> 76 MODULE_DEVICE_TABLE(of, phy_simple_phy_dt_ids);
77
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50346 bytes --]
next prev parent reply other threads:[~2018-11-03 5:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-02 19:26 [PATCH 0/6] Add Support for MCAN transceivers in AM65x-evm Faiz Abbas
2018-11-02 19:26 ` [PATCH 1/6] phy: Add max_bitrate attribute & phy_get_max_bitrate() Faiz Abbas
2018-11-03 9:36 ` Marc Kleine-Budde
2018-11-05 6:27 ` Faiz Abbas
2018-11-05 9:37 ` Marc Kleine-Budde
2018-11-05 11:14 ` Faiz Abbas
2018-11-05 11:47 ` Marc Kleine-Budde
2018-11-05 13:22 ` Faiz Abbas
2018-11-02 19:26 ` [PATCH 2/6] dt-bindings: phy: phy-of-simple: Document new binding Faiz Abbas
2018-11-06 20:55 ` Rob Herring
2018-11-02 19:26 ` [PATCH 3/6] phy: phy-of-simple: Add support for simple generic phy driver Faiz Abbas
2018-11-03 5:04 ` kbuild test robot [this message]
2018-11-02 19:26 ` [PATCH 4/6] dt-bindings: can: m_can: Document transceiver implementation as a phy Faiz Abbas
2018-11-02 19:26 ` [PATCH 5/6] dt-bindings: can: can-transceiver: Remove legacy binding documentation Faiz Abbas
2018-11-03 20:12 ` Sergei Shtylyov
2018-11-02 19:26 ` [PATCH 6/6] can: m_can: Add support for transceiver as phy Faiz Abbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201811031325.svZPVFjc%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=faiz_abbas@ti.com \
--cc=kbuild-all@01.org \
--cc=kishon@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).