From: Kieran Bingham <kbingham@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Douglas Anderson <dianders@chromium.org>,
Nikolay Borisov <n.borisov.lkml@gmail.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Jackie Liu <liuyun01@kylinos.cn>
Subject: Re: [PATCH 0/4] gdb script for kconfig and timer list
Date: Tue, 26 Mar 2019 08:39:43 +0000 [thread overview]
Message-ID: <0cb6bd11-b98e-2d76-f464-b06afab74e97@kernel.org> (raw)
In-Reply-To: <20190325184522.260535-1-swboyd@chromium.org>
Hi Stephen,
Thank you for these patches,
Could you check them through with PEP8 please?
While we are not entirely "pep8 clean", Your series adds the following
warnings:
linux/config.py:10:1: E302 expected 2 blank lines, found 1
linux/config.py:17:41: E128 continuation line under-indented for visual
indent
linux/config.py:30:9: E722 do not use bare 'except'
linux/config.py:35:41: E128 continuation line under-indented for visual
indent
linux/config.py:40:9: E722 do not use bare 'except'
linux/config.py:48:1: E305 expected 2 blank lines after class or
function definition, found 1
linux/rbtree.py:18:17: E128 continuation line under-indented for visual
indent
linux/rbtree.py:29:1: E302 expected 2 blank lines, found 1
linux/rbtree.py:34:17: E128 continuation line under-indented for visual
indent
linux/rbtree.py:45:1: E302 expected 2 blank lines, found 1
linux/rbtree.py:49:1: E302 expected 2 blank lines, found 1
linux/rbtree.py:52:1: E302 expected 2 blank lines, found 1
linux/rbtree.py:57:17: E128 continuation line under-indented for visual
indent
linux/rbtree.py:75:1: E302 expected 2 blank lines, found 1
linux/rbtree.py:80:17: E128 continuation line under-indented for visual
indent
linux/rbtree.py:115:1: E305 expected 2 blank lines after class or
function definition, found 1
linux/rbtree.py:117:1: E302 expected 2 blank lines, found 1
linux/rbtree.py:133:1: E305 expected 2 blank lines after class or
function definition, found 1
linux/rbtree.py:135:1: E302 expected 2 blank lines, found 1
linux/rbtree.py:151:1: E305 expected 2 blank lines after class or
function definition, found 1
linux/rbtree.py:153:1: E302 expected 2 blank lines, found 1
linux/rbtree.py:169:1: E305 expected 2 blank lines after class or
function definition, found 1
linux/timerlist.py:26:1: E302 expected 2 blank lines, found 1
linux/timerlist.py:27:80: E501 line too long (95 > 79 characters)
linux/timerlist.py:28:80: E501 line too long (85 > 79 characters)
linux/timerlist.py:37:80: E501 line too long (81 > 79 characters)
linux/timerlist.py:38:13: E128 continuation line under-indented for
visual indent
linux/timerlist.py:41:1: E302 expected 2 blank lines, found 1
linux/timerlist.py:50:1: E302 expected 2 blank lines, found 1
linux/timerlist.py:63:1: E302 expected 2 blank lines, found 1
linux/timerlist.py:81:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:82:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:83:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:84:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:85:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:103:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:104:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:105:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:106:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:107:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:108:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:109:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:110:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:111:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:112:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:113:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:114:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:115:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:116:12: E122 continuation line missing indentation or
outdented
linux/timerlist.py:122:1: E302 expected 2 blank lines, found 1
linux/timerlist.py:150:15: E124 closing bracket does not match visual
indentation
linux/timerlist.py:160:1: E302 expected 2 blank lines, found 1
linux/timerlist.py:183:65: E261 at least two spaces before inline comment
linux/timerlist.py:183:80: E501 line too long (88 > 79 characters)
linux/timerlist.py:186:77: E261 at least two spaces before inline comment
linux/timerlist.py:186:80: E501 line too long (100 > 79 characters)
linux/timerlist.py:190:80: E501 line too long (125 > 79 characters)
linux/timerlist.py:194:1: E305 expected 2 blank lines after class or
function definition, found 1
--
Regards
Kieran
On 25/03/2019 18:45, Stephen Boyd wrote:
> This is a handful of changes to the kernel's gdb scripts to do some more
> debugging with kgdb. The first patch allows the vmlinux to be reloaded
> from where it was specified on the command line so that this set of
> scripts can be used from anywhere. The second patch adds a script to
> dump the config.gz to a file on the host debugging machine. The third
> patch adds some rb tree utilities and the last patch uses those rb tree
> walking utilities to dump out the contents of /proc/timer_list from a
> system under debug.
>
> I'm guessing that Andrew will pick these patches up. I don't know who
> maintains these gdb scripts but it looks like Andrew has been doing the
> lifting recently.
>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Nikolay Borisov <n.borisov.lkml@gmail.com>
> Cc: Kieran Bingham <kbingham@kernel.org>
> Cc: Jan Kiszka <jan.kiszka@siemens.com>
> Cc: Jackie Liu <liuyun01@kylinos.cn>
>
> Stephen Boyd (4):
> scripts/gdb: Find vmlinux where it was before
> scripts/gdb: Add kernel config dumping command
> scripts/gdb: Add rb tree iterating utilities
> scripts/gdb: Add a timer list command
>
> scripts/gdb/linux/config.py | 48 ++++++++
> scripts/gdb/linux/constants.py.in | 8 ++
> scripts/gdb/linux/rbtree.py | 169 ++++++++++++++++++++++++++
> scripts/gdb/linux/symbols.py | 6 +-
> scripts/gdb/linux/timerlist.py | 194 ++++++++++++++++++++++++++++++
> scripts/gdb/vmlinux-gdb.py | 3 +
> 6 files changed, 427 insertions(+), 1 deletion(-)
> create mode 100644 scripts/gdb/linux/config.py
> create mode 100644 scripts/gdb/linux/rbtree.py
> create mode 100644 scripts/gdb/linux/timerlist.py
>
>
> base-commit: 9e98c678c2d6ae3a17cb2de55d17f69dddaa231b
>
--
--
Kieran
next prev parent reply other threads:[~2019-03-26 8:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 18:45 [PATCH 0/4] gdb script for kconfig and timer list Stephen Boyd
2019-03-25 18:45 ` [PATCH 1/4] scripts/gdb: Find vmlinux where it was before Stephen Boyd
2019-03-25 18:45 ` [PATCH 2/4] scripts/gdb: Add kernel config dumping command Stephen Boyd
2019-03-25 18:45 ` [PATCH 3/4] scripts/gdb: Add rb tree iterating utilities Stephen Boyd
2019-03-26 8:52 ` Kieran Bingham
2019-03-26 17:05 ` Stephen Boyd
2019-03-26 17:21 ` Jan Kiszka
2019-03-26 20:39 ` Stephen Boyd
2019-03-27 10:37 ` Kieran Bingham
2019-03-25 18:45 ` [PATCH 4/4] scripts/gdb: Add a timer list command Stephen Boyd
2019-03-26 8:39 ` Kieran Bingham [this message]
2019-03-26 20:35 ` [PATCH 0/4] gdb script for kconfig and timer list Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cb6bd11-b98e-2d76-f464-b06afab74e97@kernel.org \
--to=kbingham@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dianders@chromium.org \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
--cc=n.borisov.lkml@gmail.com \
--cc=swboyd@chromium.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).