From: Stephen Boyd <swboyd@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Kieran Bingham <kbingham@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Douglas Anderson <dianders@chromium.org>,
Nikolay Borisov <n.borisov.lkml@gmail.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Jackie Liu <liuyun01@kylinos.cn>
Subject: Re: [PATCH 3/4] scripts/gdb: Add rb tree iterating utilities
Date: Tue, 26 Mar 2019 10:05:36 -0700 [thread overview]
Message-ID: <155361993610.20095.762425616683725063@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <227f1a1f-d8dd-72f4-4eb9-43bba714d52a@kernel.org>
Quoting Kieran Bingham (2019-03-26 01:52:10)
> Hi Stephen,
>
> On 25/03/2019 18:45, Stephen Boyd wrote:
> > Implement gdb functions for rb_first(), rb_last(), rb_next(), and
> > rb_prev(). These can be useful to iterate through the kernel's red-black
> > trees.
>
> I definitely approve of getting data-structure helpers into scripts/gdb,
> as it will greatly assist debug options but my last attempt to do this
> was with the radix-tree which I had to give up on as the internals were
> changing rapidly and caused continuous breakage to the helpers.
Thanks for the background on radix-tree. I haven't looked at that yet,
but I suppose I'll want to have that too at some point.
>
> Do you foresee any similar issue here? Or is the corresponding RB code
> in the kernel fairly 'stable'?
>
>
> Please could we make sure whomever maintains the RBTree code is aware of
> the python implementation?
>
> That said, MAINTAINERS doesn't actually seem to list any ownership over
> the rb-tree code, and get_maintainers.pl [0] seems to be pointing at
> Andrew as the probable route in for that code so perhaps that's already
> in place :D
I don't think that the rb tree implementation is going to change. It
feels similar to the list API. I suppose this problem of keeping things
in sync is a more general problem than just data-structures changing.
The only solution I can offer is to have more testing and usage of these
scripts. Unless gdb can "simulate" or run arbitrary code for us then I
think we're stuck reimplementing kernel internal code in gdb scripts so
that we can get debug info out.
next prev parent reply other threads:[~2019-03-26 17:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 18:45 [PATCH 0/4] gdb script for kconfig and timer list Stephen Boyd
2019-03-25 18:45 ` [PATCH 1/4] scripts/gdb: Find vmlinux where it was before Stephen Boyd
2019-03-25 18:45 ` [PATCH 2/4] scripts/gdb: Add kernel config dumping command Stephen Boyd
2019-03-25 18:45 ` [PATCH 3/4] scripts/gdb: Add rb tree iterating utilities Stephen Boyd
2019-03-26 8:52 ` Kieran Bingham
2019-03-26 17:05 ` Stephen Boyd [this message]
2019-03-26 17:21 ` Jan Kiszka
2019-03-26 20:39 ` Stephen Boyd
2019-03-27 10:37 ` Kieran Bingham
2019-03-25 18:45 ` [PATCH 4/4] scripts/gdb: Add a timer list command Stephen Boyd
2019-03-26 8:39 ` [PATCH 0/4] gdb script for kconfig and timer list Kieran Bingham
2019-03-26 20:35 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155361993610.20095.762425616683725063@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=dianders@chromium.org \
--cc=jan.kiszka@siemens.com \
--cc=kbingham@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
--cc=n.borisov.lkml@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).