linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Krish Sadhukhan <krish.sadhukhan@oracle.com>,
	Eric Auger <eric.auger@redhat.com>,
	eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, vkuznets@redhat.com
Cc: thuth@redhat.com, drjones@redhat.com, wei.huang2@amd.com
Subject: Re: [PATCH v4 2/3] selftests: KVM: AMD Nested test infrastructure
Date: Wed, 12 Feb 2020 12:38:52 +0100	[thread overview]
Message-ID: <0df83591-880f-df40-d160-fc847dcdf301@redhat.com> (raw)
In-Reply-To: <92106709-10ff-44d3-1fe8-2c77c010913f@oracle.com>

On 06/02/20 23:57, Krish Sadhukhan wrote:
>>
>> +
>> +void nested_svm_check_supported(void)
>> +{
>> +    struct kvm_cpuid_entry2 *entry =
>> +        kvm_get_supported_cpuid_entry(0x80000001);
>> +
>> +    if (!(entry->ecx & CPUID_SVM)) {
>> +        fprintf(stderr, "nested SVM not enabled, skipping test\n");
> I think a better message would be:
> 
>     "nested SVM not supported on this CPU, skipping test\n"
> 
> Also, the function should ideally return a boolean and let the callers
> print whatever they want.

It would be "not supported by KVM", which is equivalent to "not enabled"
for all purposes.

Thanks,

Paolo


  parent reply	other threads:[~2020-02-12 11:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06 10:47 [PATCH v4 0/3] selftests: KVM: AMD Nested SVM test infrastructure Eric Auger
2020-02-06 10:47 ` [PATCH v4 1/3] selftests: KVM: Replace get_gdt/idt_base() by get_gdt/idt() Eric Auger
2020-02-06 17:13   ` Wei Huang
2020-02-06 19:17   ` Krish Sadhukhan
2020-02-06 10:47 ` [PATCH v4 2/3] selftests: KVM: AMD Nested test infrastructure Eric Auger
2020-02-06 12:20   ` Vitaly Kuznetsov
2020-02-06 12:27     ` Auger Eric
2020-02-06 22:57   ` Krish Sadhukhan
2020-02-07  9:16     ` Vitaly Kuznetsov
2020-02-07 14:16     ` Auger Eric
2020-02-12 11:38     ` Paolo Bonzini [this message]
2020-02-06 10:47 ` [PATCH v4 3/3] selftests: KVM: SVM: Add vmcall test Eric Auger
2020-02-06 17:39   ` Wei Huang
2020-02-06 19:08     ` Krish Sadhukhan
2020-02-07 10:05       ` Auger Eric
2020-02-07 10:15     ` Auger Eric
2020-02-12 11:43       ` Paolo Bonzini
2020-02-06 22:46   ` Krish Sadhukhan
2020-02-07 14:06     ` Auger Eric
2020-02-12 11:45     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0df83591-880f-df40-d160-fc847dcdf301@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=drjones@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=eric.auger@redhat.com \
    --cc=krish.sadhukhan@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thuth@redhat.com \
    --cc=vkuznets@redhat.com \
    --cc=wei.huang2@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).