From: Paolo Bonzini <pbonzini@redhat.com>
To: Auger Eric <eric.auger@redhat.com>, Wei Huang <wei.huang2@amd.com>
Cc: eric.auger.pro@gmail.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, vkuznets@redhat.com, thuth@redhat.com,
drjones@redhat.com
Subject: Re: [PATCH v4 3/3] selftests: KVM: SVM: Add vmcall test
Date: Wed, 12 Feb 2020 12:43:14 +0100 [thread overview]
Message-ID: <7f9c89b5-c1df-011f-917d-89d2e880049d@redhat.com> (raw)
In-Reply-To: <130c32bc-7533-1b4e-b913-d9596ed4e94d@redhat.com>
On 07/02/20 11:15, Auger Eric wrote:
>> Probably rename the file to svm_nested_vmcall_test.c. This matches with
>> the naming convention of VMX's nested tests. Otherwise people might not know
>> it is a nested one.
> From what I understand, all the vmx_* (including vmx_tsc_adjust_test for
> instance) are related to nested. So I'd rather leave svm_ prefix for
> nested SVM.
That is not strictly necessary, as there could be tests for Intel or
AMD-specific bugs or features. But in practice you are right, "vmx_"
right now means it's testing nested. We can rename all of them to
"nvmx_*" and "nsvm_*", but in the meanwhile your patch does not
introduce any inconsistency.
Queued, thanks!
Paolo
next prev parent reply other threads:[~2020-02-12 11:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 10:47 [PATCH v4 0/3] selftests: KVM: AMD Nested SVM test infrastructure Eric Auger
2020-02-06 10:47 ` [PATCH v4 1/3] selftests: KVM: Replace get_gdt/idt_base() by get_gdt/idt() Eric Auger
2020-02-06 17:13 ` Wei Huang
2020-02-06 19:17 ` Krish Sadhukhan
2020-02-06 10:47 ` [PATCH v4 2/3] selftests: KVM: AMD Nested test infrastructure Eric Auger
2020-02-06 12:20 ` Vitaly Kuznetsov
2020-02-06 12:27 ` Auger Eric
2020-02-06 22:57 ` Krish Sadhukhan
2020-02-07 9:16 ` Vitaly Kuznetsov
2020-02-07 14:16 ` Auger Eric
2020-02-12 11:38 ` Paolo Bonzini
2020-02-06 10:47 ` [PATCH v4 3/3] selftests: KVM: SVM: Add vmcall test Eric Auger
2020-02-06 17:39 ` Wei Huang
2020-02-06 19:08 ` Krish Sadhukhan
2020-02-07 10:05 ` Auger Eric
2020-02-07 10:15 ` Auger Eric
2020-02-12 11:43 ` Paolo Bonzini [this message]
2020-02-06 22:46 ` Krish Sadhukhan
2020-02-07 14:06 ` Auger Eric
2020-02-12 11:45 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f9c89b5-c1df-011f-917d-89d2e880049d@redhat.com \
--to=pbonzini@redhat.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thuth@redhat.com \
--cc=vkuznets@redhat.com \
--cc=wei.huang2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).