* [PATCH] ASoC: tas2781: mark dvc_tlv with __maybe_unused
@ 2024-03-28 22:47 Gergo Koteles
2024-03-29 7:38 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Gergo Koteles @ 2024-03-28 22:47 UTC (permalink / raw)
To: Shenghao Ding, Kevin Lu, Baojun Xu, Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, linux-sound, linux-kernel, Gergo Koteles, kernel test robot
Since we put dvc_tlv static variable to a header file it's copied to
each module that includes the header. But not all of them are actually
used it.
Fix this W=1 build warning:
include/sound/tas2781-tlv.h:18:35: warning: 'dvc_tlv' defined but not
used [-Wunused-const-variable=]
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202403290354.v0StnRpc-lkp@intel.com/
Fixes: ae065d0ce9e3 ("ALSA: hda/tas2781: remove digital gain kcontrol")
Signed-off-by: Gergo Koteles <soyer@irl.hu>
---
include/sound/tas2781-tlv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/sound/tas2781-tlv.h b/include/sound/tas2781-tlv.h
index 4038dd421150..1dc59005d241 100644
--- a/include/sound/tas2781-tlv.h
+++ b/include/sound/tas2781-tlv.h
@@ -15,7 +15,7 @@
#ifndef __TAS2781_TLV_H__
#define __TAS2781_TLV_H__
-static const DECLARE_TLV_DB_SCALE(dvc_tlv, -10000, 100, 0);
+static const __maybe_unused DECLARE_TLV_DB_SCALE(dvc_tlv, -10000, 100, 0);
static const DECLARE_TLV_DB_SCALE(amp_vol_tlv, 1100, 50, 0);
#endif
base-commit: 2d0401ee38d43ab0e4cdd02dfc9d402befb2b5c8
--
2.44.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: tas2781: mark dvc_tlv with __maybe_unused
2024-03-28 22:47 [PATCH] ASoC: tas2781: mark dvc_tlv with __maybe_unused Gergo Koteles
@ 2024-03-29 7:38 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-03-29 7:38 UTC (permalink / raw)
To: Gergo Koteles
Cc: Shenghao Ding, Kevin Lu, Baojun Xu, Jaroslav Kysela,
Takashi Iwai, alsa-devel, linux-sound, linux-kernel,
kernel test robot
On Thu, 28 Mar 2024 23:47:37 +0100,
Gergo Koteles wrote:
>
> Since we put dvc_tlv static variable to a header file it's copied to
> each module that includes the header. But not all of them are actually
> used it.
>
> Fix this W=1 build warning:
>
> include/sound/tas2781-tlv.h:18:35: warning: 'dvc_tlv' defined but not
> used [-Wunused-const-variable=]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202403290354.v0StnRpc-lkp@intel.com/
> Fixes: ae065d0ce9e3 ("ALSA: hda/tas2781: remove digital gain kcontrol")
> Signed-off-by: Gergo Koteles <soyer@irl.hu>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-29 7:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-28 22:47 [PATCH] ASoC: tas2781: mark dvc_tlv with __maybe_unused Gergo Koteles
2024-03-29 7:38 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).