From: Dave Hansen <haveblue@us.ibm.com>
To: travis@sgi.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
mingo@elte.hu, Andi Kleen <ak@suse.de>,
Christoph Lameter <clameter@sgi.com>,
Jack Steiner <steiner@sgi.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>,
tglx@linutronix.de, mingo@redhat.com
Subject: Re: [PATCH 10/10] x86: Unify percpu.h
Date: Wed, 09 Jan 2008 11:28:24 -0800 [thread overview]
Message-ID: <1199906905.9834.101.camel@localhost> (raw)
In-Reply-To: <20080108211025.293924000@sgi.com>
On Tue, 2008-01-08 at 13:10 -0800, travis@sgi.com wrote:
> Form a single percpu.h from percpu_32.h and percpu_64.h. Both are now pretty
> small so this is simply adding them together.
I guess I just don't really see the point of moving the code around like
this. Before, it would have been easier to tell at a glance before
whether you were looking at 32 or 64-bit code because of which file you
are in. But, now, you need to look for #ifdef context. I'm not sure
that's a win.
This only saves 5 net lines of code, and those are probably from:
-#ifndef __ARCH_I386_PERCPU__
-#define __ARCH_I386_PERCPU__
right?
The rest of the set looks brilliant, though.
-- Dave
next prev parent reply other threads:[~2008-01-09 19:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 21:10 [PATCH 00/10] percpu: Per cpu code simplification V4 travis
2008-01-08 21:10 ` [PATCH 01/10] percpu: Use a kconfig variable to signal arch specific percpu setup travis
2008-01-08 21:10 ` [PATCH 02/10] percpu: Move arch XX_PER_CPU_XX definitions into linux/percpu.h travis
2008-01-08 21:10 ` [PATCH 03/10] percpu: Make the asm-generic/percpu.h more "generic" travis
2008-01-08 21:10 ` [PATCH 04/10] x86_32: Use generic percpu.h travis
2008-01-08 21:10 ` [PATCH 05/10] x86_64: Use generic percpu travis
2008-01-08 21:10 ` [PATCH 06/10] s390: " travis
2008-01-08 21:10 ` [PATCH 07/10] Powerpc: Use generic per cpu travis
2008-01-08 21:10 ` [PATCH 08/10] Sparc64: Use generic percpu travis
2008-01-08 21:10 ` [PATCH 09/10] ia64: " travis
2008-01-08 21:10 ` [PATCH 10/10] x86: Unify percpu.h travis
2008-01-09 19:28 ` Dave Hansen [this message]
2008-01-09 19:31 ` Christoph Lameter
2008-01-09 19:53 ` Dave Hansen
2008-01-09 20:11 ` Christoph Lameter
2008-01-10 13:48 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2008-01-08 2:11 [PATCH 00/10] percpu: Per cpu code simplification V3 travis
2008-01-08 2:11 ` [PATCH 10/10] x86: Unify percpu.h travis
2007-12-28 0:16 [PATCH 00/10] percpu: Per cpu code simplification V2 travis
2007-12-28 0:16 ` [PATCH 10/10] x86: Unify percpu.h travis
2007-11-28 21:09 [patch 00/10] Per cpu code simplification V2 Christoph Lameter
2007-11-28 21:09 ` [patch 10/10] x86: Unify percpu.h Christoph Lameter
2007-11-30 11:14 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199906905.9834.101.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).