* [PATCH] qlge: remove unecessary if statement
@ 2011-06-06 0:44 Greg Dietsche
2011-06-07 5:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Greg Dietsche @ 2011-06-06 0:44 UTC (permalink / raw)
To: ron.mercer; +Cc: linux-driver, netdev, linux-kernel, Greg Dietsche
the code always returns 'status' regardless, so if(status) check is unecessary.
Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
---
drivers/net/qlge/qlge_ethtool.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/qlge/qlge_ethtool.c b/drivers/net/qlge/qlge_ethtool.c
index 19b00fa..9b67bfe 100644
--- a/drivers/net/qlge/qlge_ethtool.c
+++ b/drivers/net/qlge/qlge_ethtool.c
@@ -650,8 +650,6 @@ static int ql_set_pauseparam(struct net_device *netdev,
return -EINVAL;
status = ql_mb_set_port_cfg(qdev);
- if (status)
- return status;
return status;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] qlge: remove unecessary if statement
2011-06-06 0:44 [PATCH] qlge: remove unecessary if statement Greg Dietsche
@ 2011-06-07 5:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-06-07 5:53 UTC (permalink / raw)
To: Gregory.Dietsche; +Cc: ron.mercer, linux-driver, netdev, linux-kernel
From: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Date: Sun, 5 Jun 2011 19:44:13 -0500
> the code always returns 'status' regardless, so if(status) check is unecessary.
>
> Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-07 5:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-06 0:44 [PATCH] qlge: remove unecessary if statement Greg Dietsche
2011-06-07 5:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).