* [PATCH 4/9] drivers/hwmon/asus_atk0110.c: Remove useless kfree
@ 2012-09-12 15:06 Peter Senna Tschudin
2012-09-12 16:19 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Peter Senna Tschudin @ 2012-09-12 15:06 UTC (permalink / raw)
To: Luca Tettamanti
Cc: kernel-janitors, Jean Delvare, Guenter Roeck, lm-sensors, linux-kernel
From: Peter Senna Tschudin <peter.senna@gmail.com>
Remove useless kfree() and clean up code related to the removal.
The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
position p1,p2;
expression x;
@@
if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; }
@unchanged exists@
position r.p1,r.p2;
expression e <= r.x,x,e1;
iterator I;
statement S;
@@
if (x@p1 == NULL) { ... when != I(x,...) S
when != e = e1
when != e += e1
when != e -= e1
when != ++e
when != --e
when != e++
when != e--
when != &e
kfree@p2(x); ... return ...; }
@ok depends on unchanged exists@
position any r.p1;
position r.p2;
expression x;
@@
... when != true x@p1 == NULL
kfree@p2(x);
@depends on !ok && unchanged@
position r.p2;
expression x;
@@
*kfree@p2(x);
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/hwmon/asus_atk0110.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c
index 4ee5789..cccb0e9 100644
--- a/drivers/hwmon/asus_atk0110.c
+++ b/drivers/hwmon/asus_atk0110.c
@@ -962,7 +962,6 @@ static int atk_add_sensor(struct atk_data *data, union acpi_object *obj)
return 1;
out:
- kfree(sensor->acpi_name);
kfree(sensor);
return err;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 4/9] drivers/hwmon/asus_atk0110.c: Remove useless kfree
2012-09-12 15:06 [PATCH 4/9] drivers/hwmon/asus_atk0110.c: Remove useless kfree Peter Senna Tschudin
@ 2012-09-12 16:19 ` Guenter Roeck
2012-09-13 7:05 ` Jean Delvare
0 siblings, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2012-09-12 16:19 UTC (permalink / raw)
To: Peter Senna Tschudin
Cc: Luca Tettamanti, kernel-janitors, Jean Delvare, lm-sensors, linux-kernel
On Wed, Sep 12, 2012 at 05:06:42PM +0200, Peter Senna Tschudin wrote:
> From: Peter Senna Tschudin <peter.senna@gmail.com>
>
> Remove useless kfree() and clean up code related to the removal.
>
Queued for -next.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4/9] drivers/hwmon/asus_atk0110.c: Remove useless kfree
2012-09-12 16:19 ` Guenter Roeck
@ 2012-09-13 7:05 ` Jean Delvare
2012-09-13 13:46 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Jean Delvare @ 2012-09-13 7:05 UTC (permalink / raw)
To: Guenter Roeck
Cc: Peter Senna Tschudin, Luca Tettamanti, kernel-janitors,
lm-sensors, linux-kernel
On Wed, 12 Sep 2012 09:19:25 -0700, Guenter Roeck wrote:
> On Wed, Sep 12, 2012 at 05:06:42PM +0200, Peter Senna Tschudin wrote:
> > From: Peter Senna Tschudin <peter.senna@gmail.com>
> >
> > Remove useless kfree() and clean up code related to the removal.
>
> Queued for -next.
Patch looks good, but I don't see any "code clean-up". Either it was
intended but forgotten, or the patch description claims too much.
--
Jean Delvare
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4/9] drivers/hwmon/asus_atk0110.c: Remove useless kfree
2012-09-13 7:05 ` Jean Delvare
@ 2012-09-13 13:46 ` Guenter Roeck
0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2012-09-13 13:46 UTC (permalink / raw)
To: Jean Delvare
Cc: Peter Senna Tschudin, Luca Tettamanti, kernel-janitors,
lm-sensors, linux-kernel
On Thu, Sep 13, 2012 at 09:05:06AM +0200, Jean Delvare wrote:
> On Wed, 12 Sep 2012 09:19:25 -0700, Guenter Roeck wrote:
> > On Wed, Sep 12, 2012 at 05:06:42PM +0200, Peter Senna Tschudin wrote:
> > > From: Peter Senna Tschudin <peter.senna@gmail.com>
> > >
> > > Remove useless kfree() and clean up code related to the removal.
> >
> > Queued for -next.
>
> Patch looks good, but I don't see any "code clean-up". Either it was
> intended but forgotten, or the patch description claims too much.
>
Thought that referred to the kfree. You are right, that isn't really a cleanup.
I'll drop that comment.
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-13 13:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-12 15:06 [PATCH 4/9] drivers/hwmon/asus_atk0110.c: Remove useless kfree Peter Senna Tschudin
2012-09-12 16:19 ` Guenter Roeck
2012-09-13 7:05 ` Jean Delvare
2012-09-13 13:46 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).