* [PATCH] radeon_display: Use pointer return error codes
@ 2013-01-23 2:27 Su, Xuemin
2013-01-23 14:14 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Su, Xuemin @ 2013-01-23 2:27 UTC (permalink / raw)
To: airlied, airlied, alexander.deucher, s.hauer, ihadzic,
laurent.pinchart, dri-devel, linux-kernel
Cc: bo.he, xuemin.su, yanmin_zhang
From: xueminsu <xuemin.su@intel.com>
Date: Tue, 22 Jan 2013 22:16:53 +0800
Subject: [PATCH] radeon_display: Use pointer return error codes
drm_mode_addfb() expects fb_create return error code
instead of NULL.
Signed-off-by: xueminsu <xuemin.su@intel.com>
---
drivers/gpu/drm/radeon/radeon_display.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index 1da2386..ff3def7 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -1122,7 +1122,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
if (ret) {
kfree(radeon_fb);
drm_gem_object_unreference_unlocked(obj);
- return NULL;
+ return ERR_PTR(ret);
}
return &radeon_fb->base;
--
1.7.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] radeon_display: Use pointer return error codes
2013-01-23 2:27 [PATCH] radeon_display: Use pointer return error codes Su, Xuemin
@ 2013-01-23 14:14 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2013-01-23 14:14 UTC (permalink / raw)
To: Su, Xuemin
Cc: airlied, airlied, alexander.deucher, s.hauer, ihadzic,
laurent.pinchart, dri-devel, linux-kernel, yanmin_zhang, bo.he
On Tue, Jan 22, 2013 at 9:27 PM, Su, Xuemin <xuemin.su@intel.com> wrote:
> From: xueminsu <xuemin.su@intel.com>
> Date: Tue, 22 Jan 2013 22:16:53 +0800
> Subject: [PATCH] radeon_display: Use pointer return error codes
>
> drm_mode_addfb() expects fb_create return error code
> instead of NULL.
>
> Signed-off-by: xueminsu <xuemin.su@intel.com>
Thanks. Added to my fixes queue.
Alex
> ---
> drivers/gpu/drm/radeon/radeon_display.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index 1da2386..ff3def7 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1122,7 +1122,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
> if (ret) {
> kfree(radeon_fb);
> drm_gem_object_unreference_unlocked(obj);
> - return NULL;
> + return ERR_PTR(ret);
> }
>
> return &radeon_fb->base;
> --
> 1.7.6
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-23 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-23 2:27 [PATCH] radeon_display: Use pointer return error codes Su, Xuemin
2013-01-23 14:14 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).