linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 8/8 v3] crypto:s5p-sss: Use clk_prepare/clk_unprepare
@ 2014-01-10 11:45 Naveen Krishna Chatradhi
  2014-01-10 16:04 ` Tomasz Figa
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-01-10 11:45 UTC (permalink / raw)
  To: linux-crypto, linux-samsung-soc
  Cc: linux-kernel, vzapolskiy, herbert, naveenkrishna.ch, cpgs, tomasz.figa

This patch set adds use of clk_prepare/clk_unprepare as
required by generic clock framework.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
---
Changes since v2:
New change to fix a WARN_ON during the bootup

 drivers/crypto/s5p-sss.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 7058bb6..3db7e52 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -653,7 +653,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
 		return -ENOENT;
 	}
 
-	clk_enable(pdata->clk);
+	clk_prepare_enable(pdata->clk);
 
 	spin_lock_init(&pdata->lock);
 	pdata->ioaddr = devm_ioremap(dev, res->start,
@@ -714,7 +714,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
 	tasklet_kill(&pdata->tasklet);
 
  err_irq:
-	clk_disable(pdata->clk);
+	clk_disable_unprepare(pdata->clk);
 
 	s5p_dev = NULL;
 
@@ -734,7 +734,7 @@ static int s5p_aes_remove(struct platform_device *pdev)
 
 	tasklet_kill(&pdata->tasklet);
 
-	clk_disable(pdata->clk);
+	clk_disable_unprepare(pdata->clk);
 
 	s5p_dev = NULL;
 
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH 8/8 v3] crypto:s5p-sss: Use clk_prepare/clk_unprepare
  2014-01-10 11:45 [PATCH 8/8 v3] crypto:s5p-sss: Use clk_prepare/clk_unprepare Naveen Krishna Chatradhi
@ 2014-01-10 16:04 ` Tomasz Figa
  2014-01-15  9:17 ` [PATCH 8/8 v4] " Naveen Krishna Chatradhi
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 8+ messages in thread
From: Tomasz Figa @ 2014-01-10 16:04 UTC (permalink / raw)
  To: Naveen Krishna Chatradhi, linux-crypto, linux-samsung-soc
  Cc: linux-kernel, vzapolskiy, herbert, naveenkrishna.ch, cpgs, tomasz.figa

Hi Naveen,

On 10.01.2014 12:45, Naveen Krishna Chatradhi wrote:
> This patch set adds use of clk_prepare/clk_unprepare as
> required by generic clock framework.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> ---
> Changes since v2:
> New change to fix a WARN_ON during the bootup
>
>   drivers/crypto/s5p-sss.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Best regards,
Tomasz

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare
  2014-01-10 11:45 [PATCH 8/8 v3] crypto:s5p-sss: Use clk_prepare/clk_unprepare Naveen Krishna Chatradhi
  2014-01-10 16:04 ` Tomasz Figa
@ 2014-01-15  9:17 ` Naveen Krishna Chatradhi
  2014-01-23 10:18   ` Naveen Krishna Ch
  2014-01-29  9:26 ` [PATCH 8/9 v5] " Naveen Krishna Chatradhi
  2014-02-07  5:26 ` [PATCH 8/9 v6] " Naveen Krishna Chatradhi
  3 siblings, 1 reply; 8+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-01-15  9:17 UTC (permalink / raw)
  To: linux-crypto, linux-samsung-soc
  Cc: linux-kernel, vzapolskiy, herbert, naveenkrishna.ch, cpgs, tomasz.figa

This patch set adds use of clk_prepare/clk_unprepare as
required by generic clock framework.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
---
Changes since v3:
None

 drivers/crypto/s5p-sss.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index f7c66c7..870e794 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -648,7 +648,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
 		return -ENOENT;
 	}
 
-	clk_enable(pdata->clk);
+	clk_prepare_enable(pdata->clk);
 
 	spin_lock_init(&pdata->lock);
 	pdata->ioaddr = devm_ioremap(dev, res->start,
@@ -711,7 +711,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
 	tasklet_kill(&pdata->tasklet);
 
  err_irq:
-	clk_disable(pdata->clk);
+	clk_disable_unprepare(pdata->clk);
 
 	s5p_dev = NULL;
 
@@ -731,7 +731,7 @@ static int s5p_aes_remove(struct platform_device *pdev)
 
 	tasklet_kill(&pdata->tasklet);
 
-	clk_disable(pdata->clk);
+	clk_disable_unprepare(pdata->clk);
 
 	s5p_dev = NULL;
 
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare
  2014-01-15  9:17 ` [PATCH 8/8 v4] " Naveen Krishna Chatradhi
@ 2014-01-23 10:18   ` Naveen Krishna Ch
  2014-01-23 10:41     ` Sylwester Nawrocki
  0 siblings, 1 reply; 8+ messages in thread
From: Naveen Krishna Ch @ 2014-01-23 10:18 UTC (permalink / raw)
  To: Naveen Krishna Chatradhi
  Cc: linux-crypto, linux-samsung-soc, linux-kernel,
	Vladimir Zapolskiy, herbert, cpgs, tomasz.figa

Hello All,

On 15 January 2014 14:47, Naveen Krishna Chatradhi
<ch.naveen@samsung.com> wrote:
> This patch set adds use of clk_prepare/clk_unprepare as
> required by generic clock framework.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
> ---
> Changes since v3:
> None
>
>  drivers/crypto/s5p-sss.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> index f7c66c7..870e794 100644
> --- a/drivers/crypto/s5p-sss.c
> +++ b/drivers/crypto/s5p-sss.c
> @@ -648,7 +648,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
>                 return -ENOENT;
>         }
>
> -       clk_enable(pdata->clk);
> +       clk_prepare_enable(pdata->clk);
>
>         spin_lock_init(&pdata->lock);
>         pdata->ioaddr = devm_ioremap(dev, res->start,
> @@ -711,7 +711,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
>         tasklet_kill(&pdata->tasklet);
>
>   err_irq:
> -       clk_disable(pdata->clk);
> +       clk_disable_unprepare(pdata->clk);
>
>         s5p_dev = NULL;
>
> @@ -731,7 +731,7 @@ static int s5p_aes_remove(struct platform_device *pdev)
>
>         tasklet_kill(&pdata->tasklet);
>
> -       clk_disable(pdata->clk);
> +       clk_disable_unprepare(pdata->clk);
>
>         s5p_dev = NULL;
>
> --
> 1.7.9.5
Any update on this patch, Please
>



-- 
Shine bright,
(: Nav :)

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare
  2014-01-23 10:18   ` Naveen Krishna Ch
@ 2014-01-23 10:41     ` Sylwester Nawrocki
  2014-01-29  7:37       ` Naveen Krishna Ch
  0 siblings, 1 reply; 8+ messages in thread
From: Sylwester Nawrocki @ 2014-01-23 10:41 UTC (permalink / raw)
  To: Naveen Krishna Ch, Naveen Krishna Chatradhi
  Cc: linux-crypto, linux-samsung-soc, linux-kernel,
	Vladimir Zapolskiy, herbert, cpgs, tomasz.figa

Hi,

On 23/01/14 11:18, Naveen Krishna Ch wrote:
> Hello All,
> 
> On 15 January 2014 14:47, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
>> This patch set adds use of clk_prepare/clk_unprepare as
>> required by generic clock framework.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>> ---
>> Changes since v3:
>> None
>>
>>  drivers/crypto/s5p-sss.c |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
>> index f7c66c7..870e794 100644
>> --- a/drivers/crypto/s5p-sss.c
>> +++ b/drivers/crypto/s5p-sss.c
>> @@ -648,7 +648,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
>>                 return -ENOENT;
>>         }
>>
>> -       clk_enable(pdata->clk);
>> +       clk_prepare_enable(pdata->clk);

How about properly checking the return value ?

--
Thanks,
Sylwester

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare
  2014-01-23 10:41     ` Sylwester Nawrocki
@ 2014-01-29  7:37       ` Naveen Krishna Ch
  0 siblings, 0 replies; 8+ messages in thread
From: Naveen Krishna Ch @ 2014-01-29  7:37 UTC (permalink / raw)
  To: Sylwester Nawrocki
  Cc: Naveen Krishna Chatradhi, linux-crypto, linux-samsung-soc,
	linux-kernel, Vladimir Zapolskiy, herbert, cpgs, tomasz.figa

Hello Sylwester,

On 23 January 2014 16:11, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote:
> Hi,
>
> On 23/01/14 11:18, Naveen Krishna Ch wrote:
>> Hello All,
>>
>> On 15 January 2014 14:47, Naveen Krishna Chatradhi
>> <ch.naveen@samsung.com> wrote:
>>> This patch set adds use of clk_prepare/clk_unprepare as
>>> required by generic clock framework.
>>>
>>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>>> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>>> ---
>>> Changes since v3:
>>> None
>>>
>>>  drivers/crypto/s5p-sss.c |    6 +++---
>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
>>> index f7c66c7..870e794 100644
>>> --- a/drivers/crypto/s5p-sss.c
>>> +++ b/drivers/crypto/s5p-sss.c
>>> @@ -648,7 +648,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
>>>                 return -ENOENT;
>>>         }
>>>
>>> -       clk_enable(pdata->clk);
>>> +       clk_prepare_enable(pdata->clk);
>
> How about properly checking the return value ?
Sure, Thanks.
>
> --
> Thanks,
> Sylwester



-- 
Shine bright,
(: Nav :)

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH 8/9 v5] crypto:s5p-sss: Use clk_prepare/clk_unprepare
  2014-01-10 11:45 [PATCH 8/8 v3] crypto:s5p-sss: Use clk_prepare/clk_unprepare Naveen Krishna Chatradhi
  2014-01-10 16:04 ` Tomasz Figa
  2014-01-15  9:17 ` [PATCH 8/8 v4] " Naveen Krishna Chatradhi
@ 2014-01-29  9:26 ` Naveen Krishna Chatradhi
  2014-02-07  5:26 ` [PATCH 8/9 v6] " Naveen Krishna Chatradhi
  3 siblings, 0 replies; 8+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-01-29  9:26 UTC (permalink / raw)
  To: linux-crypto, linux-samsung-soc
  Cc: linux-kernel, vzapolskiy, herbert, naveenkrishna.ch, cpgs, devicetree

This patch set adds use of clk_prepare/clk_unprepare as
required by generic clock framework.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
---
Changes since v4:
Handle return value of clk_prepare_enable

Changes since v3:
None

 drivers/crypto/s5p-sss.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index a890273..5bd3bd9 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -648,7 +648,11 @@ static int s5p_aes_probe(struct platform_device *pdev)
 		return -ENOENT;
 	}
 
-	clk_enable(pdata->clk);
+	err = clk_prepare_enable(pdata->clk);
+	if (err < 0) {
+		dev_err(dev, "Enabling SSS clk failed, err %d\n", err);
+		return err;
+	}
 
 	spin_lock_init(&pdata->lock);
 	pdata->ioaddr = devm_ioremap(dev, res->start,
@@ -711,7 +715,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
 	tasklet_kill(&pdata->tasklet);
 
  err_irq:
-	clk_disable(pdata->clk);
+	clk_disable_unprepare(pdata->clk);
 
 	s5p_dev = NULL;
 
@@ -731,7 +735,7 @@ static int s5p_aes_remove(struct platform_device *pdev)
 
 	tasklet_kill(&pdata->tasklet);
 
-	clk_disable(pdata->clk);
+	clk_disable_unprepare(pdata->clk);
 
 	s5p_dev = NULL;
 
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH 8/9 v6] crypto:s5p-sss: Use clk_prepare/clk_unprepare
  2014-01-10 11:45 [PATCH 8/8 v3] crypto:s5p-sss: Use clk_prepare/clk_unprepare Naveen Krishna Chatradhi
                   ` (2 preceding siblings ...)
  2014-01-29  9:26 ` [PATCH 8/9 v5] " Naveen Krishna Chatradhi
@ 2014-02-07  5:26 ` Naveen Krishna Chatradhi
  3 siblings, 0 replies; 8+ messages in thread
From: Naveen Krishna Chatradhi @ 2014-02-07  5:26 UTC (permalink / raw)
  To: linux-crypto, linux-samsung-soc
  Cc: linux-kernel, vzapolskiy, herbert, naveenkrishna.ch, cpgs

This patch set adds use of clk_prepare/clk_unprepare as
required by generic clock framework.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
---
changes since v5:
None

 drivers/crypto/s5p-sss.c |   10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index a890273..d35a477 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -648,7 +648,11 @@ static int s5p_aes_probe(struct platform_device *pdev)
 		return -ENOENT;
 	}
 
-	clk_enable(pdata->clk);
+	err = clk_prepare_enable(pdata->clk);
+	if (err < 0) {
+		dev_err(dev, "Enabling SSS clk failed, err %d\n", err);
+		return err;
+	}
 
 	spin_lock_init(&pdata->lock);
 	pdata->ioaddr = devm_ioremap(dev, res->start,
@@ -711,7 +715,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
 	tasklet_kill(&pdata->tasklet);
 
  err_irq:
-	clk_disable(pdata->clk);
+	clk_disable_unprepare(pdata->clk);
 
 	s5p_dev = NULL;
 
@@ -731,7 +735,7 @@ static int s5p_aes_remove(struct platform_device *pdev)
 
 	tasklet_kill(&pdata->tasklet);
 
-	clk_disable(pdata->clk);
+	clk_disable_unprepare(pdata->clk);
 
 	s5p_dev = NULL;
 
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-02-07  5:26 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-10 11:45 [PATCH 8/8 v3] crypto:s5p-sss: Use clk_prepare/clk_unprepare Naveen Krishna Chatradhi
2014-01-10 16:04 ` Tomasz Figa
2014-01-15  9:17 ` [PATCH 8/8 v4] " Naveen Krishna Chatradhi
2014-01-23 10:18   ` Naveen Krishna Ch
2014-01-23 10:41     ` Sylwester Nawrocki
2014-01-29  7:37       ` Naveen Krishna Ch
2014-01-29  9:26 ` [PATCH 8/9 v5] " Naveen Krishna Chatradhi
2014-02-07  5:26 ` [PATCH 8/9 v6] " Naveen Krishna Chatradhi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).