* [PATCH] staging: rtl8188eu: os_dep: usb_intf.c: Cleaning up unnecessary code
@ 2014-06-01 16:32 Rickard Strandqvist
0 siblings, 0 replies; 3+ messages in thread
From: Rickard Strandqvist @ 2014-06-01 16:32 UTC (permalink / raw)
To: Greg Kroah-Hartman, Larry Finger
Cc: Rickard Strandqvist, Manu Gupta, Josh Triplett,
Geert Uytterhoeven, devel, linux-kernel
Removes unnecessary code that does not do anything useful.
This was partly found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 2e49cd5..fb3789e 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
@@ -563,14 +563,8 @@ static int rtw_resume(struct usb_interface *pusb_intf)
{
struct dvobj_priv *dvobj = usb_get_intfdata(pusb_intf);
struct adapter *padapter = dvobj->if1;
- struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
- int ret = 0;
- if (pwrpriv->bInternalAutoSuspend)
- ret = rtw_resume_process(padapter);
- else
- ret = rtw_resume_process(padapter);
- return ret;
+ return rtw_resume_process(padapter);
}
int rtw_resume_process(struct adapter *padapter)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8188eu: os_dep: usb_intf.c: Cleaning up unnecessary code
2014-06-06 16:15 ` [PATCH] staging: rtl8188eu: os_dep: usb_intf.c: Cleaning up unnecessary code navin patidar
@ 2014-06-06 16:47 ` navin patidar
0 siblings, 0 replies; 3+ messages in thread
From: navin patidar @ 2014-06-06 16:47 UTC (permalink / raw)
To: Greg KH; +Cc: Larry Finger, devel, linux-kernel, Rickard Strandqvist
sorry, my script picked up Rickard's patch and send it out again
along my patches.
I need to fix my script.
regards,
navin patidar
On Fri, Jun 6, 2014 at 9:45 PM, navin patidar <navin.patidar@gmail.com> wrote:
> From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
>
> Removes unnecessary code that does not do anything useful.
>
> This was partly found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/rtl8188eu/os_dep/usb_intf.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
> index 2e49cd5..fb3789e 100644
> --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
> +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
> @@ -563,14 +563,8 @@ static int rtw_resume(struct usb_interface *pusb_intf)
> {
> struct dvobj_priv *dvobj = usb_get_intfdata(pusb_intf);
> struct adapter *padapter = dvobj->if1;
> - struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
> - int ret = 0;
>
> - if (pwrpriv->bInternalAutoSuspend)
> - ret = rtw_resume_process(padapter);
> - else
> - ret = rtw_resume_process(padapter);
> - return ret;
> + return rtw_resume_process(padapter);
> }
>
> int rtw_resume_process(struct adapter *padapter)
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] staging: rtl8188eu: os_dep: usb_intf.c: Cleaning up unnecessary code
2014-06-06 16:15 [PATCH 02/13] staging: rtl8188eu: Remove rtw_deinit_intf_priv() navin patidar
@ 2014-06-06 16:15 ` navin patidar
2014-06-06 16:47 ` navin patidar
0 siblings, 1 reply; 3+ messages in thread
From: navin patidar @ 2014-06-06 16:15 UTC (permalink / raw)
To: gregkh; +Cc: Larry.Finger, devel, linux-kernel, Rickard Strandqvist
From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Removes unnecessary code that does not do anything useful.
This was partly found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 2e49cd5..fb3789e 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
@@ -563,14 +563,8 @@ static int rtw_resume(struct usb_interface *pusb_intf)
{
struct dvobj_priv *dvobj = usb_get_intfdata(pusb_intf);
struct adapter *padapter = dvobj->if1;
- struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;
- int ret = 0;
- if (pwrpriv->bInternalAutoSuspend)
- ret = rtw_resume_process(padapter);
- else
- ret = rtw_resume_process(padapter);
- return ret;
+ return rtw_resume_process(padapter);
}
int rtw_resume_process(struct adapter *padapter)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-06 16:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-01 16:32 [PATCH] staging: rtl8188eu: os_dep: usb_intf.c: Cleaning up unnecessary code Rickard Strandqvist
2014-06-06 16:15 [PATCH 02/13] staging: rtl8188eu: Remove rtw_deinit_intf_priv() navin patidar
2014-06-06 16:15 ` [PATCH] staging: rtl8188eu: os_dep: usb_intf.c: Cleaning up unnecessary code navin patidar
2014-06-06 16:47 ` navin patidar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).