* [PATCH 1/2] platform/chrome: cros_ec_dev - fix Unknown escape '%' warning
@ 2015-03-03 12:22 Javier Martinez Canillas
2015-03-03 12:22 ` [PATCH 2/2] platform/chrome: cros_ec_lightbar - fix duplicate const warning Javier Martinez Canillas
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2015-03-03 12:22 UTC (permalink / raw)
To: Olof Johansson
Cc: Gwendal Grignou, Dan Carpenter, Bill Richardson, linux-kernel,
Olof Johansson, Javier Martinez Canillas
From: Olof Johansson <olofj@chromium.org>
Fix the following sparse warning:
drivers/platform/chrome/cros_ec_dev.c:64:45: sparse: Unknown escape '%'
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Olof Johansson <olofj@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
drivers/platform/chrome/cros_ec_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c
index ce714317a59e..6090d0b2826f 100644
--- a/drivers/platform/chrome/cros_ec_dev.c
+++ b/drivers/platform/chrome/cros_ec_dev.c
@@ -61,7 +61,7 @@ static int ec_get_version(struct cros_ec_device *ec, char *str, int maxlen)
if (resp->current_image >= ARRAY_SIZE(current_image_name))
resp->current_image = 3; /* invalid */
- snprintf(str, maxlen, "%s\n%s\n%s\n\%s\n", CROS_EC_DEV_VERSION,
+ snprintf(str, maxlen, "%s\n%s\n%s\n%s\n", CROS_EC_DEV_VERSION,
resp->version_string_ro, resp->version_string_rw,
current_image_name[resp->current_image]);
--
2.1.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] platform/chrome: cros_ec_lightbar - fix duplicate const warning
2015-03-03 12:22 [PATCH 1/2] platform/chrome: cros_ec_dev - fix Unknown escape '%' warning Javier Martinez Canillas
@ 2015-03-03 12:22 ` Javier Martinez Canillas
0 siblings, 0 replies; 2+ messages in thread
From: Javier Martinez Canillas @ 2015-03-03 12:22 UTC (permalink / raw)
To: Olof Johansson
Cc: Gwendal Grignou, Dan Carpenter, Bill Richardson, linux-kernel,
Olof Johansson, Javier Martinez Canillas
From: Olof Johansson <olofj@chromium.org>
Fix the following sparse warning:
drivers/platform/chrome/cros_ec_lightbar.c:254:25: sparse: duplicate const
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Olof Johansson <olofj@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
---
drivers/platform/chrome/cros_ec_lightbar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
index 35fc892e4c95..b4ff47a9069a 100644
--- a/drivers/platform/chrome/cros_ec_lightbar.c
+++ b/drivers/platform/chrome/cros_ec_lightbar.c
@@ -251,7 +251,7 @@ static ssize_t led_rgb_store(struct device *dev, struct device_attribute *attr,
return (ok && i == 0) ? count : -EINVAL;
}
-static const char const *seqname[] = {
+static char const *seqname[] = {
"ERROR", "S5", "S3", "S0", "S5S3", "S3S0",
"S0S3", "S3S5", "STOP", "RUN", "PULSE", "TEST", "KONAMI",
};
--
2.1.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-03 12:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-03 12:22 [PATCH 1/2] platform/chrome: cros_ec_dev - fix Unknown escape '%' warning Javier Martinez Canillas
2015-03-03 12:22 ` [PATCH 2/2] platform/chrome: cros_ec_lightbar - fix duplicate const warning Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).