* Re: [PATCH] core: Convert the function process_ipcsec to the, return type bool
[not found] <1432775694-30144-1-git-send-email-xerofoify@gmail.com>
@ 2015-05-28 1:47 ` Joe Perches
0 siblings, 0 replies; only message in thread
From: Joe Perches @ 2015-05-28 1:47 UTC (permalink / raw)
To: Nicholas Krause
Cc: davem, brouer, edumazet, ast, sd, elfring, netdev, linux-kernel
On Wed, 2015-05-27 at 21:14 -0400, Nicholas Krause wrote:
> This makes the function,process_ipsec have a return true
> of bool now due to only returning 1 or 0. In additon this
> changes this function's return statements to return true
> and false rather then 1 and 0 respectfully.
The patch subject title and the grammar in the commit message
could be improved, but other than that, it seems OK to me.
I would have written something like:
Subject: [PATCH] pktgen: Convert return type of process_ipsec to bool
It's used as a bool function, make it so.
Convert the return 1/0 to return true/false too.
Signed-off-by: etc...
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-05-28 1:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1432775694-30144-1-git-send-email-xerofoify@gmail.com>
2015-05-28 1:47 ` [PATCH] core: Convert the function process_ipcsec to the, return type bool Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).