From: Douglas Anderson <dianders@chromium.org>
To: ulf.hansson@linaro.org, jh80.chung@samsung.com
Cc: shawn.lin@rock-chips.com, adrian.hunter@intel.com,
stefan@agner.ch, linux-mmc@vger.kernel.org,
computersforpeace@gmail.com, dmitry.torokhov@gmail.com,
Heiko Stuebner <heiko@sntech.de>,
jszhang@marvell.com, linux-rockchip@lists.infradead.org,
devicetree-spec@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
jonathanh@nvidia.com, grundler@chromium.org, lporzio@micron.com,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/4] mmc: use SD/MMC host ID for block device name ID
Date: Fri, 29 Apr 2016 10:32:18 -0700 [thread overview]
Message-ID: <1461951139-6109-4-git-send-email-dianders@chromium.org> (raw)
In-Reply-To: <1461951139-6109-1-git-send-email-dianders@chromium.org>
From: Stefan Agner <stefan@agner.ch>
By using the SD/MMC host device ID as a starting point for block
device numbering, one can reliably predict the first block device
name (at least for the first controller). This is especially useful
for SoCs with multiple SD/MMC host controller, where the controller
with index 0 is connected to a eMMC device.
Usually the first controller gets the first block device name ID,
however this is not guaranteed. Also if the first controller is
aliased as second controller and visa-versa (using device tree
aliases), the block device name ID assignation is not ordered by
the SD/MMC host device ID (since mmc_rescan is called in order of
the memory mapped pheripherial addresses).
Signed-off-by: Stefan Agner <stefan@agner.ch>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v2:
- Rebased atop mmc-next
drivers/mmc/card/block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index 9ce679255775..360700f3e0ea 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -2197,7 +2197,7 @@ again:
return ERR_PTR(-ENOMEM);
spin_lock(&mmc_blk_lock);
- ret = ida_get_new(&mmc_blk_ida, &devidx);
+ ret = ida_get_new_above(&mmc_blk_ida, card->host->index, &devidx);
spin_unlock(&mmc_blk_lock);
if (ret == -EAGAIN)
--
2.8.0.rc3.226.g39d4020
next prev parent reply other threads:[~2016-04-29 17:32 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 17:32 [PATCH v2 0/4] Patches to allow consistent mmc / mmcblk numbering w/ device tree Douglas Anderson
2016-04-29 17:32 ` [PATCH v2 1/4] Documentation: mmc: Document mmc aliases Douglas Anderson
2016-04-29 17:32 ` [PATCH v2 2/4] mmc: read mmc alias from device tree Douglas Anderson
2016-04-29 17:32 ` Douglas Anderson [this message]
2016-04-29 17:32 ` [PATCH v2 4/4] ARM: dts: rockchip: Add mmc aliases for rk3288 platform Douglas Anderson
2016-04-29 18:12 ` [PATCH v2 0/4] Patches to allow consistent mmc / mmcblk numbering w/ device tree Rob Herring
2016-04-29 19:31 ` Doug Anderson
2016-04-29 19:50 ` Russell King - ARM Linux
2016-04-29 20:02 ` Doug Anderson
2016-04-29 18:12 ` Russell King - ARM Linux
2016-04-29 19:43 ` Doug Anderson
2016-04-29 19:57 ` Russell King - ARM Linux
2016-04-29 20:04 ` Doug Anderson
2016-04-29 21:13 ` Russell King - ARM Linux
2016-04-29 21:17 ` Doug Anderson
2016-04-29 21:29 ` Russell King - ARM Linux
2016-04-29 21:39 ` Doug Anderson
2016-04-29 21:50 ` Russell King - ARM Linux
2016-04-29 21:56 ` Doug Anderson
2016-04-29 22:16 ` Russell King - ARM Linux
2016-04-29 22:22 ` Doug Anderson
2016-04-29 22:44 ` Russell King - ARM Linux
2016-04-29 23:01 ` Doug Anderson
2016-04-29 23:58 ` Peter Hurley
[not found] ` <CAD=FV=V_YyfBOSs7BLkyhv=_5HBmf3djUWACbL6d-bwnrueDjA@mail.gmail.com>
2016-04-30 0:31 ` Peter Hurley
2016-04-30 2:29 ` Doug Anderson
2016-04-30 8:38 ` Russell King - ARM Linux
2016-04-30 13:23 ` Rob Herring
2016-04-29 22:42 ` Javier Martinez Canillas
2016-04-30 10:48 ` Russell King - ARM Linux
2016-05-03 19:17 ` Trent Piepho
2016-05-04 7:18 ` Pavel Machek
2016-05-04 12:25 ` Rob Herring
2016-05-04 12:46 ` Pavel Machek
2019-03-05 12:39 ` Måns Rullgård
2019-03-15 21:52 ` Tim Harvey
2019-03-15 23:00 ` Marek Vasut
2019-03-15 23:13 ` Tim Harvey
2019-03-15 23:23 ` Doug Anderson
[not found] ` <yw1xftrn2em9.fsf@mansr.com>
2019-03-16 12:33 ` Marek Vasut
2019-03-16 15:39 ` Russell King - ARM Linux admin
2019-03-17 15:05 ` Stefan Agner
2019-03-17 15:43 ` Russell King - ARM Linux admin
2019-03-17 15:50 ` Marek Vasut
2019-03-17 16:48 ` Måns Rullgård
2019-03-17 16:59 ` Russell King - ARM Linux admin
2019-03-27 17:37 ` Tim Harvey
2019-03-27 20:54 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461951139-6109-4-git-send-email-dianders@chromium.org \
--to=dianders@chromium.org \
--cc=adrian.hunter@intel.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree-spec@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grundler@chromium.org \
--cc=heiko@sntech.de \
--cc=jh80.chung@samsung.com \
--cc=jonathanh@nvidia.com \
--cc=jszhang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lporzio@micron.com \
--cc=shawn.lin@rock-chips.com \
--cc=stefan@agner.ch \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).