From: Purna Chandra Mandal <purna.mandal@microchip.com>
To: <linux-kernel@vger.kernel.org>
Cc: <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>,
Purna Chandra Mandal <purna.mandal@microchip.com>,
Jiri Slaby <jslaby@suse.com>, Alan Cox <alan@linux.intel.com>,
Andrei Pistirica <andrei.pistirica@microchip.com>,
<linux-serial@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH 05/11] serial: pic32_uart: Fix double free of 'sport->irq_fault_name'.
Date: Tue, 17 May 2016 10:35:54 +0530 [thread overview]
Message-ID: <1463461560-9629-5-git-send-email-purna.mandal@microchip.com> (raw)
In-Reply-To: <1463461560-9629-1-git-send-email-purna.mandal@microchip.com>
Allocated memory for 'sport->irq_fault_name' is freed twice, first
in error check of 'if(!sport->irq_rx_name)' and other in fallback
handler.
Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
---
drivers/tty/serial/pic32_uart.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/pic32_uart.c b/drivers/tty/serial/pic32_uart.c
index 62a43bf..7f8e99b 100644
--- a/drivers/tty/serial/pic32_uart.c
+++ b/drivers/tty/serial/pic32_uart.c
@@ -445,7 +445,6 @@ static int pic32_uart_startup(struct uart_port *port)
sport->idx);
if (!sport->irq_rx_name) {
dev_err(port->dev, "%s: kasprintf err!", __func__);
- kfree(sport->irq_fault_name);
ret = -ENOMEM;
goto out_f;
}
--
1.8.3.1
next prev parent reply other threads:[~2016-05-17 5:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 5:05 [PATCH 01/11] clk: microchip: use readl_poll_timeout() in pbclk_set_rate() Purna Chandra Mandal
2016-05-17 5:05 ` [PATCH 02/11] clk: microchip: Initialize SOSC clock rate for PIC32MZDA Purna Chandra Mandal
2016-08-24 23:05 ` Stephen Boyd
2016-05-17 5:05 ` [PATCH 03/11] MIPS: pic32mzda: fix getting timer clock rate Purna Chandra Mandal
2016-05-17 12:30 ` Ralf Baechle
2016-05-25 16:02 ` Harvey Hunt
2016-06-02 5:05 ` Purna Chandra Mandal
2016-05-17 5:05 ` [PATCH 04/11] irqchip: irq-pic32-evic: Fix bug with external interrupts Purna Chandra Mandal
2016-05-17 8:09 ` Marc Zyngier
2016-05-17 5:05 ` Purna Chandra Mandal [this message]
2016-05-17 5:05 ` [PATCH 06/11] dt/bindings: Correct clk binding example for PIC32 SDHCI Purna Chandra Mandal
2016-05-18 16:50 ` Rob Herring
2016-05-17 5:05 ` [PATCH 07/11] dt/bindings: Correct clk binding example for PIC32 pinctrl Purna Chandra Mandal
2016-05-18 16:50 ` Rob Herring
2016-05-26 8:37 ` Linus Walleij
2016-05-17 5:05 ` [PATCH 08/11] dt/bindings: Correct clk binding example for PIC32 serial Purna Chandra Mandal
2016-05-18 16:51 ` Rob Herring
2016-05-17 5:05 ` [PATCH 09/11] dt/bindings: Correct clk binding example for PIC32 DMT Purna Chandra Mandal
2016-05-18 16:51 ` Rob Herring
2016-05-17 5:05 ` [PATCH 10/11] dt/bindings: Correct clk binding example for PIC32 WDT Purna Chandra Mandal
2016-05-18 16:52 ` Rob Herring
2016-05-17 5:06 ` [PATCH 11/11] dt/bindings: Correct clk binding example for PIC32 gpio Purna Chandra Mandal
2016-05-18 16:52 ` Rob Herring
2016-05-26 8:38 ` Linus Walleij
2016-08-24 23:05 ` [PATCH 01/11] clk: microchip: use readl_poll_timeout() in pbclk_set_rate() Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463461560-9629-5-git-send-email-purna.mandal@microchip.com \
--to=purna.mandal@microchip.com \
--cc=alan@linux.intel.com \
--cc=andrei.pistirica@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).