* [PATCH] iwlegacy: avoid warning about missing braces
@ 2016-05-19 7:58 Arnd Bergmann
2016-05-19 12:38 ` Stanislaw Gruszka
2016-06-14 14:26 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-05-19 7:58 UTC (permalink / raw)
To: Stanislaw Gruszka, Kalle Valo
Cc: Arnd Bergmann, Johannes Berg, linux-wireless, netdev, linux-kernel
gcc-6 warns about code in il3945_hw_txq_ctx_free() being
somewhat ambiguous:
drivers/net/wireless/intel/iwlegacy/3945.c:1022:5: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
This adds a set of curly braces to avoid the warning.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/wireless/intel/iwlegacy/3945.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlegacy/3945.c b/drivers/net/wireless/intel/iwlegacy/3945.c
index 7bcedbb53d94..209dc9988455 100644
--- a/drivers/net/wireless/intel/iwlegacy/3945.c
+++ b/drivers/net/wireless/intel/iwlegacy/3945.c
@@ -1019,12 +1019,13 @@ il3945_hw_txq_ctx_free(struct il_priv *il)
int txq_id;
/* Tx queues */
- if (il->txq)
+ if (il->txq) {
for (txq_id = 0; txq_id < il->hw_params.max_txq_num; txq_id++)
if (txq_id == IL39_CMD_QUEUE_NUM)
il_cmd_queue_free(il);
else
il_tx_queue_free(il, txq_id);
+ }
/* free tx queue structure */
il_free_txq_mem(il);
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iwlegacy: avoid warning about missing braces
2016-05-19 7:58 [PATCH] iwlegacy: avoid warning about missing braces Arnd Bergmann
@ 2016-05-19 12:38 ` Stanislaw Gruszka
2016-06-14 14:26 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Stanislaw Gruszka @ 2016-05-19 12:38 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Kalle Valo, Johannes Berg, linux-wireless, netdev, linux-kernel
On Thu, May 19, 2016 at 09:58:49AM +0200, Arnd Bergmann wrote:
> gcc-6 warns about code in il3945_hw_txq_ctx_free() being
> somewhat ambiguous:
>
> drivers/net/wireless/intel/iwlegacy/3945.c:1022:5: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
>
> This adds a set of curly braces to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: iwlegacy: avoid warning about missing braces
2016-05-19 7:58 [PATCH] iwlegacy: avoid warning about missing braces Arnd Bergmann
2016-05-19 12:38 ` Stanislaw Gruszka
@ 2016-06-14 14:26 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2016-06-14 14:26 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Stanislaw Gruszka, Arnd Bergmann, Johannes Berg, linux-wireless,
netdev, linux-kernel
Arnd Bergmann <arnd@arndb.de> wrote:
> gcc-6 warns about code in il3945_hw_txq_ctx_free() being
> somewhat ambiguous:
>
> drivers/net/wireless/intel/iwlegacy/3945.c:1022:5: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
>
> This adds a set of curly braces to avoid the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
Thanks, 1 patch applied to wireless-drivers-next.git:
2cce76c3fab4 iwlegacy: avoid warning about missing braces
--
Sent by pwcli
https://patchwork.kernel.org/patch/9124661/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-14 14:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-19 7:58 [PATCH] iwlegacy: avoid warning about missing braces Arnd Bergmann
2016-05-19 12:38 ` Stanislaw Gruszka
2016-06-14 14:26 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).