From: Vincent Guittot <vincent.guittot@linaro.org>
To: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org
Cc: yuyang.du@intel.com, dietmar.eggemann@arm.com,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: [PATCH v2] sched: fix first task of a task group is attached twice
Date: Wed, 25 May 2016 17:01:11 +0200 [thread overview]
Message-ID: <1464188472-30086-1-git-send-email-vincent.guittot@linaro.org> (raw)
In-Reply-To: <1464095335-27730-1-git-send-email-vincent.guittot@linaro.org>
The cfs_rq->avg.last_update_time is initialize to 0 with the main effect
that the 1st sched_entity that will be attached, will keep its
last_update_time set to 0 and will attached once again during the
enqueue.
Initialize cfs_rq->avg.last_update_time to 1 instead.
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
v2:
- rq_clock_task(rq_of(cfs_rq)) can't be used because lock is not held
kernel/sched/fair.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 218f8e8..3724656 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8586,6 +8586,14 @@ void init_tg_cfs_entry(struct task_group *tg, struct cfs_rq *cfs_rq,
se->depth = parent->depth + 1;
}
+ /*
+ * Set last_update_time to something different from 0 to make
+ * sure the 1st sched_entity will not be attached twice: once
+ * when attaching the task to the group and one more time when
+ * enqueueing the task.
+ */
+ tg->cfs_rq[cpu]->avg.last_update_time = 1;
+
se->my_q = cfs_rq;
/* guarantee group entities always have weight */
update_load_set(&se->load, NICE_0_LOAD);
--
1.9.1
next prev parent reply other threads:[~2016-05-25 15:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 13:08 [PATCH] sched: fix first task of a task group is attached twice Vincent Guittot
2016-05-25 15:01 ` Vincent Guittot [this message]
2016-05-25 22:38 ` [PATCH v2] " Yuyang Du
2016-05-26 8:26 ` Vincent Guittot
2016-05-26 0:40 ` Yuyang Du
2016-05-26 8:51 ` Vincent Guittot
2016-05-27 15:48 ` Dietmar Eggemann
2016-05-27 17:16 ` Vincent Guittot
2016-05-27 20:38 ` Dietmar Eggemann
2016-05-30 7:04 ` Vincent Guittot
2016-05-30 15:52 ` [PATCH v3] " Vincent Guittot
2016-05-30 19:48 ` Yuyang Du
2016-05-31 7:28 ` Vincent Guittot
2016-05-31 0:44 ` Yuyang Du
2016-06-01 15:31 ` Dietmar Eggemann
2016-06-01 15:54 ` Vincent Guittot
2016-06-06 19:32 ` Dietmar Eggemann
2016-06-07 7:35 ` Vincent Guittot
2016-06-15 19:19 ` Yuyang Du
2016-06-16 7:12 ` Vincent Guittot
2016-06-15 23:24 ` Yuyang Du
2016-06-16 9:42 ` Vincent Guittot
2016-05-30 15:54 ` [PATCH v2] " Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464188472-30086-1-git-send-email-vincent.guittot@linaro.org \
--to=vincent.guittot@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).