From: Vincent Guittot <vincent.guittot@linaro.org>
To: Yuyang Du <yuyang.du@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>
Subject: Re: [PATCH v2] sched: fix first task of a task group is attached twice
Date: Thu, 26 May 2016 10:51:08 +0200 [thread overview]
Message-ID: <CAKfTPtDdBzO0TFgARXebFz3jFHnRGw8HYYuPtVgbGp938H-AWg@mail.gmail.com> (raw)
In-Reply-To: <20160526004046.GJ18670@intel.com>
On 26 May 2016 at 02:40, Yuyang Du <yuyang.du@intel.com> wrote:
> On Thu, May 26, 2016 at 10:26:54AM +0200, Vincent Guittot wrote:
>> On 26 May 2016 at 00:38, Yuyang Du <yuyang.du@intel.com> wrote:
>> > On Wed, May 25, 2016 at 05:01:11PM +0200, Vincent Guittot wrote:
>> >> The cfs_rq->avg.last_update_time is initialize to 0 with the main effect
>> >> that the 1st sched_entity that will be attached, will keep its
>> >> last_update_time set to 0 and will attached once again during the
>> >> enqueue.
>> >> Initialize cfs_rq->avg.last_update_time to 1 instead.
>> >
>> > Actually, the first time (attach_task_cfs_rq()) is called even way
>> > before init_entity_runnable_average(), no?
>>
>> maybe there is an issue during the fork of a task too
>> This patch is about the init of the sched_avg of a task group. The
>> problem happens when the 1st task is moved the group but it's not
>> about the fork of a task
>
> Right, but the root cause is not addressed, which is when forked, the task
> should not be touched on sched avgs before init_entity_runnable_average()
> in wake_up_new_task(). You think?
so yes, this patch doesn't not address the fact that sched avgs should
not be touch before init_entity_runnable_average(). This patch is only
about inti of sched_avg of task group
next prev parent reply other threads:[~2016-05-26 8:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 13:08 [PATCH] sched: fix first task of a task group is attached twice Vincent Guittot
2016-05-25 15:01 ` [PATCH v2] " Vincent Guittot
2016-05-25 22:38 ` Yuyang Du
2016-05-26 8:26 ` Vincent Guittot
2016-05-26 0:40 ` Yuyang Du
2016-05-26 8:51 ` Vincent Guittot [this message]
2016-05-27 15:48 ` Dietmar Eggemann
2016-05-27 17:16 ` Vincent Guittot
2016-05-27 20:38 ` Dietmar Eggemann
2016-05-30 7:04 ` Vincent Guittot
2016-05-30 15:52 ` [PATCH v3] " Vincent Guittot
2016-05-30 19:48 ` Yuyang Du
2016-05-31 7:28 ` Vincent Guittot
2016-05-31 0:44 ` Yuyang Du
2016-06-01 15:31 ` Dietmar Eggemann
2016-06-01 15:54 ` Vincent Guittot
2016-06-06 19:32 ` Dietmar Eggemann
2016-06-07 7:35 ` Vincent Guittot
2016-06-15 19:19 ` Yuyang Du
2016-06-16 7:12 ` Vincent Guittot
2016-06-15 23:24 ` Yuyang Du
2016-06-16 9:42 ` Vincent Guittot
2016-05-30 15:54 ` [PATCH v2] " Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKfTPtDdBzO0TFgARXebFz3jFHnRGw8HYYuPtVgbGp938H-AWg@mail.gmail.com \
--to=vincent.guittot@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).