linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers/net/fsl_ucc: Do not prefix header guard with CONFIG_
@ 2016-06-08  9:40 Andreas Ziegler
  2016-06-08 18:08 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Ziegler @ 2016-06-08  9:40 UTC (permalink / raw)
  To: Zhao Qiang
  Cc: netdev, linuxppc-dev, Valentin Rothberg, linux-kernel, Andreas Ziegler

The CONFIG_ prefix should only be used for options which
can be configured through Kconfig and not for guarding headers.

Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
---
 drivers/net/wan/fsl_ucc_hdlc.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wan/fsl_ucc_hdlc.h b/drivers/net/wan/fsl_ucc_hdlc.h
index 525786a..881ecde 100644
--- a/drivers/net/wan/fsl_ucc_hdlc.h
+++ b/drivers/net/wan/fsl_ucc_hdlc.h
@@ -8,8 +8,8 @@
  * option) any later version.
  */
 
-#ifndef CONFIG_UCC_HDLC_H
-#define CONFIG_UCC_HDLC_H
+#ifndef _UCC_HDLC_H_
+#define _UCC_HDLC_H_
 
 #include <linux/kernel.h>
 #include <linux/list.h>
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers/net/fsl_ucc: Do not prefix header guard with CONFIG_
  2016-06-08  9:40 [PATCH] drivers/net/fsl_ucc: Do not prefix header guard with CONFIG_ Andreas Ziegler
@ 2016-06-08 18:08 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-06-08 18:08 UTC (permalink / raw)
  To: andreas.ziegler
  Cc: qiang.zhao, netdev, linuxppc-dev, valentinrothberg, linux-kernel

From: Andreas Ziegler <andreas.ziegler@fau.de>
Date: Wed,  8 Jun 2016 11:40:28 +0200

> The CONFIG_ prefix should only be used for options which
> can be configured through Kconfig and not for guarding headers.
> 
> Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-08 18:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-08  9:40 [PATCH] drivers/net/fsl_ucc: Do not prefix header guard with CONFIG_ Andreas Ziegler
2016-06-08 18:08 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).