* [PATCH 1/2] [media] s5p-mfc: fix typo in s5p_mfc_dec function comment
@ 2016-06-09 1:57 Javier Martinez Canillas
2016-06-09 1:57 ` [PATCH 2/2] [media] s5p-mfc: don't print errors on VIDIOC_REQBUFS unsupported mem type Javier Martinez Canillas
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2016-06-09 1:57 UTC (permalink / raw)
To: linux-kernel
Cc: Luis de Bethencourt, Nicolas Dufresne, Shuah Khan,
Javier Martinez Canillas, Mauro Carvalho Chehab, Kamil Debski,
Jeongtae Park, Kyungmin Park, linux-arm-kernel, linux-media
The function comment has an obvious typo error, so fix it.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
index a01a373a4c4f..8e2ee1a0df2b 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
@@ -564,7 +564,7 @@ out:
return ret;
}
-/* Reqeust buffers */
+/* Request buffers */
static int vidioc_reqbufs(struct file *file, void *priv,
struct v4l2_requestbuffers *reqbufs)
{
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] [media] s5p-mfc: don't print errors on VIDIOC_REQBUFS unsupported mem type
2016-06-09 1:57 [PATCH 1/2] [media] s5p-mfc: fix typo in s5p_mfc_dec function comment Javier Martinez Canillas
@ 2016-06-09 1:57 ` Javier Martinez Canillas
0 siblings, 0 replies; 2+ messages in thread
From: Javier Martinez Canillas @ 2016-06-09 1:57 UTC (permalink / raw)
To: linux-kernel
Cc: Luis de Bethencourt, Nicolas Dufresne, Shuah Khan,
Javier Martinez Canillas, Mauro Carvalho Chehab, Kamil Debski,
Jeongtae Park, Kyungmin Park, linux-arm-kernel, linux-media
The V4L2 documentation says that applications must call the VIDIOC_REQBUFS
ioctl to determine if a memory mapped, user pointer or DMABUF based I/O is
supported by the driver.
For example GStreamer does this by first calling VIDIOC_REQBUFS with count
zero for all the possible streaming I/O methods and then finally doing the
real VIDIOC_REQBUFS with count N using a known to be supported memory type.
But the driver prints an error on VIDIOC_REQBUFS if the memory type is not
supported which leads to the following errors that can confuse the users:
[ 178.704390] vidioc_reqbufs:575: Only V4L2_MEMORY_MMAP is supported
[ 178.704666] vidioc_reqbufs:575: Only V4L2_MEMORY_MMAP is supported
[ 178.714956] vidioc_reqbufs:575: Only V4L2_MEMORY_MMAP is supported
[ 178.715229] vidioc_reqbufs:575: Only V4L2_MEMORY_MMAP is supported
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
index 8e2ee1a0df2b..038215c198ac 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
@@ -572,7 +572,7 @@ static int vidioc_reqbufs(struct file *file, void *priv,
struct s5p_mfc_ctx *ctx = fh_to_ctx(priv);
if (reqbufs->memory != V4L2_MEMORY_MMAP) {
- mfc_err("Only V4L2_MEMORY_MMAP is supported\n");
+ mfc_debug(2, "Only V4L2_MEMORY_MMAP is supported\n");
return -EINVAL;
}
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-09 1:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-09 1:57 [PATCH 1/2] [media] s5p-mfc: fix typo in s5p_mfc_dec function comment Javier Martinez Canillas
2016-06-09 1:57 ` [PATCH 2/2] [media] s5p-mfc: don't print errors on VIDIOC_REQBUFS unsupported mem type Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).