From: "Pali Rohár" <pali.rohar@gmail.com>
To: "Michał Kępień" <kernel@kempniu.pl>
Cc: Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Darren Hart <dvhart@infradead.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Bob Rodgers <Robert_Rodgers@dell.com>,
Louis Davis <Louis_Davis@dell.com>,
Jim Dailey <Jim_Dailey@dell.com>,
Alex Hung <alex.hung@canonical.com>,
Hui Wang <hui.wang@canonical.com>,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] ALSA: hda - use dell_micmute_led_set() instead of dell_app_wmi_led_set()
Date: Thu, 15 Dec 2016 16:43:00 +0100 [thread overview]
Message-ID: <1481816580.2090.5.camel@Pali-Nokia-N900> (raw)
In-Reply-To: <20161215144628.GB22695@kmp-mobile.hq.kempniu.pl>
On Thu Dec 15 15:46:28 2016 Michał Kępień <kernel@kempniu.pl> wrote:
> > On Thursday 08 December 2016 13:36:14 Michał Kępień wrote:
> > > --- a/sound/pci/hda/dell_wmi_helper.c
> > > +++ b/sound/pci/hda/dell_wmi_helper.c
> > > @@ -6,7 +6,7 @@
> > > #include <linux/dell-led.h>
> > >
> > > static int dell_led_value;
> > > -static int (*dell_led_set_func)(int, int);
> > > +static int (*dell_led_set_func)(int);
> >
> > Suggestion: what about changing name to dell_micmute_led_set_func to
> > match real function name which is used after this patch?
>
> While I like the idea itself, implementing it will double the number of
> lines that this patch changes (6 vs. 12), arguably making its intention
If some patch makes final result of code better then metric number of lines is not priority.
> less clear. Please let me know if you would really like this to happen
> (perhaps as a separate patch?), otherwise I will skip this idea in v2.
>
> --
> Best regards,
> Michał Kępień
If it will be in this or another following patch... I dot care. But this is sound subsystem, so sound maintainers need to decide what they prefer.
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2016-12-15 15:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161208123909epcas3p23229f5e0d337e19a27b272211798d364@epcas3p2.samsung.com>
2016-12-08 12:36 ` [PATCH 0/7] Move dell-led to drivers/platform/x86 Michał Kępień
2016-12-08 12:36 ` [PATCH 1/7] dell-led: remove GUID check from dell_micmute_led_set() Michał Kępień
2016-12-09 9:20 ` Pali Rohár
2016-12-15 14:34 ` Michał Kępień
2016-12-08 12:36 ` [PATCH 2/7] dell-led: export dell_micmute_led_set() Michał Kępień
2016-12-08 12:36 ` [PATCH 3/7] ALSA: hda - use dell_micmute_led_set() instead of dell_app_wmi_led_set() Michał Kępień
2016-12-11 10:40 ` Pali Rohár
2016-12-15 14:46 ` Michał Kępień
2016-12-15 15:43 ` Pali Rohár [this message]
2016-12-15 19:22 ` Michał Kępień
2017-01-09 13:26 ` Michał Kępień
2017-01-09 14:47 ` Takashi Iwai
2017-01-10 5:28 ` Michał Kępień
2016-12-08 12:36 ` [PATCH 4/7] dell-led: remove dell_app_wmi_led_set() Michał Kępień
2016-12-11 10:40 ` Pali Rohár
2016-12-14 1:54 ` Andy Shevchenko
2016-12-14 1:57 ` Andy Shevchenko
2016-12-15 14:48 ` Michał Kępień
2016-12-08 12:36 ` [PATCH 5/7] dell-laptop: import dell_micmute_led_set() from drivers/leds/dell-led.c Michał Kępień
2016-12-08 12:36 ` [PATCH 6/7] dell-led: remove code related to mic mute LED Michał Kępień
2016-12-08 12:36 ` [PATCH 7/7] dell-led: move driver to drivers/platform/x86/dell-wmi-led.c Michał Kępień
2016-12-14 2:05 ` Andy Shevchenko
2016-12-15 14:54 ` Michał Kępień
2016-12-08 14:26 ` [PATCH 0/7] Move dell-led to drivers/platform/x86 Jacek Anaszewski
2016-12-11 10:45 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481816580.2090.5.camel@Pali-Nokia-N900 \
--to=pali.rohar@gmail.com \
--cc=Jim_Dailey@dell.com \
--cc=Louis_Davis@dell.com \
--cc=Robert_Rodgers@dell.com \
--cc=alex.hung@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=dvhart@infradead.org \
--cc=hui.wang@canonical.com \
--cc=j.anaszewski@samsung.com \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=perex@perex.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).