From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: "Michał Kępień" <kernel@kempniu.pl>,
"Richard Purdie" <rpurdie@rpsys.net>,
"Jacek Anaszewski" <j.anaszewski@samsung.com>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Darren Hart" <dvhart@infradead.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Louis Davis" <Louis_Davis@dell.com>,
"Jim Dailey" <Jim_Dailey@dell.com>,
"Alex Hung" <alex.hung@canonical.com>,
"Hui Wang" <hui.wang@canonical.com>,
linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org,
"ALSA Development Mailing List" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set()
Date: Wed, 14 Dec 2016 03:57:48 +0200 [thread overview]
Message-ID: <CAHp75VcTSDOv4JK9Hr=GefWtOeYaQUFxTASwAeFJqM18BuU33w@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VfTLrY_MBphzg2idGhQbvnjyf7+9-BQjD37TXnucj+nMw@mail.gmail.com>
On Wed, Dec 14, 2016 at 3:54 AM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Sun, Dec 11, 2016 at 12:40 PM, Pali Rohár <pali.rohar@gmail.com> wrote:
>> On Thursday 08 December 2016 13:36:15 Michał Kępień wrote:
>>> All calls to dell_app_wmi_led_set() have been replaced with direct
>>> calls to dell_micmute_led_set(), so the former can be safely removed
>>> along with its related enum.
>>>
>>> Signed-off-by: Michał Kępień <kernel@kempniu.pl>
>>
>> I would suggest to squash patches 2,3,4 into one. But I let decision to
>> alsa & led maintainers.
>
> I don't like the part where we are exporting something for just one
> moment.
Oops, misread function name, though still valid vote for one patch.
> So, +1 to squashed version.
>
>>
>> Anyway, for patches 2,3,4 you can add my Reviewed-by. It is nice cleanup
>>
>> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2016-12-14 1:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161208123909epcas3p23229f5e0d337e19a27b272211798d364@epcas3p2.samsung.com>
2016-12-08 12:36 ` [PATCH 0/7] Move dell-led to drivers/platform/x86 Michał Kępień
2016-12-08 12:36 ` [PATCH 1/7] dell-led: remove GUID check from dell_micmute_led_set() Michał Kępień
2016-12-09 9:20 ` Pali Rohár
2016-12-15 14:34 ` Michał Kępień
2016-12-08 12:36 ` [PATCH 2/7] dell-led: export dell_micmute_led_set() Michał Kępień
2016-12-08 12:36 ` [PATCH 3/7] ALSA: hda - use dell_micmute_led_set() instead of dell_app_wmi_led_set() Michał Kępień
2016-12-11 10:40 ` Pali Rohár
2016-12-15 14:46 ` Michał Kępień
2016-12-15 15:43 ` Pali Rohár
2016-12-15 19:22 ` Michał Kępień
2017-01-09 13:26 ` Michał Kępień
2017-01-09 14:47 ` Takashi Iwai
2017-01-10 5:28 ` Michał Kępień
2016-12-08 12:36 ` [PATCH 4/7] dell-led: remove dell_app_wmi_led_set() Michał Kępień
2016-12-11 10:40 ` Pali Rohár
2016-12-14 1:54 ` Andy Shevchenko
2016-12-14 1:57 ` Andy Shevchenko [this message]
2016-12-15 14:48 ` Michał Kępień
2016-12-08 12:36 ` [PATCH 5/7] dell-laptop: import dell_micmute_led_set() from drivers/leds/dell-led.c Michał Kępień
2016-12-08 12:36 ` [PATCH 6/7] dell-led: remove code related to mic mute LED Michał Kępień
2016-12-08 12:36 ` [PATCH 7/7] dell-led: move driver to drivers/platform/x86/dell-wmi-led.c Michał Kępień
2016-12-14 2:05 ` Andy Shevchenko
2016-12-15 14:54 ` Michał Kępień
2016-12-08 14:26 ` [PATCH 0/7] Move dell-led to drivers/platform/x86 Jacek Anaszewski
2016-12-11 10:45 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcTSDOv4JK9Hr=GefWtOeYaQUFxTASwAeFJqM18BuU33w@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=Jim_Dailey@dell.com \
--cc=Louis_Davis@dell.com \
--cc=alex.hung@canonical.com \
--cc=alsa-devel@alsa-project.org \
--cc=dvhart@infradead.org \
--cc=hui.wang@canonical.com \
--cc=j.anaszewski@samsung.com \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=perex@perex.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).