* [PATCH] random: move random_min_urandom_seed into CONFIG_SYSCTL ifdef block
@ 2017-01-31 16:36 Fabio Estevam
2017-02-07 2:30 ` Theodore Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2017-01-31 16:36 UTC (permalink / raw)
To: tytso; +Cc: smueller, arnd, festevam, linux-kernel, Fabio Estevam
Building arm allnodefconfig causes the following build warning:
drivers/char/random.c:318:12: warning: 'random_min_urandom_seed' defined but not used [-Wunused-variable]
Fix the warning by moving 'random_min_urandom_seed' declaration inside
the CONFIG_SYSCTL ifdef block, where it is actually used.
While at it, remove the comment prior to the variable declaration.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
drivers/char/random.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 066ae12..0ab0249 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -313,11 +313,6 @@ static int random_read_wakeup_bits = 64;
static int random_write_wakeup_bits = 28 * OUTPUT_POOL_WORDS;
/*
- * Variable is currently unused by left for user space compatibility.
- */
-static int random_min_urandom_seed = 60;
-
-/*
* Originally, we used a primitive polynomial of degree .poolwords
* over GF(2). The taps for various sizes are defined below. They
* were chosen to be evenly spaced except for the last tap, which is 1
@@ -1886,6 +1881,7 @@ SYSCALL_DEFINE3(getrandom, char __user *, buf, size_t, count,
static int min_read_thresh = 8, min_write_thresh;
static int max_read_thresh = OUTPUT_POOL_WORDS * 32;
static int max_write_thresh = INPUT_POOL_WORDS * 32;
+static int random_min_urandom_seed = 60;
static char sysctl_bootid[16];
/*
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] random: move random_min_urandom_seed into CONFIG_SYSCTL ifdef block
2017-01-31 16:36 [PATCH] random: move random_min_urandom_seed into CONFIG_SYSCTL ifdef block Fabio Estevam
@ 2017-02-07 2:30 ` Theodore Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2017-02-07 2:30 UTC (permalink / raw)
To: Fabio Estevam; +Cc: smueller, arnd, festevam, linux-kernel
On Tue, Jan 31, 2017 at 02:36:07PM -0200, Fabio Estevam wrote:
> Building arm allnodefconfig causes the following build warning:
>
> drivers/char/random.c:318:12: warning: 'random_min_urandom_seed' defined but not used [-Wunused-variable]
>
> Fix the warning by moving 'random_min_urandom_seed' declaration inside
> the CONFIG_SYSCTL ifdef block, where it is actually used.
>
> While at it, remove the comment prior to the variable declaration.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-07 2:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-31 16:36 [PATCH] random: move random_min_urandom_seed into CONFIG_SYSCTL ifdef block Fabio Estevam
2017-02-07 2:30 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).