[PATCH 0/2] drm: meson: Fixup driver and module name

[PATCH 0/2] drm: meson: Fixup driver and module name

[Neil Armstrong]

This patchset is a simple fixup to rename the confusion possible
module and driver name "meson" to a more explicit "meson-drm" name.

Neil Armstrong (2):
  drm: meson: rename module name to meson-drm
  drm: meson: rename driver name to meson-drm

 drivers/gpu/drm/meson/Makefile    | 6 +++---
 drivers/gpu/drm/meson/meson_drv.c | 3 +--
 2 files changed, 4 insertions(+), 5 deletions(-)

-- 
1.9.1

[PATCH 1/2] drm: meson: rename module name to meson-drm

[Neil Armstrong]

The module is currently names "meson.ko" which can lead to some
confusion, this patches renames it "meson-drm.ko"

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/gpu/drm/meson/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/meson/Makefile b/drivers/gpu/drm/meson/Makefile
index 2591978..92cf845 100644
--- a/drivers/gpu/drm/meson/Makefile
+++ b/drivers/gpu/drm/meson/Makefile
@@ -1,4 +1,4 @@
-meson-y := meson_drv.o meson_plane.o meson_crtc.o meson_venc_cvbs.o
-meson-y += meson_viu.o meson_vpp.o meson_venc.o meson_vclk.o meson_canvas.o
+meson-drm-y := meson_drv.o meson_plane.o meson_crtc.o meson_venc_cvbs.o
+meson-drm-y += meson_viu.o meson_vpp.o meson_venc.o meson_vclk.o meson_canvas.o
 
-obj-$(CONFIG_DRM_MESON) += meson.o
+obj-$(CONFIG_DRM_MESON) += meson-drm.o
-- 
1.9.1

[PATCH 2/2] drm: meson: rename driver name to meson-drm

[Neil Armstrong]

The platform driver name is currently "meson" which can lead to some
confusion, this patch renames it to "meson-drm" and removes the owner
attribute.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/gpu/drm/meson/meson_drv.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
index ff1f601..380bde7 100644
--- a/drivers/gpu/drm/meson/meson_drv.c
+++ b/drivers/gpu/drm/meson/meson_drv.c
@@ -329,8 +329,7 @@ static int meson_drv_remove(struct platform_device *pdev)
 	.probe      = meson_drv_probe,
 	.remove     = meson_drv_remove,
 	.driver     = {
-		.owner  = THIS_MODULE,
-		.name   = DRIVER_NAME,
+		.name	= "meson-drm",
 		.of_match_table = dt_match,
 	},
 };
-- 
1.9.1

Re: [PATCH 2/2] drm: meson: rename driver name to meson-drm

[Daniel Vetter]

On Thu, Feb 02, 2017 at 10:47:44AM +0100, Neil Armstrong wrote:
> The platform driver name is currently "meson" which can lead to some
> confusion, this patch renames it to "meson-drm" and removes the owner
> attribute.
> 
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  drivers/gpu/drm/meson/meson_drv.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
> index ff1f601..380bde7 100644
> --- a/drivers/gpu/drm/meson/meson_drv.c
> +++ b/drivers/gpu/drm/meson/meson_drv.c
> @@ -329,8 +329,7 @@ static int meson_drv_remove(struct platform_device *pdev)
>  	.probe      = meson_drv_probe,
>  	.remove     = meson_drv_remove,
>  	.driver     = {
> -		.owner  = THIS_MODULE,

I don't get why you remove this, generally that will lead to trouble of
being able to unload code that's still in use ...

Otherwise ack.

Now, do you want to get this landed as part of the small drivers in
drm-mis experiment?
-Daniel

> -		.name   = DRIVER_NAME,
> +		.name	= "meson-drm",
>  		.of_match_table = dt_match,
>  	},
>  };
> -- 
> 1.9.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: [PATCH 2/2] drm: meson: rename driver name to meson-drm

[Neil Armstrong]

On 02/02/2017 11:45 AM, Daniel Vetter wrote:
> On Thu, Feb 02, 2017 at 10:47:44AM +0100, Neil Armstrong wrote:
>> The platform driver name is currently "meson" which can lead to some
>> confusion, this patch renames it to "meson-drm" and removes the owner
>> attribute.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>>  drivers/gpu/drm/meson/meson_drv.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
>> index ff1f601..380bde7 100644
>> --- a/drivers/gpu/drm/meson/meson_drv.c
>> +++ b/drivers/gpu/drm/meson/meson_drv.c
>> @@ -329,8 +329,7 @@ static int meson_drv_remove(struct platform_device *pdev)
>>  	.probe      = meson_drv_probe,
>>  	.remove     = meson_drv_remove,
>>  	.driver     = {
>> -		.owner  = THIS_MODULE,

Hi Daniel,

> I don't get why you remove this, generally that will lead to trouble of
> being able to unload code that's still in use ...

Indeed, but since a (long ?) time, the owner field is now populated by the
 platform_driver_register() core code.

> 
> Otherwise ack.
> 
> Now, do you want to get this landed as part of the small drivers in
> drm-mis experiment?

I have a PR ready, but it can go through this experiment, yes.

> -Daniel
> 
>> -		.name   = DRIVER_NAME,
>> +		.name	= "meson-drm",
>>  		.of_match_table = dt_match,
>>  	},
>>  };
>> -- 

Thanks,
Neil

Re: [PATCH 2/2] drm: meson: rename driver name to meson-drm

[Daniel Vetter]

On Thu, Feb 02, 2017 at 11:50:59AM +0100, Neil Armstrong wrote:
> On 02/02/2017 11:45 AM, Daniel Vetter wrote:
> > On Thu, Feb 02, 2017 at 10:47:44AM +0100, Neil Armstrong wrote:
> >> The platform driver name is currently "meson" which can lead to some
> >> confusion, this patch renames it to "meson-drm" and removes the owner
> >> attribute.
> >>
> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >> ---
> >>  drivers/gpu/drm/meson/meson_drv.c | 3 +--
> >>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
> >> index ff1f601..380bde7 100644
> >> --- a/drivers/gpu/drm/meson/meson_drv.c
> >> +++ b/drivers/gpu/drm/meson/meson_drv.c
> >> @@ -329,8 +329,7 @@ static int meson_drv_remove(struct platform_device *pdev)
> >>  	.probe      = meson_drv_probe,
> >>  	.remove     = meson_drv_remove,
> >>  	.driver     = {
> >> -		.owner  = THIS_MODULE,
> 
> Hi Daniel,
> 
> > I don't get why you remove this, generally that will lead to trouble of
> > being able to unload code that's still in use ...
> 
> Indeed, but since a (long ?) time, the owner field is now populated by the
>  platform_driver_register() core code.
> 
> > 
> > Otherwise ack.
> > 
> > Now, do you want to get this landed as part of the small drivers in
> > drm-mis experiment?
> 
> I have a PR ready, but it can go through this experiment, yes.

If you want to give it a spin, you need:
- fdo account https://www.freedesktop.org/wiki/AccountRequests/
- drm-misc group access
- dim set up for drm-misc, see
  https://01.org/linuxgraphics/gfx-docs/maintainer-tools/dim.html and
  https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html

For questions it's best to pipe up #dri-devel.

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch