From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Revert "lib/test_sort.c: make it explicitly non-modular"
Date: Tue, 28 Feb 2017 16:24:37 +0200 [thread overview]
Message-ID: <1488291877.20145.59.camel@linux.intel.com> (raw)
In-Reply-To: <1488287219-15832-2-git-send-email-geert@linux-m68k.org>
On Tue, 2017-02-28 at 14:06 +0100, Geert Uytterhoeven wrote:
> This reverts commit 8893f519330bb073a49c5b4676fce4be6f1be15d.
>
> It's very valuable to have modular tests, so you can run them just by
> insmodding the test modules, instead of needing a separate kernel that
> runs them at boot.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> lib/test_sort.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/lib/test_sort.c b/lib/test_sort.c
> index 4db3911db50ace76..d389c1cc2f6cf795 100644
> --- a/lib/test_sort.c
> +++ b/lib/test_sort.c
> @@ -1,11 +1,8 @@
> #include <linux/sort.h>
> #include <linux/slab.h>
> -#include <linux/init.h>
> +#include <linux/module.h>
>
>
> -/*
> - * A simple boot-time regression test
> - * License: GPL
> - */
> +/* a simple boot-time regression test */
I would leave this piece as is now.
The rest is okay.
>
> #define TEST_LEN 1000
>
> @@ -41,4 +38,6 @@ static int __init test_sort_init(void)
> kfree(a);
> return err;
> }
> -subsys_initcall(test_sort_init);
> +
> +module_init(test_sort_init);
> +MODULE_LICENSE("GPL");
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-02-28 14:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 13:06 [PATCH 0/3] lib: add module support to sort tests Geert Uytterhoeven
2017-02-28 13:06 ` [PATCH 1/3] Revert "lib/test_sort.c: make it explicitly non-modular" Geert Uytterhoeven
2017-02-28 14:24 ` Andy Shevchenko [this message]
2017-02-28 15:24 ` Geert Uytterhoeven
2017-02-28 13:06 ` [PATCH 2/3] lib: add module support to array-based sort tests Geert Uytterhoeven
2017-02-28 13:06 ` [PATCH 3/3] lib: add module support to linked list sorting tests Geert Uytterhoeven
2017-02-28 14:28 ` Arnd Bergmann
2017-02-28 14:43 ` Geert Uytterhoeven
2017-02-28 14:28 ` [PATCH 0/3] lib: add module support to sort tests Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488291877.20145.59.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).