From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Shuah Khan <shuah@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] lib: add module support to linked list sorting tests
Date: Tue, 28 Feb 2017 15:43:29 +0100 [thread overview]
Message-ID: <CAMuHMdXaE4Bx3cRvu1-Y+YUvbVVf0qbTfmMZvTH65f2v1Ts2tQ@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a1e9OZpA6SxDLoaYEUJaR8d_OAr4ai5P2m8kPO7n8THCw@mail.gmail.com>
Hi Arnd,
On Tue, Feb 28, 2017 at 3:28 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Feb 28, 2017 at 2:06 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index 90b2348777495b72..32363ae022e3282a 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -1731,11 +1731,12 @@ config LKDTM
>> Documentation/fault-injection/provoke-crashes.txt
>>
>> config TEST_LIST_SORT
>> - bool "Linked list sorting test"
>> - depends on DEBUG_KERNEL
>> + tristate "Linked list sorting test"
>> + depends on DEBUG_KERNEL || m
>
> I don't see any other test code with a "DEBUG_KERNEL || m" dependency,
> but several that are "DEBUG_KERNEL && m". Maybe we should just
> force it to be a module like the others? If there are good reasons to
> have it built-in, I'd just drop the "|| m" here.
Some people want to run all tests at boot time, so forcing the test to be
modular breaks that.
I used "|| m" as I like to enable all tests as modules, even when not
using DEBUG_KERNEL.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2017-02-28 14:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 13:06 [PATCH 0/3] lib: add module support to sort tests Geert Uytterhoeven
2017-02-28 13:06 ` [PATCH 1/3] Revert "lib/test_sort.c: make it explicitly non-modular" Geert Uytterhoeven
2017-02-28 14:24 ` Andy Shevchenko
2017-02-28 15:24 ` Geert Uytterhoeven
2017-02-28 13:06 ` [PATCH 2/3] lib: add module support to array-based sort tests Geert Uytterhoeven
2017-02-28 13:06 ` [PATCH 3/3] lib: add module support to linked list sorting tests Geert Uytterhoeven
2017-02-28 14:28 ` Arnd Bergmann
2017-02-28 14:43 ` Geert Uytterhoeven [this message]
2017-02-28 14:28 ` [PATCH 0/3] lib: add module support to sort tests Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXaE4Bx3cRvu1-Y+YUvbVVf0qbTfmMZvTH65f2v1Ts2tQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).