* [PATCH net-next 0/2] netvsc: Fix miscellaneous issues
@ 2017-03-25 3:54 kys
2017-03-25 3:54 ` [PATCH net-next 1/2] netvsc: Fix a bug in sub-channel handling kys
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: kys @ 2017-03-25 3:54 UTC (permalink / raw)
To: davem, netdev, linux-kernel, devel, olaf, apw, jasowang,
leann.ogasawara, marcelo.cerri, sthemmin
Cc: K. Y. Srinivasan
From: K. Y. Srinivasan <kys@microsoft.com>
Fix miscellaneous issues.
K. Y. Srinivasan (2):
netvsc: Fix a bug in sub-channel handling
netvsc: Properly initialize the return value
drivers/net/hyperv/netvsc_drv.c | 2 +-
drivers/net/hyperv/rndis_filter.c | 5 +++++
2 files changed, 6 insertions(+), 1 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next 1/2] netvsc: Fix a bug in sub-channel handling
2017-03-25 3:54 [PATCH net-next 0/2] netvsc: Fix miscellaneous issues kys
@ 2017-03-25 3:54 ` kys
2017-03-25 3:54 ` [PATCH net-next 2/2] netvsc: Properly initialize the return value kys
2017-03-26 3:16 ` [PATCH net-next 0/2] netvsc: Fix miscellaneous issues David Miller
2 siblings, 0 replies; 4+ messages in thread
From: kys @ 2017-03-25 3:54 UTC (permalink / raw)
To: davem, netdev, linux-kernel, devel, olaf, apw, jasowang,
leann.ogasawara, marcelo.cerri, sthemmin
Cc: K. Y. Srinivasan
From: K. Y. Srinivasan <kys@microsoft.com>
All netvsc channels are handled via NAPI. Setup the "read mode" correctly
for the netvsc sub-channels.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/net/hyperv/rndis_filter.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index 91b3bcf..9835825 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -1002,6 +1002,11 @@ static void netvsc_sc_open(struct vmbus_channel *new_sc)
if (!nvchan->mrc.buf)
return;
+ /* Because the device uses NAPI, all the interrupt batching and
+ * control is done via Net softirq, not the channel handling
+ */
+ set_channel_read_mode(new_sc, HV_CALL_ISR);
+
ret = vmbus_open(new_sc, nvscdev->ring_size * PAGE_SIZE,
nvscdev->ring_size * PAGE_SIZE, NULL, 0,
netvsc_channel_cb, nvchan);
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net-next 2/2] netvsc: Properly initialize the return value
2017-03-25 3:54 [PATCH net-next 0/2] netvsc: Fix miscellaneous issues kys
2017-03-25 3:54 ` [PATCH net-next 1/2] netvsc: Fix a bug in sub-channel handling kys
@ 2017-03-25 3:54 ` kys
2017-03-26 3:16 ` [PATCH net-next 0/2] netvsc: Fix miscellaneous issues David Miller
2 siblings, 0 replies; 4+ messages in thread
From: kys @ 2017-03-25 3:54 UTC (permalink / raw)
To: davem, netdev, linux-kernel, devel, olaf, apw, jasowang,
leann.ogasawara, marcelo.cerri, sthemmin
Cc: K. Y. Srinivasan
From: K. Y. Srinivasan <kys@microsoft.com>
Initialize the return value correctly.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/net/hyperv/netvsc_drv.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index eb7ae79..f830bbb 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -855,7 +855,7 @@ static int netvsc_change_mtu(struct net_device *ndev, int mtu)
struct hv_device *hdev = ndevctx->device_ctx;
struct netvsc_device_info device_info;
bool was_running;
- int ret;
+ int ret = 0;
if (!nvdev || nvdev->destroy)
return -ENODEV;
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next 0/2] netvsc: Fix miscellaneous issues
2017-03-25 3:54 [PATCH net-next 0/2] netvsc: Fix miscellaneous issues kys
2017-03-25 3:54 ` [PATCH net-next 1/2] netvsc: Fix a bug in sub-channel handling kys
2017-03-25 3:54 ` [PATCH net-next 2/2] netvsc: Properly initialize the return value kys
@ 2017-03-26 3:16 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2017-03-26 3:16 UTC (permalink / raw)
To: kys, kys
Cc: netdev, linux-kernel, devel, olaf, apw, jasowang,
leann.ogasawara, marcelo.cerri, sthemmin
From: kys@exchange.microsoft.com
Date: Fri, 24 Mar 2017 20:54:08 -0700
> Fix miscellaneous issues.
Series applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-26 3:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-25 3:54 [PATCH net-next 0/2] netvsc: Fix miscellaneous issues kys
2017-03-25 3:54 ` [PATCH net-next 1/2] netvsc: Fix a bug in sub-channel handling kys
2017-03-25 3:54 ` [PATCH net-next 2/2] netvsc: Properly initialize the return value kys
2017-03-26 3:16 ` [PATCH net-next 0/2] netvsc: Fix miscellaneous issues David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).