* [PATCH] infiniband: hw: qedr: add null check before pointer dereference
@ 2017-05-22 18:30 Gustavo A. R. Silva
2017-05-23 7:13 ` Leon Romanovsky
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2017-05-22 18:30 UTC (permalink / raw)
To: Doug Ledford, Sean Hefty, Hal Rosenstock
Cc: linux-rdma, linux-kernel, Gustavo A. R. Silva
Add null check before dereferencing pointer sgid_attr.ndev
inside function rdma_vlan_dev_vlan_id().
Addresses-Coverity-ID: 1373979
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/infiniband/hw/qedr/qedr_cm.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/qedr/qedr_cm.c b/drivers/infiniband/hw/qedr/qedr_cm.c
index 3d7705c..d86dbe8 100644
--- a/drivers/infiniband/hw/qedr/qedr_cm.c
+++ b/drivers/infiniband/hw/qedr/qedr_cm.c
@@ -270,11 +270,13 @@ static inline int qedr_gsi_build_header(struct qedr_dev *dev,
return rc;
}
- vlan_id = rdma_vlan_dev_vlan_id(sgid_attr.ndev);
- if (vlan_id < VLAN_CFI_MASK)
- has_vlan = true;
- if (sgid_attr.ndev)
+ if (sgid_attr.ndev) {
+ vlan_id = rdma_vlan_dev_vlan_id(sgid_attr.ndev);
+ if (vlan_id < VLAN_CFI_MASK)
+ has_vlan = true;
+
dev_put(sgid_attr.ndev);
+ }
if (!memcmp(&sgid, &zgid, sizeof(sgid))) {
DP_ERR(dev, "gsi post send: GID not found GID index %d\n",
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] infiniband: hw: qedr: add null check before pointer dereference
2017-05-22 18:30 [PATCH] infiniband: hw: qedr: add null check before pointer dereference Gustavo A. R. Silva
@ 2017-05-23 7:13 ` Leon Romanovsky
2017-05-23 15:03 ` Amrani, Ram
2017-05-23 15:09 ` Amrani, Ram
2017-06-01 22:32 ` Doug Ledford
2 siblings, 1 reply; 5+ messages in thread
From: Leon Romanovsky @ 2017-05-23 7:13 UTC (permalink / raw)
To: Gustavo A. R. Silva, Ram Amrani
Cc: Doug Ledford, Sean Hefty, Hal Rosenstock, linux-rdma, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1377 bytes --]
On Mon, May 22, 2017 at 01:30:15PM -0500, Gustavo A. R. Silva wrote:
> Add null check before dereferencing pointer sgid_attr.ndev
> inside function rdma_vlan_dev_vlan_id().
>
> Addresses-Coverity-ID: 1373979
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/infiniband/hw/qedr/qedr_cm.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
+ Ram,
Ram, IB part of qedr driver doesn't exist in MAINTAINERS file.
>
> diff --git a/drivers/infiniband/hw/qedr/qedr_cm.c b/drivers/infiniband/hw/qedr/qedr_cm.c
> index 3d7705c..d86dbe8 100644
> --- a/drivers/infiniband/hw/qedr/qedr_cm.c
> +++ b/drivers/infiniband/hw/qedr/qedr_cm.c
> @@ -270,11 +270,13 @@ static inline int qedr_gsi_build_header(struct qedr_dev *dev,
> return rc;
> }
>
> - vlan_id = rdma_vlan_dev_vlan_id(sgid_attr.ndev);
> - if (vlan_id < VLAN_CFI_MASK)
> - has_vlan = true;
> - if (sgid_attr.ndev)
> + if (sgid_attr.ndev) {
> + vlan_id = rdma_vlan_dev_vlan_id(sgid_attr.ndev);
> + if (vlan_id < VLAN_CFI_MASK)
> + has_vlan = true;
> +
> dev_put(sgid_attr.ndev);
> + }
I do agree that it is better than kernel panic trying to access NULL
pointer, but I'm not sure that retaining default vlan_id = 0 is correct
solution here.
>
> if (!memcmp(&sgid, &zgid, sizeof(sgid))) {
> DP_ERR(dev, "gsi post send: GID not found GID index %d\n",
> --
> 2.5.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] infiniband: hw: qedr: add null check before pointer dereference
2017-05-23 7:13 ` Leon Romanovsky
@ 2017-05-23 15:03 ` Amrani, Ram
0 siblings, 0 replies; 5+ messages in thread
From: Amrani, Ram @ 2017-05-23 15:03 UTC (permalink / raw)
To: Leon Romanovsky, Gustavo A. R. Silva
Cc: Doug Ledford, Sean Hefty, Hal Rosenstock, linux-rdma, linux-kernel
> + Ram,
>
> Ram, IB part of qedr driver doesn't exist in MAINTAINERS file.
>
Weird. I'll fix it.
Thanks,
Ram
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] infiniband: hw: qedr: add null check before pointer dereference
2017-05-22 18:30 [PATCH] infiniband: hw: qedr: add null check before pointer dereference Gustavo A. R. Silva
2017-05-23 7:13 ` Leon Romanovsky
@ 2017-05-23 15:09 ` Amrani, Ram
2017-06-01 22:32 ` Doug Ledford
2 siblings, 0 replies; 5+ messages in thread
From: Amrani, Ram @ 2017-05-23 15:09 UTC (permalink / raw)
To: Gustavo A. R. Silva, Doug Ledford, Sean Hefty, Hal Rosenstock
Cc: linux-rdma, linux-kernel
> Add null check before dereferencing pointer sgid_attr.ndev
> inside function rdma_vlan_dev_vlan_id().
>
> Addresses-Coverity-ID: 1373979
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/infiniband/hw/qedr/qedr_cm.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/hw/qedr/qedr_cm.c b/drivers/infiniband/hw/qedr/qedr_cm.c
> index 3d7705c..d86dbe8 100644
> --- a/drivers/infiniband/hw/qedr/qedr_cm.c
> +++ b/drivers/infiniband/hw/qedr/qedr_cm.c
> @@ -270,11 +270,13 @@ static inline int qedr_gsi_build_header(struct qedr_dev *dev,
> return rc;
> }
>
> - vlan_id = rdma_vlan_dev_vlan_id(sgid_attr.ndev);
> - if (vlan_id < VLAN_CFI_MASK)
> - has_vlan = true;
> - if (sgid_attr.ndev)
> + if (sgid_attr.ndev) {
> + vlan_id = rdma_vlan_dev_vlan_id(sgid_attr.ndev);
> + if (vlan_id < VLAN_CFI_MASK)
> + has_vlan = true;
> +
> dev_put(sgid_attr.ndev);
> + }
>
> if (!memcmp(&sgid, &zgid, sizeof(sgid))) {
> DP_ERR(dev, "gsi post send: GID not found GID index %d\n",
> --
> 2.5.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks.
Acked-by: Ram Amrani <Ram.Amrani@cavium.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] infiniband: hw: qedr: add null check before pointer dereference
2017-05-22 18:30 [PATCH] infiniband: hw: qedr: add null check before pointer dereference Gustavo A. R. Silva
2017-05-23 7:13 ` Leon Romanovsky
2017-05-23 15:09 ` Amrani, Ram
@ 2017-06-01 22:32 ` Doug Ledford
2 siblings, 0 replies; 5+ messages in thread
From: Doug Ledford @ 2017-06-01 22:32 UTC (permalink / raw)
To: Gustavo A. R. Silva, Sean Hefty, Hal Rosenstock; +Cc: linux-rdma, linux-kernel
On Mon, 2017-05-22 at 13:30 -0500, Gustavo A. R. Silva wrote:
> Add null check before dereferencing pointer sgid_attr.ndev
> inside function rdma_vlan_dev_vlan_id().
>
> Addresses-Coverity-ID: 1373979
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-01 22:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-22 18:30 [PATCH] infiniband: hw: qedr: add null check before pointer dereference Gustavo A. R. Silva
2017-05-23 7:13 ` Leon Romanovsky
2017-05-23 15:03 ` Amrani, Ram
2017-05-23 15:09 ` Amrani, Ram
2017-06-01 22:32 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).