From: Weilong Chen <chenweilong@huawei.com>
To: <minyard@acm.org>
Cc: <openipmi-developer@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] ipmi: fix unsigned long overflow
Date: Sat, 29 Jul 2017 10:42:41 +0800 [thread overview]
Message-ID: <1501296161-74544-1-git-send-email-chenweilong@huawei.com> (raw)
When I set the timeout to a specific value such as 500ms, the timeout
event will not happen in time due to the overflow in function
check_msg_timeout:
...
ent->timeout -= timeout_period;
if (ent->timeout > 0)
return;
...
The type of timeout_period is long, but ent->timeout is unsigned long.
This patch makes the type consistent.
Signed-off-by: Weilong Chen <chenweilong@huawei.com>
---
drivers/char/ipmi/ipmi_msghandler.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index 810b138..4c806e9 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -135,8 +135,8 @@ struct seq_table {
unsigned int inuse : 1;
unsigned int broadcast : 1;
- unsigned long timeout;
- unsigned long orig_timeout;
+ long timeout;
+ long orig_timeout;
unsigned int retries_left;
/*
--
1.8.3.1
next reply other threads:[~2017-07-29 2:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-29 2:42 Weilong Chen [this message]
2017-07-30 2:20 ` [PATCH] ipmi: fix unsigned long underflow minyard
2017-08-07 8:41 ` Weilong Chen
2017-08-07 12:24 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501296161-74544-1-git-send-email-chenweilong@huawei.com \
--to=chenweilong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).