From: Weilong Chen <chenweilong@huawei.com>
To: <minyard@acm.org>
Cc: <openipmi-developer@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>,
Corey Minyard <cminyard@mvista.com>
Subject: Re: [PATCH] ipmi: fix unsigned long underflow
Date: Mon, 7 Aug 2017 16:41:09 +0800 [thread overview]
Message-ID: <a9041220-3d5c-b83e-7255-3d54d87a4e69@huawei.com> (raw)
In-Reply-To: <1501381228-30958-1-git-send-email-minyard@acm.org>
Hi Minyard,
I test this patch, it works.
Thanks.
On 2017/7/30 10:20, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> When I set the timeout to a specific value such as 500ms, the timeout
> event will not happen in time due to the overflow in function
> check_msg_timeout:
> ...
> ent->timeout -= timeout_period;
> if (ent->timeout > 0)
> return;
> ...
>
> The type of timeout_period is long, but ent->timeout is unsigned long.
> This patch makes the type consistent.
>
> Reported-by: Weilong Chen <chenweilong@huawei.com>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> ---
> I like to keep things consistent (though I obviously messed up here)
> and keep variables that should be positive unsigned.
>
> But you are right, there is a bug here and some inconsistency.
> This patch changes timeout_period to be unsigned and fixes the
> check. Can you try this out?
>
> drivers/char/ipmi/ipmi_msghandler.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 810b138..c82d9fd 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -4030,7 +4030,8 @@ smi_from_recv_msg(ipmi_smi_t intf, struct ipmi_recv_msg *recv_msg,
> }
>
> static void check_msg_timeout(ipmi_smi_t intf, struct seq_table *ent,
> - struct list_head *timeouts, long timeout_period,
> + struct list_head *timeouts,
> + unsigned long timeout_period,
> int slot, unsigned long *flags,
> unsigned int *waiting_msgs)
> {
> @@ -4043,8 +4044,8 @@ static void check_msg_timeout(ipmi_smi_t intf, struct seq_table *ent,
> if (!ent->inuse)
> return;
>
> - ent->timeout -= timeout_period;
> - if (ent->timeout > 0) {
> + if (timeout_period < ent->timeout) {
> + ent->timeout -= timeout_period;
> (*waiting_msgs)++;
> return;
> }
> @@ -4110,7 +4111,8 @@ static void check_msg_timeout(ipmi_smi_t intf, struct seq_table *ent,
> }
> }
>
> -static unsigned int ipmi_timeout_handler(ipmi_smi_t intf, long timeout_period)
> +static unsigned int ipmi_timeout_handler(ipmi_smi_t intf,
> + unsigned long timeout_period)
> {
> struct list_head timeouts;
> struct ipmi_recv_msg *msg, *msg2;
>
next prev parent reply other threads:[~2017-08-07 8:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-29 2:42 [PATCH] ipmi: fix unsigned long overflow Weilong Chen
2017-07-30 2:20 ` [PATCH] ipmi: fix unsigned long underflow minyard
2017-08-07 8:41 ` Weilong Chen [this message]
2017-08-07 12:24 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9041220-3d5c-b83e-7255-3d54d87a4e69@huawei.com \
--to=chenweilong@huawei.com \
--cc=cminyard@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).