* [PATCH] arm: dts: ls1021a: add "fsl,ls1021a-esdhc" compatible string to esdhc node
@ 2017-11-13 14:39 Rasmus Villemoes
2017-11-13 15:16 ` [PATCH] arm: dts: ls1021a: add "fsl, ls1021a-esdhc" " Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Rasmus Villemoes @ 2017-11-13 14:39 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Russell King
Cc: Rasmus Villemoes, devicetree, linux-arm-kernel, linux-kernel
Commit a22950c888e3 (mmc: sdhci-of-esdhc: add quirk
SDHCI_QUIRK_BROKEN_TIMEOUT_VAL for ls1021a) added logic to the driver to
enable the broken timeout val quirk for ls1021a, but did not add the
corresponding compatible string to the device tree, so it didn't really
have any effect. Fix that.
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
arch/arm/boot/dts/ls1021a.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index 3ff2b8a9f01a..9cdec545decc 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -162,7 +162,7 @@
};
esdhc: esdhc@1560000 {
- compatible = "fsl,esdhc";
+ compatible = "fsl,ls1021a-esdhc", "fsl,esdhc";
reg = <0x0 0x1560000 0x0 0x10000>;
interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
clock-frequency = <0>;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arm: dts: ls1021a: add "fsl, ls1021a-esdhc" compatible string to esdhc node
2017-11-13 14:39 [PATCH] arm: dts: ls1021a: add "fsl,ls1021a-esdhc" compatible string to esdhc node Rasmus Villemoes
@ 2017-11-13 15:16 ` Fabio Estevam
2017-11-16 11:53 ` Fabio Estevam
2017-11-16 12:15 ` [PATCH resend] arm: dts: ls1021a: add "fsl,ls1021a-esdhc" " Rasmus Villemoes
2 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2017-11-13 15:16 UTC (permalink / raw)
To: Rasmus Villemoes
Cc: Rob Herring, Mark Rutland, Russell King, devicetree,
linux-kernel, linux-arm-kernel
On Mon, Nov 13, 2017 at 12:39 PM, Rasmus Villemoes
<rasmus.villemoes@prevas.dk> wrote:
> Commit a22950c888e3 (mmc: sdhci-of-esdhc: add quirk
> SDHCI_QUIRK_BROKEN_TIMEOUT_VAL for ls1021a) added logic to the driver to
> enable the broken timeout val quirk for ls1021a, but did not add the
> corresponding compatible string to the device tree, so it didn't really
> have any effect. Fix that.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm: dts: ls1021a: add "fsl, ls1021a-esdhc" compatible string to esdhc node
2017-11-13 14:39 [PATCH] arm: dts: ls1021a: add "fsl,ls1021a-esdhc" compatible string to esdhc node Rasmus Villemoes
2017-11-13 15:16 ` [PATCH] arm: dts: ls1021a: add "fsl, ls1021a-esdhc" " Fabio Estevam
@ 2017-11-16 11:53 ` Fabio Estevam
2017-11-16 12:15 ` [PATCH resend] arm: dts: ls1021a: add "fsl,ls1021a-esdhc" " Rasmus Villemoes
2 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2017-11-16 11:53 UTC (permalink / raw)
To: Rasmus Villemoes
Cc: Rob Herring, Mark Rutland, Russell King, devicetree,
linux-kernel, linux-arm-kernel, Shawn Guo
Rasmus,
On Mon, Nov 13, 2017 at 12:39 PM, Rasmus Villemoes
<rasmus.villemoes@prevas.dk> wrote:
> Commit a22950c888e3 (mmc: sdhci-of-esdhc: add quirk
> SDHCI_QUIRK_BROKEN_TIMEOUT_VAL for ls1021a) added logic to the driver to
> enable the broken timeout val quirk for ls1021a, but did not add the
> corresponding compatible string to the device tree, so it didn't really
> have any effect. Fix that.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Please resend it with Shawn Guo on Cc. Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH resend] arm: dts: ls1021a: add "fsl,ls1021a-esdhc" compatible string to esdhc node
2017-11-13 14:39 [PATCH] arm: dts: ls1021a: add "fsl,ls1021a-esdhc" compatible string to esdhc node Rasmus Villemoes
2017-11-13 15:16 ` [PATCH] arm: dts: ls1021a: add "fsl, ls1021a-esdhc" " Fabio Estevam
2017-11-16 11:53 ` Fabio Estevam
@ 2017-11-16 12:15 ` Rasmus Villemoes
2017-11-17 12:56 ` [PATCH resend] arm: dts: ls1021a: add "fsl, ls1021a-esdhc" " Shawn Guo
2 siblings, 1 reply; 5+ messages in thread
From: Rasmus Villemoes @ 2017-11-16 12:15 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Russell King
Cc: Rasmus Villemoes, Shawn Guo, yinbo.zhu, Fabio Estevam,
devicetree, linux-arm-kernel, linux-kernel
Commit a22950c888e3 (mmc: sdhci-of-esdhc: add quirk
SDHCI_QUIRK_BROKEN_TIMEOUT_VAL for ls1021a) added logic to the driver to
enable the broken timeout val quirk for ls1021a, but did not add the
corresponding compatible string to the device tree, so it didn't really
have any effect. Fix that.
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
Resending with Shawn Guo, Yinbo Zhu and Fabio Estevam on Cc in
addition to those generated by get_maintainer.pl.
arch/arm/boot/dts/ls1021a.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index 3ff2b8a9f01a..9cdec545decc 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -162,7 +162,7 @@
};
esdhc: esdhc@1560000 {
- compatible = "fsl,esdhc";
+ compatible = "fsl,ls1021a-esdhc", "fsl,esdhc";
reg = <0x0 0x1560000 0x0 0x10000>;
interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
clock-frequency = <0>;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH resend] arm: dts: ls1021a: add "fsl, ls1021a-esdhc" compatible string to esdhc node
2017-11-16 12:15 ` [PATCH resend] arm: dts: ls1021a: add "fsl,ls1021a-esdhc" " Rasmus Villemoes
@ 2017-11-17 12:56 ` Shawn Guo
0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2017-11-17 12:56 UTC (permalink / raw)
To: Rasmus Villemoes
Cc: Rob Herring, Mark Rutland, Russell King, devicetree,
linux-kernel, yinbo.zhu, Fabio Estevam, linux-arm-kernel
On Thu, Nov 16, 2017 at 01:15:26PM +0100, Rasmus Villemoes wrote:
> Commit a22950c888e3 (mmc: sdhci-of-esdhc: add quirk
> SDHCI_QUIRK_BROKEN_TIMEOUT_VAL for ls1021a) added logic to the driver to
> enable the broken timeout val quirk for ls1021a, but did not add the
> corresponding compatible string to the device tree, so it didn't really
> have any effect. Fix that.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-17 12:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-13 14:39 [PATCH] arm: dts: ls1021a: add "fsl,ls1021a-esdhc" compatible string to esdhc node Rasmus Villemoes
2017-11-13 15:16 ` [PATCH] arm: dts: ls1021a: add "fsl, ls1021a-esdhc" " Fabio Estevam
2017-11-16 11:53 ` Fabio Estevam
2017-11-16 12:15 ` [PATCH resend] arm: dts: ls1021a: add "fsl,ls1021a-esdhc" " Rasmus Villemoes
2017-11-17 12:56 ` [PATCH resend] arm: dts: ls1021a: add "fsl, ls1021a-esdhc" " Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).