* [PATCH] clk: sunxi: Use PTR_ERR_OR_ZERO()
@ 2017-11-29 16:15 Vasyl Gomonovych
2017-11-30 15:34 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Vasyl Gomonovych @ 2017-11-29 16:15 UTC (permalink / raw)
To: linux-clk, linux-arm-kernel
Cc: Vasyl Gomonovych, Emilio López, Michael Turquette,
Stephen Boyd, Maxime Ripard, Chen-Yu Tsai, linux-kernel
Fix ptr_ret.cocci warnings:
drivers/clk/sunxi/clk-sun8i-apb0.c:101:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/clk/sunxi/clk-sun8i-apb0.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/clk/sunxi/clk-sun8i-apb0.c b/drivers/clk/sunxi/clk-sun8i-apb0.c
index ea1eed24778c..d5c31804ee54 100644
--- a/drivers/clk/sunxi/clk-sun8i-apb0.c
+++ b/drivers/clk/sunxi/clk-sun8i-apb0.c
@@ -98,10 +98,7 @@ static int sun8i_a23_apb0_clk_probe(struct platform_device *pdev)
return PTR_ERR(reg);
clk = sun8i_a23_apb0_register(np, reg);
- if (IS_ERR(clk))
- return PTR_ERR(clk);
-
- return 0;
+ return PTR_ERR_OR_ZERO(clk);
}
static const struct of_device_id sun8i_a23_apb0_clk_dt_ids[] = {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: sunxi: Use PTR_ERR_OR_ZERO()
2017-11-29 16:15 [PATCH] clk: sunxi: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
@ 2017-11-30 15:34 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2017-11-30 15:34 UTC (permalink / raw)
To: Vasyl Gomonovych
Cc: linux-clk, linux-arm-kernel, Emilio López,
Michael Turquette, Stephen Boyd, Chen-Yu Tsai, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
On Wed, Nov 29, 2017 at 05:15:43PM +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/clk/sunxi/clk-sun8i-apb0.c:101:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-30 15:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-29 16:15 [PATCH] clk: sunxi: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-11-30 15:34 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).