linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] selftests/net: Fix permissions for fib_tests.sh
@ 2018-06-19 16:20 Daniel Díaz
  2018-06-26 18:22 ` Shuah Khan
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Díaz @ 2018-06-19 16:20 UTC (permalink / raw)
  To: shuahkh, linux-kselftest
  Cc: Daniel Díaz, David S. Miller, Shuah Khan,
	open list:NETWORKING [GENERAL],
	open list

fib_tests.sh became non-executable at some point. This is
what happens:
  selftests: net: fib_tests.sh: Warning: file fib_tests.sh is
  not executable, correct this.
  not ok 1..11 selftests: net: fib_tests.sh [FAIL]

Fixes: d69faad76584 ("selftests: fib_tests: Add prefix route tests with metric")

Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
---
 tools/testing/selftests/net/fib_tests.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/net/fib_tests.sh

diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh
old mode 100644
new mode 100755
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] selftests/net: Fix permissions for fib_tests.sh
  2018-06-19 16:20 [PATCH] selftests/net: Fix permissions for fib_tests.sh Daniel Díaz
@ 2018-06-26 18:22 ` Shuah Khan
  2018-06-28  7:15   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Shuah Khan @ 2018-06-26 18:22 UTC (permalink / raw)
  To: Daniel Díaz, shuahkh, linux-kselftest, David S. Miller
  Cc: open list:NETWORKING [GENERAL], open list, Shuah Khan

On 06/19/2018 10:20 AM, Daniel Díaz wrote:
> fib_tests.sh became non-executable at some point. This is
> what happens:
>   selftests: net: fib_tests.sh: Warning: file fib_tests.sh is
>   not executable, correct this.
>   not ok 1..11 selftests: net: fib_tests.sh [FAIL]
> 
> Fixes: d69faad76584 ("selftests: fib_tests: Add prefix route tests with metric")
> 
> Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
> ---
>  tools/testing/selftests/net/fib_tests.sh | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 tools/testing/selftests/net/fib_tests.sh
> 
> diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh
> old mode 100644
> new mode 100755
> 

Hi David,

Are you planning to pick this up for 4.18-rc3 or later?

Acked-by: Shuah Khan <shuah@kernel.org>

thanks,
-- Shuah

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] selftests/net: Fix permissions for fib_tests.sh
  2018-06-26 18:22 ` Shuah Khan
@ 2018-06-28  7:15   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2018-06-28  7:15 UTC (permalink / raw)
  To: shuah; +Cc: daniel.diaz, shuahkh, linux-kselftest, netdev, linux-kernel

From: Shuah Khan <shuah@kernel.org>
Date: Tue, 26 Jun 2018 12:22:28 -0600

> On 06/19/2018 10:20 AM, Daniel Díaz wrote:
>> fib_tests.sh became non-executable at some point. This is
>> what happens:
>>   selftests: net: fib_tests.sh: Warning: file fib_tests.sh is
>>   not executable, correct this.
>>   not ok 1..11 selftests: net: fib_tests.sh [FAIL]
>> 
>> Fixes: d69faad76584 ("selftests: fib_tests: Add prefix route tests with metric")
>> 
>> Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
>> ---
>>  tools/testing/selftests/net/fib_tests.sh | 0
>>  1 file changed, 0 insertions(+), 0 deletions(-)
>>  mode change 100644 => 100755 tools/testing/selftests/net/fib_tests.sh
>> 
>> diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh
>> old mode 100644
>> new mode 100755
>> 
> 
> Hi David,
> 
> Are you planning to pick this up for 4.18-rc3 or later?

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-28  7:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-19 16:20 [PATCH] selftests/net: Fix permissions for fib_tests.sh Daniel Díaz
2018-06-26 18:22 ` Shuah Khan
2018-06-28  7:15   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).