From: Stephen Boyd <sboyd@kernel.org>
To: Shawn Guo <shawnguo@kernel.org>
Cc: Anson Huang <anson.huang@nxp.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"matteo.lisi@engicam.com" <matteo.lisi@engicam.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
"michael@amarulasolutions.com" <michael@amarulasolutions.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks
Date: Fri, 06 Jul 2018 10:15:34 -0700 [thread overview]
Message-ID: <153089733418.143105.7025289108790540252@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20180701021947.GA4348@dragon>
Quoting Shawn Guo (2018-06-30 19:19:49)
> On Fri, Jun 29, 2018 at 11:39:38AM -0700, Stephen Boyd wrote:
> > Quoting Shawn Guo (2018-06-27 17:52:18)
> > > On Mon, Jun 25, 2018 at 03:14:39AM +0000, Anson Huang wrote:
> > > > Gentle Ping...
> > >
> > > I cannot apply this dts patch until the clock patch is landed on
> > > mainline, because it has a dependency on new clock ID IMX6UL_CLK_GPIO1
> > > created by clock patch.
> > >
> >
> > Does it matter if that clk ID changes across branches? Or is everything
> > good if it just exists as some number?
>
> We use macro IMX6UL_CLK_GPIO1 instead of hard-coded number in DTS. So
> it doesn't matter if IMX6UL_CLK_GPIO1 changes.
>
> > The patch adding the define
> > conflicts with another patch to fix the numbering scheme to be
> > incremental instead of changing IMX6UL and IMX6ULL which is annoying.
> > I'll probably make a topic branch just for the fix and merge it into
> > clk-fixes and this branch so you can pick it up from there if you like.
>
> It will be good if you can have a topic branch. Otherwise, we are also
> fine to wait till the clock patches lands on mainline.
>
Ok. The topic branch is out there as clk-imx-gpio-gates
next prev parent reply other threads:[~2018-07-06 17:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-03 1:44 [PATCH V2 1/2] clk: imx6ul: add GPIO clock gates Anson Huang
2018-06-03 1:44 ` [PATCH V2 2/2] ARM: dts: imx6ul: add GPIO clocks Anson Huang
2018-06-03 2:06 ` Fabio Estevam
2018-06-03 20:57 ` Fabio Estevam
2018-06-25 3:14 ` Anson Huang
2018-06-28 0:52 ` Shawn Guo
2018-06-29 18:39 ` Stephen Boyd
2018-07-01 2:19 ` Shawn Guo
2018-07-06 17:15 ` Stephen Boyd [this message]
2018-07-11 8:28 ` Shawn Guo
2018-06-03 2:06 ` [PATCH V2 1/2] clk: imx6ul: add GPIO clock gates Fabio Estevam
2018-06-05 21:10 ` Rob Herring
2018-06-29 18:42 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153089733418.143105.7025289108790540252@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=anson.huang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matteo.lisi@engicam.com \
--cc=michael@amarulasolutions.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).