* [RFT PATCH 0/2] pinctrl: Fix two more xxx_config_get() functions to be compliant
@ 2018-08-30 15:23 Douglas Anderson
2018-08-30 15:23 ` [RFT PATCH 1/2] pinctrl: ssbi-gpio: Fix pm8xxx_pin_config_get() " Douglas Anderson
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Douglas Anderson @ 2018-08-30 15:23 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij
Cc: Ivan T . Ivanov, Stephen Boyd, Douglas Anderson, linux-gpio,
linux-kernel, linux-arm-msm
I have no way to test the patches in this series, but Stephen Boyd
pointed out the problems being fixed here when he reviewed my patch
("pinctrl: qcom: spmi-gpio: Fix pmic_gpio_config_get() to be
compliant"). It seemed nice to (finally) follow-up and address the
problems that Stephen found. Hopefully someone can test them out and
make sure they work as advertised.
Douglas Anderson (2):
pinctrl: ssbi-gpio: Fix pm8xxx_pin_config_get() to be compliant
pinctrl: spmi-mpp: Fix pmic_mpp_config_get() to be compliant
drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 19 ++++++++++------
drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 28 ++++++++++++++++++------
2 files changed, 33 insertions(+), 14 deletions(-)
--
2.19.0.rc0.228.g281dcd1b4d0-goog
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RFT PATCH 1/2] pinctrl: ssbi-gpio: Fix pm8xxx_pin_config_get() to be compliant
2018-08-30 15:23 [RFT PATCH 0/2] pinctrl: Fix two more xxx_config_get() functions to be compliant Douglas Anderson
@ 2018-08-30 15:23 ` Douglas Anderson
2018-08-31 1:00 ` Stephen Boyd
2018-09-03 21:01 ` Bjorn Andersson
2018-08-30 15:23 ` [RFT PATCH 2/2] pinctrl: spmi-mpp: Fix pmic_mpp_config_get() " Douglas Anderson
2018-09-05 10:12 ` [RFT PATCH 0/2] pinctrl: Fix two more xxx_config_get() functions " Linus Walleij
2 siblings, 2 replies; 8+ messages in thread
From: Douglas Anderson @ 2018-08-30 15:23 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij
Cc: Ivan T . Ivanov, Stephen Boyd, Douglas Anderson, linux-gpio,
linux-kernel, linux-arm-msm
If you look at "pinconf-groups" in debugfs for ssbi-gpio you'll notice
it looks like nonsense.
The problem is fairly well described in commit 1cf86bc21257 ("pinctrl:
qcom: spmi-gpio: Fix pmic_gpio_config_get() to be compliant") and
commit 05e0c828955c ("pinctrl: msm: Fix msm_config_group_get() to be
compliant"), but it was pointed out that ssbi-gpio has the same
problem. Let's fix it there too.
Fixes: b4c45fe974bc ("pinctrl: qcom: ssbi: Family A gpio & mpp drivers")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 28 ++++++++++++++++++------
1 file changed, 21 insertions(+), 7 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
index f53e32a9d8fc..0e153bae322e 100644
--- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
@@ -260,22 +260,32 @@ static int pm8xxx_pin_config_get(struct pinctrl_dev *pctldev,
switch (param) {
case PIN_CONFIG_BIAS_DISABLE:
- arg = pin->bias == PM8XXX_GPIO_BIAS_NP;
+ if (pin->bias != PM8XXX_GPIO_BIAS_NP)
+ return -EINVAL;
+ arg = 1;
break;
case PIN_CONFIG_BIAS_PULL_DOWN:
- arg = pin->bias == PM8XXX_GPIO_BIAS_PD;
+ if (pin->bias != PM8XXX_GPIO_BIAS_PD)
+ return -EINVAL;
+ arg = 1;
break;
case PIN_CONFIG_BIAS_PULL_UP:
- arg = pin->bias <= PM8XXX_GPIO_BIAS_PU_1P5_30;
+ if (pin->bias > PM8XXX_GPIO_BIAS_PU_1P5_30)
+ return -EINVAL;
+ arg = 1;
break;
case PM8XXX_QCOM_PULL_UP_STRENGTH:
arg = pin->pull_up_strength;
break;
case PIN_CONFIG_BIAS_HIGH_IMPEDANCE:
- arg = pin->disable;
+ if (!pin->disable)
+ return -EINVAL;
+ arg = 1;
break;
case PIN_CONFIG_INPUT_ENABLE:
- arg = pin->mode == PM8XXX_GPIO_MODE_INPUT;
+ if (pin->mode != PM8XXX_GPIO_MODE_INPUT)
+ return -EINVAL;
+ arg = 1;
break;
case PIN_CONFIG_OUTPUT:
if (pin->mode & PM8XXX_GPIO_MODE_OUTPUT)
@@ -290,10 +300,14 @@ static int pm8xxx_pin_config_get(struct pinctrl_dev *pctldev,
arg = pin->output_strength;
break;
case PIN_CONFIG_DRIVE_PUSH_PULL:
- arg = !pin->open_drain;
+ if (pin->open_drain)
+ return -EINVAL;
+ arg = 1;
break;
case PIN_CONFIG_DRIVE_OPEN_DRAIN:
- arg = pin->open_drain;
+ if (!pin->open_drain)
+ return -EINVAL;
+ arg = 1;
break;
default:
return -EINVAL;
--
2.19.0.rc0.228.g281dcd1b4d0-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [RFT PATCH 2/2] pinctrl: spmi-mpp: Fix pmic_mpp_config_get() to be compliant
2018-08-30 15:23 [RFT PATCH 0/2] pinctrl: Fix two more xxx_config_get() functions to be compliant Douglas Anderson
2018-08-30 15:23 ` [RFT PATCH 1/2] pinctrl: ssbi-gpio: Fix pm8xxx_pin_config_get() " Douglas Anderson
@ 2018-08-30 15:23 ` Douglas Anderson
2018-08-31 1:00 ` Stephen Boyd
2018-09-03 21:04 ` Bjorn Andersson
2018-09-05 10:12 ` [RFT PATCH 0/2] pinctrl: Fix two more xxx_config_get() functions " Linus Walleij
2 siblings, 2 replies; 8+ messages in thread
From: Douglas Anderson @ 2018-08-30 15:23 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij
Cc: Ivan T . Ivanov, Stephen Boyd, Douglas Anderson, linux-gpio,
linux-kernel, linux-arm-msm
If you look at "pinconf-groups" in debugfs for ssbi-mpp you'll notice
it looks like nonsense.
The problem is fairly well described in commit 1cf86bc21257 ("pinctrl:
qcom: spmi-gpio: Fix pmic_gpio_config_get() to be compliant") and
commit 05e0c828955c ("pinctrl: msm: Fix msm_config_group_get() to be
compliant"), but it was pointed out that ssbi-mpp has the same
problem. Let's fix it there too.
NOTE: in case it's helpful to someone reading this, the way to tell
whether to do the -EINVAL or not is to look at the PCONFDUMP for a
given attribute. If the last element (has_arg) is false then you need
to do the -EINVAL trick.
ALSO NOTE: it seems unlikely that the values returned when we try to
get PIN_CONFIG_BIAS_PULL_UP will actually be printed since "has_arg"
is false for that one, but I guess it's still fine to return different
values so I kept doing that. It seems like another driver (ssbi-gpio)
uses a custom attribute (PM8XXX_QCOM_PULL_UP_STRENGTH) for something
similar so maybe a future change should do that here too.
Fixes: cfb24f6ebd38 ("pinctrl: Qualcomm SPMI PMIC MPP pin controller driver")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
index 6556dbeae65e..ce2950ffd525 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
@@ -343,13 +343,12 @@ static int pmic_mpp_config_get(struct pinctrl_dev *pctldev,
switch (param) {
case PIN_CONFIG_BIAS_DISABLE:
- arg = pad->pullup == PMIC_MPP_PULL_UP_OPEN;
+ if (pad->pullup != PMIC_MPP_PULL_UP_OPEN)
+ return -EINVAL;
+ arg = 1;
break;
case PIN_CONFIG_BIAS_PULL_UP:
switch (pad->pullup) {
- case PMIC_MPP_PULL_UP_OPEN:
- arg = 0;
- break;
case PMIC_MPP_PULL_UP_0P6KOHM:
arg = 600;
break;
@@ -364,13 +363,17 @@ static int pmic_mpp_config_get(struct pinctrl_dev *pctldev,
}
break;
case PIN_CONFIG_BIAS_HIGH_IMPEDANCE:
- arg = !pad->is_enabled;
+ if (pad->is_enabled)
+ return -EINVAL;
+ arg = 1;
break;
case PIN_CONFIG_POWER_SOURCE:
arg = pad->power_source;
break;
case PIN_CONFIG_INPUT_ENABLE:
- arg = pad->input_enabled;
+ if (!pad->input_enabled)
+ return -EINVAL;
+ arg = 1;
break;
case PIN_CONFIG_OUTPUT:
arg = pad->out_value;
@@ -382,7 +385,9 @@ static int pmic_mpp_config_get(struct pinctrl_dev *pctldev,
arg = pad->amux_input;
break;
case PMIC_MPP_CONF_PAIRED:
- arg = pad->paired;
+ if (!pad->paired)
+ return -EINVAL;
+ arg = 1;
break;
case PIN_CONFIG_DRIVE_STRENGTH:
arg = pad->drive_strength;
--
2.19.0.rc0.228.g281dcd1b4d0-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [RFT PATCH 1/2] pinctrl: ssbi-gpio: Fix pm8xxx_pin_config_get() to be compliant
2018-08-30 15:23 ` [RFT PATCH 1/2] pinctrl: ssbi-gpio: Fix pm8xxx_pin_config_get() " Douglas Anderson
@ 2018-08-31 1:00 ` Stephen Boyd
2018-09-03 21:01 ` Bjorn Andersson
1 sibling, 0 replies; 8+ messages in thread
From: Stephen Boyd @ 2018-08-31 1:00 UTC (permalink / raw)
To: Bjorn Andersson, Douglas Anderson, Linus Walleij
Cc: Ivan T . Ivanov, Douglas Anderson, linux-gpio, linux-kernel,
linux-arm-msm
Quoting Douglas Anderson (2018-08-30 08:23:38)
> If you look at "pinconf-groups" in debugfs for ssbi-gpio you'll notice
> it looks like nonsense.
>
> The problem is fairly well described in commit 1cf86bc21257 ("pinctrl:
> qcom: spmi-gpio: Fix pmic_gpio_config_get() to be compliant") and
> commit 05e0c828955c ("pinctrl: msm: Fix msm_config_group_get() to be
> compliant"), but it was pointed out that ssbi-gpio has the same
> problem. Let's fix it there too.
>
> Fixes: b4c45fe974bc ("pinctrl: qcom: ssbi: Family A gpio & mpp drivers")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFT PATCH 2/2] pinctrl: spmi-mpp: Fix pmic_mpp_config_get() to be compliant
2018-08-30 15:23 ` [RFT PATCH 2/2] pinctrl: spmi-mpp: Fix pmic_mpp_config_get() " Douglas Anderson
@ 2018-08-31 1:00 ` Stephen Boyd
2018-09-03 21:04 ` Bjorn Andersson
1 sibling, 0 replies; 8+ messages in thread
From: Stephen Boyd @ 2018-08-31 1:00 UTC (permalink / raw)
To: Bjorn Andersson, Douglas Anderson, Linus Walleij
Cc: Ivan T . Ivanov, Douglas Anderson, linux-gpio, linux-kernel,
linux-arm-msm
Quoting Douglas Anderson (2018-08-30 08:23:39)
> If you look at "pinconf-groups" in debugfs for ssbi-mpp you'll notice
> it looks like nonsense.
>
> The problem is fairly well described in commit 1cf86bc21257 ("pinctrl:
> qcom: spmi-gpio: Fix pmic_gpio_config_get() to be compliant") and
> commit 05e0c828955c ("pinctrl: msm: Fix msm_config_group_get() to be
> compliant"), but it was pointed out that ssbi-mpp has the same
> problem. Let's fix it there too.
>
> NOTE: in case it's helpful to someone reading this, the way to tell
> whether to do the -EINVAL or not is to look at the PCONFDUMP for a
> given attribute. If the last element (has_arg) is false then you need
> to do the -EINVAL trick.
>
> ALSO NOTE: it seems unlikely that the values returned when we try to
> get PIN_CONFIG_BIAS_PULL_UP will actually be printed since "has_arg"
> is false for that one, but I guess it's still fine to return different
> values so I kept doing that. It seems like another driver (ssbi-gpio)
> uses a custom attribute (PM8XXX_QCOM_PULL_UP_STRENGTH) for something
> similar so maybe a future change should do that here too.
>
> Fixes: cfb24f6ebd38 ("pinctrl: Qualcomm SPMI PMIC MPP pin controller driver")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFT PATCH 1/2] pinctrl: ssbi-gpio: Fix pm8xxx_pin_config_get() to be compliant
2018-08-30 15:23 ` [RFT PATCH 1/2] pinctrl: ssbi-gpio: Fix pm8xxx_pin_config_get() " Douglas Anderson
2018-08-31 1:00 ` Stephen Boyd
@ 2018-09-03 21:01 ` Bjorn Andersson
1 sibling, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2018-09-03 21:01 UTC (permalink / raw)
To: Douglas Anderson
Cc: Linus Walleij, Ivan T . Ivanov, Stephen Boyd, linux-gpio,
linux-kernel, linux-arm-msm
On Thu 30 Aug 08:23 PDT 2018, Douglas Anderson wrote:
> If you look at "pinconf-groups" in debugfs for ssbi-gpio you'll notice
> it looks like nonsense.
>
> The problem is fairly well described in commit 1cf86bc21257 ("pinctrl:
> qcom: spmi-gpio: Fix pmic_gpio_config_get() to be compliant") and
> commit 05e0c828955c ("pinctrl: msm: Fix msm_config_group_get() to be
> compliant"), but it was pointed out that ssbi-gpio has the same
> problem. Let's fix it there too.
>
> Fixes: b4c45fe974bc ("pinctrl: qcom: ssbi: Family A gpio & mpp drivers")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
>
> drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c | 28 ++++++++++++++++++------
> 1 file changed, 21 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
> index f53e32a9d8fc..0e153bae322e 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c
> @@ -260,22 +260,32 @@ static int pm8xxx_pin_config_get(struct pinctrl_dev *pctldev,
>
> switch (param) {
> case PIN_CONFIG_BIAS_DISABLE:
> - arg = pin->bias == PM8XXX_GPIO_BIAS_NP;
> + if (pin->bias != PM8XXX_GPIO_BIAS_NP)
> + return -EINVAL;
> + arg = 1;
> break;
> case PIN_CONFIG_BIAS_PULL_DOWN:
> - arg = pin->bias == PM8XXX_GPIO_BIAS_PD;
> + if (pin->bias != PM8XXX_GPIO_BIAS_PD)
> + return -EINVAL;
> + arg = 1;
> break;
> case PIN_CONFIG_BIAS_PULL_UP:
> - arg = pin->bias <= PM8XXX_GPIO_BIAS_PU_1P5_30;
> + if (pin->bias > PM8XXX_GPIO_BIAS_PU_1P5_30)
> + return -EINVAL;
> + arg = 1;
> break;
> case PM8XXX_QCOM_PULL_UP_STRENGTH:
> arg = pin->pull_up_strength;
> break;
> case PIN_CONFIG_BIAS_HIGH_IMPEDANCE:
> - arg = pin->disable;
> + if (!pin->disable)
> + return -EINVAL;
> + arg = 1;
> break;
> case PIN_CONFIG_INPUT_ENABLE:
> - arg = pin->mode == PM8XXX_GPIO_MODE_INPUT;
> + if (pin->mode != PM8XXX_GPIO_MODE_INPUT)
> + return -EINVAL;
> + arg = 1;
> break;
> case PIN_CONFIG_OUTPUT:
> if (pin->mode & PM8XXX_GPIO_MODE_OUTPUT)
> @@ -290,10 +300,14 @@ static int pm8xxx_pin_config_get(struct pinctrl_dev *pctldev,
> arg = pin->output_strength;
> break;
> case PIN_CONFIG_DRIVE_PUSH_PULL:
> - arg = !pin->open_drain;
> + if (pin->open_drain)
> + return -EINVAL;
> + arg = 1;
> break;
> case PIN_CONFIG_DRIVE_OPEN_DRAIN:
> - arg = pin->open_drain;
> + if (!pin->open_drain)
> + return -EINVAL;
> + arg = 1;
> break;
> default:
> return -EINVAL;
> --
> 2.19.0.rc0.228.g281dcd1b4d0-goog
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFT PATCH 2/2] pinctrl: spmi-mpp: Fix pmic_mpp_config_get() to be compliant
2018-08-30 15:23 ` [RFT PATCH 2/2] pinctrl: spmi-mpp: Fix pmic_mpp_config_get() " Douglas Anderson
2018-08-31 1:00 ` Stephen Boyd
@ 2018-09-03 21:04 ` Bjorn Andersson
1 sibling, 0 replies; 8+ messages in thread
From: Bjorn Andersson @ 2018-09-03 21:04 UTC (permalink / raw)
To: Douglas Anderson
Cc: Linus Walleij, Ivan T . Ivanov, Stephen Boyd, linux-gpio,
linux-kernel, linux-arm-msm
On Thu 30 Aug 08:23 PDT 2018, Douglas Anderson wrote:
> If you look at "pinconf-groups" in debugfs for ssbi-mpp you'll notice
> it looks like nonsense.
>
> The problem is fairly well described in commit 1cf86bc21257 ("pinctrl:
> qcom: spmi-gpio: Fix pmic_gpio_config_get() to be compliant") and
> commit 05e0c828955c ("pinctrl: msm: Fix msm_config_group_get() to be
> compliant"), but it was pointed out that ssbi-mpp has the same
> problem. Let's fix it there too.
>
> NOTE: in case it's helpful to someone reading this, the way to tell
> whether to do the -EINVAL or not is to look at the PCONFDUMP for a
> given attribute. If the last element (has_arg) is false then you need
> to do the -EINVAL trick.
>
> ALSO NOTE: it seems unlikely that the values returned when we try to
> get PIN_CONFIG_BIAS_PULL_UP will actually be printed since "has_arg"
> is false for that one, but I guess it's still fine to return different
> values so I kept doing that. It seems like another driver (ssbi-gpio)
> uses a custom attribute (PM8XXX_QCOM_PULL_UP_STRENGTH) for something
> similar so maybe a future change should do that here too.
>
> Fixes: cfb24f6ebd38 ("pinctrl: Qualcomm SPMI PMIC MPP pin controller driver")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
>
> drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
> index 6556dbeae65e..ce2950ffd525 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
> @@ -343,13 +343,12 @@ static int pmic_mpp_config_get(struct pinctrl_dev *pctldev,
>
> switch (param) {
> case PIN_CONFIG_BIAS_DISABLE:
> - arg = pad->pullup == PMIC_MPP_PULL_UP_OPEN;
> + if (pad->pullup != PMIC_MPP_PULL_UP_OPEN)
> + return -EINVAL;
> + arg = 1;
> break;
> case PIN_CONFIG_BIAS_PULL_UP:
> switch (pad->pullup) {
> - case PMIC_MPP_PULL_UP_OPEN:
> - arg = 0;
> - break;
> case PMIC_MPP_PULL_UP_0P6KOHM:
> arg = 600;
> break;
> @@ -364,13 +363,17 @@ static int pmic_mpp_config_get(struct pinctrl_dev *pctldev,
> }
> break;
> case PIN_CONFIG_BIAS_HIGH_IMPEDANCE:
> - arg = !pad->is_enabled;
> + if (pad->is_enabled)
> + return -EINVAL;
> + arg = 1;
> break;
> case PIN_CONFIG_POWER_SOURCE:
> arg = pad->power_source;
> break;
> case PIN_CONFIG_INPUT_ENABLE:
> - arg = pad->input_enabled;
> + if (!pad->input_enabled)
> + return -EINVAL;
> + arg = 1;
> break;
> case PIN_CONFIG_OUTPUT:
> arg = pad->out_value;
> @@ -382,7 +385,9 @@ static int pmic_mpp_config_get(struct pinctrl_dev *pctldev,
> arg = pad->amux_input;
> break;
> case PMIC_MPP_CONF_PAIRED:
> - arg = pad->paired;
> + if (!pad->paired)
> + return -EINVAL;
> + arg = 1;
> break;
> case PIN_CONFIG_DRIVE_STRENGTH:
> arg = pad->drive_strength;
> --
> 2.19.0.rc0.228.g281dcd1b4d0-goog
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFT PATCH 0/2] pinctrl: Fix two more xxx_config_get() functions to be compliant
2018-08-30 15:23 [RFT PATCH 0/2] pinctrl: Fix two more xxx_config_get() functions to be compliant Douglas Anderson
2018-08-30 15:23 ` [RFT PATCH 1/2] pinctrl: ssbi-gpio: Fix pm8xxx_pin_config_get() " Douglas Anderson
2018-08-30 15:23 ` [RFT PATCH 2/2] pinctrl: spmi-mpp: Fix pmic_mpp_config_get() " Douglas Anderson
@ 2018-09-05 10:12 ` Linus Walleij
2 siblings, 0 replies; 8+ messages in thread
From: Linus Walleij @ 2018-09-05 10:12 UTC (permalink / raw)
To: Doug Anderson
Cc: Bjorn Andersson, Ivan T. Ivanov, Stephen Boyd,
open list:GPIO SUBSYSTEM, linux-kernel, linux-arm-msm
On Thu, Aug 30, 2018 at 5:24 PM Douglas Anderson <dianders@chromium.org> wrote:
> I have no way to test the patches in this series, but Stephen Boyd
> pointed out the problems being fixed here when he reviewed my patch
> ("pinctrl: qcom: spmi-gpio: Fix pmic_gpio_config_get() to be
> compliant"). It seemed nice to (finally) follow-up and address the
> problems that Stephen found. Hopefully someone can test them out and
> make sure they work as advertised.
Both patches applied with the review tags.
If people don't test RFT patches, then maybe they will test
linux-next.
So applied to devel for now.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-09-05 10:12 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-30 15:23 [RFT PATCH 0/2] pinctrl: Fix two more xxx_config_get() functions to be compliant Douglas Anderson
2018-08-30 15:23 ` [RFT PATCH 1/2] pinctrl: ssbi-gpio: Fix pm8xxx_pin_config_get() " Douglas Anderson
2018-08-31 1:00 ` Stephen Boyd
2018-09-03 21:01 ` Bjorn Andersson
2018-08-30 15:23 ` [RFT PATCH 2/2] pinctrl: spmi-mpp: Fix pmic_mpp_config_get() " Douglas Anderson
2018-08-31 1:00 ` Stephen Boyd
2018-09-03 21:04 ` Bjorn Andersson
2018-09-05 10:12 ` [RFT PATCH 0/2] pinctrl: Fix two more xxx_config_get() functions " Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).