* [PATCH] net: phy: Fix a unused function gcc warning.
@ 2018-09-29 5:11 zhong jiang
2018-09-29 20:36 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: zhong jiang @ 2018-09-29 5:11 UTC (permalink / raw)
To: davem; +Cc: f.fainelli, andrew, netdev, linux-kernel
Fix the following compile warning:
drivers/net/phy/mdio-bcm-unimac.c:321:12: warning: 'unimac_mdio_suspend' defined but not used [-Wunused-function]
static int unimac_mdio_suspend(struct device *d)
^
drivers/net/phy/mdio-bcm-unimac.c:330:12: warning: 'unimac_mdio_resume' defined but not used [-Wunused-function]
static int unimac_mdio_resume(struct device *d)
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/net/phy/mdio-bcm-unimac.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/phy/mdio-bcm-unimac.c b/drivers/net/phy/mdio-bcm-unimac.c
index 80b9583..f5b83ea 100644
--- a/drivers/net/phy/mdio-bcm-unimac.c
+++ b/drivers/net/phy/mdio-bcm-unimac.c
@@ -318,6 +318,7 @@ static int unimac_mdio_remove(struct platform_device *pdev)
return 0;
}
+#ifdef CONFIG_PM_SLEEP
static int unimac_mdio_suspend(struct device *d)
{
struct unimac_mdio_priv *priv = dev_get_drvdata(d);
@@ -343,6 +344,7 @@ static int unimac_mdio_resume(struct device *d)
static SIMPLE_DEV_PM_OPS(unimac_mdio_pm_ops,
unimac_mdio_suspend, unimac_mdio_resume);
+#endif /* CONFIG_PM_SLEEP */
static const struct of_device_id unimac_mdio_ids[] = {
{ .compatible = "brcm,genet-mdio-v5", },
@@ -359,7 +361,9 @@ static SIMPLE_DEV_PM_OPS(unimac_mdio_pm_ops,
.driver = {
.name = UNIMAC_MDIO_DRV_NAME,
.of_match_table = unimac_mdio_ids,
+#ifdef CONFIG_PM_SLEEP
.pm = &unimac_mdio_pm_ops,
+#endif
},
.probe = unimac_mdio_probe,
.remove = unimac_mdio_remove,
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: Fix a unused function gcc warning.
2018-09-29 5:11 [PATCH] net: phy: Fix a unused function gcc warning zhong jiang
@ 2018-09-29 20:36 ` Florian Fainelli
2018-09-30 1:31 ` zhong jiang
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2018-09-29 20:36 UTC (permalink / raw)
To: zhong jiang, davem; +Cc: andrew, netdev, linux-kernel
On September 28, 2018 10:11:43 PM PDT, zhong jiang <zhongjiang@huawei.com> wrote:
>Fix the following compile warning:
>
>drivers/net/phy/mdio-bcm-unimac.c:321:12: warning:
>'unimac_mdio_suspend' defined but not used [-Wunused-function]
> static int unimac_mdio_suspend(struct device *d)
> ^
>drivers/net/phy/mdio-bcm-unimac.c:330:12: warning: 'unimac_mdio_resume'
>defined but not used [-Wunused-function]
> static int unimac_mdio_resume(struct device *d)
>
>Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Thank you, Arnd already sent a patch for this which got accepted:
https://patchwork.ozlabs.org/patch/975088/
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: Fix a unused function gcc warning.
2018-09-29 20:36 ` Florian Fainelli
@ 2018-09-30 1:31 ` zhong jiang
0 siblings, 0 replies; 3+ messages in thread
From: zhong jiang @ 2018-09-30 1:31 UTC (permalink / raw)
To: Florian Fainelli; +Cc: davem, andrew, netdev, linux-kernel
On 2018/9/30 4:36, Florian Fainelli wrote:
>
> On September 28, 2018 10:11:43 PM PDT, zhong jiang <zhongjiang@huawei.com> wrote:
>> Fix the following compile warning:
>>
>> drivers/net/phy/mdio-bcm-unimac.c:321:12: warning:
>> 'unimac_mdio_suspend' defined but not used [-Wunused-function]
>> static int unimac_mdio_suspend(struct device *d)
>> ^
>> drivers/net/phy/mdio-bcm-unimac.c:330:12: warning: 'unimac_mdio_resume'
>> defined but not used [-Wunused-function]
>> static int unimac_mdio_resume(struct device *d)
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> Thank you, Arnd already sent a patch for this which got accepted:
>
> https://patchwork.ozlabs.org/patch/975088/
Ok, Thanks, I miss that.
Sincerely,
zhong jiang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-30 1:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-29 5:11 [PATCH] net: phy: Fix a unused function gcc warning zhong jiang
2018-09-29 20:36 ` Florian Fainelli
2018-09-30 1:31 ` zhong jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).